Re: [PATCH 0/3] media: ov9734, ipu-bridge: Enable the camera on the Intel NUC M15

[Afonso Figuinha <afonso.figuinha@gmail.com>]

Hi Tin,

I tested this series on a Microsoft Surface Laptop 1, which has the
same OV9734 behind an IPU3 CIO2. There an INT3472 discrete device
provides the clock enable and the reset GPIO, and the _PR0 power
resource of the sensor does nothing.

I used 6.19.8-surface-3 with patches 1 and 2 applied (they apply with
one-line offsets). Patch 3 does not apply there because the sensor list
differs, so I added the same entry by hand.

- the sensor probes and the chip ID reads back;
- libcamera master with the OV9734 fixes from series 6330 [1] (IPU3
  pipeline) streams 1280x704 NV12 at 30 fps;
- the sensor is runtime suspended when idle;
- unloading and reloading the module gives no kernel warnings;
- v4l2-compliance 1.32.0 on the subdev: 45/46, only the known
  SUBSCRIBE_EVENT failure.

Not tested: probe deferral at boot with these exact patches, and
system suspend.

Tested-by: Afonso Figuinha <afonso.figuinha@gmail.com> # Surface Laptop 1 (IPU3)

I posted a duplicate series by mistake before I saw yours, and I have
withdrawn it. Its patch 4 sets V4L2_SUBDEV_FL_HAS_EVENTS and uses the
control event helpers, which fixes the SUBSCRIBE_EVENT failure. I can
send it on top of your series, or you can fold it in, as you prefer.

[1] https://patchwork.libcamera.org/project/libcamera/list/?series=6330

Thanks,
Afonso