mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Armin Wolf <W_Armin@gmx.de>
To: lyude@redhat.com, dakr@kernel.org
Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	airlied@gmail.com, simona@ffwll.ch,
	dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] drm/nouveau: Fix Kconfig issue with CONFIG_ACPI_WMI
Date: Sat,  7 Nov 2026 01:13:05 +0100	[thread overview]
Message-ID: <20261107001330.403365-1-W_Armin@gmx.de> (raw)

Nouveau uses wmi_evaluate_method() when CONFIG_ACPI_WMI has been
enabled, but this alone does not guarantee that CONFIG_ACPI_WMI
is actually reachable. If CONFIG_ACPI_WMI is m and CONFIG_DRM_NOUVEAU
is y, said function will not be reachable by nouveau, resulting in
a linker error.

Until now this issue was not triggered because on x86
CONFIG_ACPI_WMI is automatically selected by nouveau. However the
ACPI-WMI subsystem has added support for other ACPI-compatible
architectures like Risc V, making it possible for users to trigger
this bug.

Fix this by always selecting ACPI_WMI if ACPI support is enabled
to ensure that nouveau can actually reach wmi_evaluate_method().

Fixes: 884d53763d30 ("platform/wmi: Remove dependency on CONFIG_X86")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202611070038.qzOOv1De-lkp@intel.com/
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
---
 drivers/gpu/drm/nouveau/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig
index 3b5757aed9c8..9c5716738b18 100644
--- a/drivers/gpu/drm/nouveau/Kconfig
+++ b/drivers/gpu/drm/nouveau/Kconfig
@@ -19,7 +19,7 @@ config DRM_NOUVEAU
 	select I2C_ALGOBIT
 	select BACKLIGHT_CLASS_DEVICE if DRM_NOUVEAU_BACKLIGHT
 	select X86_PLATFORM_DEVICES if ACPI && X86
-	select ACPI_WMI if ACPI && X86
+	select ACPI_WMI if ACPI
 	select MXM_WMI if ACPI && X86
 	select POWER_SUPPLY
 	# Similar to i915, we need to select ACPI_VIDEO and it's dependencies
-- 
2.56.0


                 reply	other threads:[~2026-11-07  0:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261107001330.403365-1-W_Armin@gmx.de \
    --to=w_armin@gmx.de \
    --cc=airlied@gmail.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lyude@redhat.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®