From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: aleszlucero@gmail.com
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: octeon: fix race condition and log macro in ethernet-rgmii.c
Date: Sat, 7 Nov 2026 14:15:40 -0500 [thread overview]
Message-ID: <2026110701-editor-surprise-fa14@gregkh> (raw)
In-Reply-To: <20261107-octeon-rgmii-fixes-v1-1-3cd7734fd2ee@gmail.com>
On Sat, Nov 07, 2026 at 09:52:10AM -0600, Oscar Alejandro Sánchez Lucero via B4 Relay wrote:
> From: Oscar Alejandro Sánchez Lucero <aleszlucero@gmail.com>
>
> Fix a race condition in cvm_oct_check_preamble_errors() by moving the
> read assignment of priv->link_info inside the global_register_lock
> protected critical section. This prevents unsynchronized read-accesses
> concurring with status mutations from concurrent polling contexts.
>
> Additionally, modernize the message output by replacing the obsolete
> printk_ratelimited() call with netdev_notice_ratelimited().
>
> Signed-off-by: Oscar Alejandro Sánchez Lucero <aleszlucero@gmail.com>
> ---
> drivers/staging/octeon/ethernet-rgmii.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
How did you find and test all of these patches?
And why did you send 17 of them all at once, not in a series at all?
How are we to know what order to apply them in?
I've dropped them all now, please fix and resend properly.
thanks,
greg k-h
prev parent reply other threads:[~2026-11-07 19:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 15:52 Oscar Alejandro Sánchez Lucero via B4 Relay
2026-11-07 19:15 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026110701-editor-surprise-fa14@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=aleszlucero@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®