From: Radu Toader <radu.m.toader@gmail.com>
To: bot+bpf-ci@kernel.org
Cc: peterz@infradead.org, tj@kernel.org, tglx@kernel.org,
mingo@redhat.com, linux-kernel@vger.kernel.org,
sched-ext@lists.linux.dev, bpf@vger.kernel.org
Subject: Re: [PATCH 2/2] softirq: Treat an interrupted idle task as idle in tick_irq_exit()
Date: Sat, 7 Nov 2026 02:15:08 +0000 [thread overview]
Message-ID: <20261107021509.968928-3-radu.m.toader@gmail.com> (raw)
In-Reply-To: <d8c4fb5ce3e465c9c9e562c851d586ef8e5cc43d85d61998f63f2c48d431778e@mail.kernel.org>
Both points are right and both are changelog-only, as the report says.
Fixed in v2.
On the first: PF_IDLE is indeed set by cpu_startup_entry() and not by
init_idle(), which I checked - init_idle() sets PF_KTHREAD and
PF_NO_SETAFFINITY only. So the gates overlap rather than one containing
the other, and "strictly wider" is wrong. v2 drops it, names the state
that is no longer covered, and says why nothing is lost there:
TS_FLAG_INIDLE is only set inside do_idle(), so tick_nohz_irq_exit() had
nothing to do before cpu_startup_entry(), and nohz_full CPUs stay
covered by tick_nohz_full_cpu(cpu).
On the second: injected idle is now named among the newly covered
states, with play_idle_precise() cited and the reach beyond sched_ext
spelled out - intel_powerclamp and cpuidle_cooling via
drivers/powercap/idle_inject.c. Peter Zijlstra raised the same point and
has a reply of his own in the thread; the gap in the changelog was real
and is closed.
No code change in v2.
Disclosure: this reply was written by Claude Opus 5 (Claude Code) and
sent on my behalf, in the same session as the patch; the patch changelog
carries the same note.
next prev parent reply other threads:[~2026-11-07 2:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 9:43 [PATCH 0/2] softirq: fix idle accounting for an interrupted idle task Radu Toader
2026-11-06 9:43 ` [PATCH 1/2] sched_ext: Add scx_tickbug, a scheduler that holds a task on an idle CPU Radu Toader
2026-11-06 16:59 ` Tejun Heo
2026-11-07 2:15 ` Radu Toader
2026-11-06 20:10 ` bot+bpf-ci
2026-11-07 2:15 ` Radu Toader
2026-11-06 9:43 ` [PATCH 2/2] softirq: Treat an interrupted idle task as idle in tick_irq_exit() Radu Toader
2026-11-06 10:23 ` Peter Zijlstra
2026-11-07 2:15 ` Radu Toader
2026-11-06 19:55 ` bot+bpf-ci
2026-11-07 2:15 ` Radu Toader [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-11-05 20:02 [PATCH 0/2] softirq: fix idle accounting for an interrupted idle task Radu Toader
2026-11-05 20:02 ` [PATCH 2/2] softirq: Treat an interrupted idle task as idle in tick_irq_exit() Radu Toader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261107021509.968928-3-radu.m.toader@gmail.com \
--to=radu.m.toader@gmail.com \
--cc=bot+bpf-ci@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sched-ext@lists.linux.dev \
--cc=tglx@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®