mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wentao Liang <vulab@iscas.ac.cn>
To: Mark Brown <broonie@kernel.org>
Cc: linux-regulator@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: tps6594-regulator: Fix np_pmic_parent leak in tps6594_regulator_probe()
Date: Fri, 7 Nov 2026 15:00:00 +0800	[thread overview]
Message-ID: <20261107070000.0000000-1-vulab@iscas.ac.cn> (raw)
In-Reply-To: <9931609e-c74a-45b3-8dc9-ced30cc44d81@sirena.org.uk>

On Thu, Sep 17, 2026 at 11:21:42PM +0100, Mark Brown wrote:
> This doesn't apply against current code, please check and resend.

Sorry for the very late reply, and for not checking the patch against
current code before sending it.

The reason it does not apply is that the leak has already been fixed by

  7fd28093b3ef ("regulator: tps6594: Fix device node reference leaks in multiphase loop")

which releases np, the intermediate parent and np_pmic_parent at the end
of each iteration, and adds the missing NULL check after
of_find_node_by_name() as well.  The commit is in v7.3-rc1 and later, and
I confirmed that current mainline has no unbalanced of_get_parent() left
in that loop.

So there is nothing to resend from my side, and I will not submit a
duplicate.  Sorry again for the delay and for the noise.

Thanks,
Wentao


      reply	other threads:[~2026-11-07 14:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17 14:31 Wentao Liang
2026-09-17 22:21 ` Mark Brown
2026-11-07  7:00   ` Wentao Liang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261107070000.0000000-1-vulab@iscas.ac.cn \
    --to=vulab@iscas.ac.cn \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-regulator@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®