mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wentao Liang <vulab@iscas.ac.cn>
To: Hans de Goede <hansg@kernel.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Maximilian Luz" <luzmaximilian@gmail.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: [PATCH v2 0/2] platform/surface: aggregator: Fix packet list handling in ssh_ptl_shutdown()
Date: Sat, 07 Nov 2026 08:07:30 +0000	[thread overview]
Message-ID: <20261107080730.0-vulab@iscas.ac.cn> (raw)

Hi Maximilian, Ilpo,

this is a split of the single patch I sent in September, following the
review comments from Ilpo and Maximilian. The two problems in
ssh_ptl_shutdown() are independent, so patch 1 corrects the list that
pending packets are moved to, and patch 2 makes both drain loops safe
against the packet being released while iterating.

Changes in v2:
 - Sorry for the delay in getting back to this review.
 - Split into two patches as requested, instead of one patch that mixes
   two independent problems.
 - The pending/complete list mismatch has its own changelog describing
   the effect of the wrong list node, as Maximilian asked for.
 - Both patches carry Maximilian's Acked-by.

Link: https://lore.kernel.org/all/20260917135607.2154130-1-vulab@iscas.ac.cn/

The candidate was found with our static analysis tooling; the audit and
the fix were then assisted by DeepSeek and GPT-6.1 Sol. The patches are
based on mainline as of d4872371bae (v7.4-rc1) and were built for x86_64
with CONFIG_SURFACE_AGGREGATOR=m, without new warnings; checkpatch.pl
reports no issues. I could not test them at runtime, as that needs a
Surface device shutting down with packets still queued or pending.

Wentao Liang (2):
  platform/surface: aggregator: Fix wrong completion list for pending
    packets
  platform/surface: aggregator: Fix use-after-free in ssh_ptl_shutdown()

 drivers/platform/surface/aggregator/ssh_packet_layer.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.34.1


             reply	other threads:[~2026-11-07  8:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-07  8:07 Wentao Liang [this message]
2026-11-07  8:07 ` [PATCH v2 1/2] platform/surface: aggregator: Fix wrong completion list for pending packets Wentao Liang
2026-11-07  8:07 ` [PATCH v2 2/2] platform/surface: aggregator: Fix use-after-free in ssh_ptl_shutdown() Wentao Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261107080730.0-vulab@iscas.ac.cn \
    --to=vulab@iscas.ac.cn \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luzmaximilian@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®