From: Arnav Kapoor <kapoorarnav43@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Gwendal Grignou" <gwendal@chromium.org>,
"Stephen Boyd" <swboyd@chromium.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Arnav Kapoor" <kapoorarnav43@gmail.com>
Subject: [PATCH] iio: proximity: sx9310: fix semtech,proxraw-strength = <0>
Date: Sat, 7 Nov 2026 20:05:20 +0530 [thread overview]
Message-ID: <20261107143523.465188-1-kapoorarnav43@gmail.com> (raw)
The binding allows semtech,proxraw-strength values of 0, 2, 4 and 8,
where 0 turns the PROXRAW filter off and the others select a strength of
1 - 1/N, i.e. register codes 1 to 3.
sx9310_get_default_reg() converts the property with ilog2(raw). For 0,
ilog2() returns -1, which FIELD_PREP() masks to 3 in the 2-bit RAWFILT
field. A board that asks for the filter to be off therefore gets the
strongest filter, the same as semtech,proxraw-strength = <8>.
Keep 0 as register code 0.
Fixes: 5b19ca2c78a0 ("iio: sx9310: Set various settings from DT")
Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
---
No in-tree DT uses semtech,proxraw-strength = <0> (sc7180-trogdor-lazor
uses 8), so this only affects out-of-tree boards. I checked the
mapping with a userspace copy of the ilog2()/FIELD_PREP() conversion:
0 and 8 both give RAWFILT = 3 before this patch, 0 gives 0 after it.
Compile-tested only (W=1); I don't have SX9310 hardware.
drivers/iio/proximity/sx9310.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/proximity/sx9310.c b/drivers/iio/proximity/sx9310.c
index 2585b9c6fb69..a39277237d39 100644
--- a/drivers/iio/proximity/sx9310.c
+++ b/drivers/iio/proximity/sx9310.c
@@ -855,7 +855,8 @@ sx9310_get_default_reg(struct device *dev, int idx,
if (ret) {
raw = FIELD_GET(SX9310_REG_PROX_CTRL5_RAWFILT_MASK,
reg_def->def);
- } else {
+ } else if (raw) {
+ /* 0 means off; 2, 4 and 8 are codes 1 to 3. */
raw = ilog2(raw);
}
base-commit: 340d44bdf9db0f095f99845b5ad8628781d79b6f
--
2.53.0
reply other threads:[~2026-11-07 14:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261107143523.465188-1-kapoorarnav43@gmail.com \
--to=kapoorarnav43@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®