From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=pass header.oldest-pass=0 smtp.remote-ip=52.101.193.25 ARC-Seal: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=pass; t=1794066510; b=t/vwagp7b97sO6LfdwMqFYHqmo78ZtocnTx9sLudM6BATmUhW7l/UOtd4y5pJISzR+Xa 64YFa8LGbyKfHBohsUwo1fTSwS6/QGJzWobUoY3B5doJZY5xCmccCYoJsHQCnxP0oJzdM bNnpdk+tAgSLYScCMDQ2DoFAZLVy1575PIaUY+4D2RtmwCYeRpScwqzB7CzaN014yRnnc iCjYAlJed23/ycJqE0k/UjcR8+0lN6MKFp5KBHnr7jpEXsmJ5E4wHOX7o0krrlLv5b7+E DWzhEfDdP6dyLh4fMe35dEhqGn09WqSaGJ6oqqWF429AN0aDeNXtaYrpE1GYuqWodNw== ARC-Message-Signature: i=2; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794066510; h=DMARC-Filter:DKIM-Signature:Received:Received: X-MS-Exchange-Authentication-Results:Received-SPF:Received:Received: Received:Received:From:To:CC:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding: Content-Type:X-EOPAttributedMessage:X-MS-PublicTrafficType: X-MS-TrafficTypeDiagnostic:X-MS-Office365-Filtering-Correlation-Id: X-MS-Exchange-SenderADCheck:X-MS-Exchange-AntiSpam-Relay: X-Microsoft-Antispam:X-Microsoft-Antispam-Message-Info: X-Forefront-Antispam-Report: X-MS-Exchange-AntiSpam-MessageData-ChunkCount: X-MS-Exchange-AntiSpam-MessageData-0:X-OriginatorOrg: X-MS-Exchange-CrossTenant-OriginalArrivalTime: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-Id: X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-FromEntityHeader: X-MS-Exchange-Transport-CrossTenantHeadersStamped; bh=ovC+HwCPiNOYBxBwLz2Xc0PdfEsPYQ0NpYPibCVlEVs=; b=d6A1GByepSycHONDlPlg7k4zT0nEgJ0Q5LK79Gy7SYRXHpn86e2fy7Ga18FelFeMqADv esJBNNrhdTaOXleNQCSbRLPOv5sWQDlbT3KEbkY1dfshL47FQvzI28+U6jT9qg8Cur4FE v+gb2kw+6ADCTBJ7N3MHUJhUxxqax87Zl9BNuHDtElgrRoOGz/NLmIuVylA4Amx4cvEdW mC/3YLDgqb2M9HZmm8nxnzJ47NkwIokSQBtoiPkhAl4phkaWsdUy1Z8kGJyXOlZVgr9DN KOG0BZ1d4GUegZsa4DzMHfgyh4rvcwJ/QBIEDcF+wE/sFFG9Gs94kdO9ZfOJSeyc7WQ== ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=PSA13hxM; arc=pass header.oldest-pass=0 smtp.remote-ip=52.101.193.25 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010025.outbound.protection.outlook.com [52.101.193.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (secp384r1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 395346082BD2; Sat, 7 Nov 2026 15:48:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 395346082BD2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=PSA13hxM ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pGCU4EkhIMDWD31qj0gKiLrsL8A26R7btLwTHAXfFT+nAnC1sKy+oIlC6TiVgE0b0J+jYPeQxzy2j4W8FUL8KRee2xBeyS9nua+JfArGywGiqttIew/hI2I+2fEoFYzXMoRg+KsjmfrToaahftAoEf9qss3a1o7nC5r2E5RcGu5zs3iQspPWJ9Jx1EGnxMteNai2y4V/nVMuSnH8+lrVJ91KU+l6l7u0HvlrAMW3+Isgx2YVoOuiwRgmjExjYR2VXcJjFBeUmnP6cGtuk3FXf0Zn/tP2BJoplQw43btGdTBsis+qgByg5tggrP9ZFRnkmEv+Y51oVGAiWh9gCxqddA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ovC+HwCPiNOYBxBwLz2Xc0PdfEsPYQ0NpYPibCVlEVs=; b=WcGAYaDetYSGbtwPlhSc9JKkVSddX5a6j35iewfcS/wOPSQtz/xGSTm3VxLslISFqtZwB6shXMRw0baBMiUVkLrzdq7FtPD2FjOWdFCXoIXtjwSkElmcg5/pNHQdYsc3xWoyikVasQ62XlWij6tYxPJlLN1bkyiiG7qit04NHTv7X9IU5OVcuVRMqGQo9YWmRqDkZJIdVQ3re4e3b/fzV1fnF7Z6chCh4/pFYBg/tJVClJV2dc7Zk5H7xWxumFM+dqC8iHfE+F3DEZaTpGslB8A0nYfcDw46NbWDtIknsHXNnGN1pgaNdVeOfvhzCRXxOYXVLkOkspj3jl4fK5hlzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ovC+HwCPiNOYBxBwLz2Xc0PdfEsPYQ0NpYPibCVlEVs=; b=PSA13hxMHpvjDkjQDEiFQSuR1HSK8yraTOQbyTK6eu7DXcX13GuCUkWHdbVf/MmxhNcTT+mfbbRQ9bcXSCQP/jRDWxdz4vCV/gBmcmXvtK7/FBENafcacdqXhv1e8eHvwhwwqUAkkUIhjJLwfy4hMgXCUplRsSAZcohEGvrx4XA= Received: from SJ0PR03CA0199.namprd03.prod.outlook.com (2603:10b6:a03:2ef::24) by BY5PR12MB4308.namprd12.prod.outlook.com (2603:10b6:a03:20a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.592.11; Sat, 7 Nov 2026 15:48:26 +0000 Received: from BY1PEPF00026968.namprd05.prod.outlook.com (2603:10b6:a03:2ef:cafe::7d) by SJ0PR03CA0199.outlook.office365.com (2603:10b6:a03:2ef::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.569.12 via Frontend Transport; Sat, 7 Nov 2026 15:48:26 +0000 X-MS-Exchange-Authentication-Results: mx.microsoft.com 1; spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by BY1PEPF00026968.mail.protection.outlook.com (10.167.244.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.615.4 via Frontend Transport; Sat, 7 Nov 2026 15:48:26 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.53; Sat, 7 Nov 2026 09:48:25 -0600 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.53; Sat, 7 Nov 2026 09:48:25 -0600 Received: from amd-System-Product-Name.amd.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.53 via Frontend Transport; Sat, 7 Nov 2026 09:48:21 -0600 From: Vijendar Mukunda To: CC: , , , , , , , , , , , , , "Vijendar Mukunda" Subject: [PATCH v5 05/25] soundwire: amd: fix missing wake interrupt and group wake-arming calls in runtime suspend Date: Sat, 7 Nov 2026 21:15:14 +0530 Message-ID: <20261107154659.3358223-6-Vijendar.Mukunda@amd.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261107154659.3358223-1-Vijendar.Mukunda@amd.com> References: <20261107154659.3358223-1-Vijendar.Mukunda@amd.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY1PEPF00026968:EE_|BY5PR12MB4308:EE_ X-MS-Office365-Filtering-Correlation-Id: ffaf6c68-ab19-476d-bbd9-08df3ce68ff9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|23010399003|82310400026|36860700016|11063799006|5023799004|56012099006|261009223027099003|261021121427099003|261021123027099003|261022105027099003|261022075727099003|261026140227099003|261102123227099003|261026121527099003|261028144727099003|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: VKyQIil3cRTznRKx2HiycQx+DWpVf8GfIVDPzMQJAAQSXXJVW1/K2odDLj2dXXOWb9dvMCam8HjxWYUCvsIUJyFhB3ZIOe8FJCr6eIlAju05Sp+4OEMCpv2OQFf72F+wshMeFU3MqtXDLIwnPK8V4U+qwCOWBHP+waBn8d/eXADJAp6ftbt2psPYLXv/9Bo4i1iRUvNIRpLs7jWgXFzQ3trsJCSz2C5Fq/6AiM8x9JESuRmxscZ0axlXGzbESmhk4TQ+Lza9cgRcA8qcVpSF+VgUykRWs/fcHS1OGGKlkDCyIOHewXnGSqY+EnTKQMwY1P4TSW0CbpkuKo6QlfJH3EXBXALpDdXGhYXf91AryCq+lZymBb9WqumbYoEEoWOOihu0I2kMRNBCjgw0bIH6X5YTUdue+WvIjiPUKrVANysy/Im2nTiPpF7bHb6Yocu/h5zcsJelpvEY1d+UZnmhH+QYZV/OHH9TNJwPekAtGEo0QyD7UyT+SgKDnrJrWwwWQJqK8ffVguGzMcFp5YcXK1h1nsCuCIAPl0jKJTZlfOgz36QFllYmtBibnJilaXn9ZX0qEVxpHyDR78BEXDv5AdpTFN3ruTP06/w32wRgL/n5bqzKJstuEEUPnD/L0Pqp/WE1Z8qP2VJrKJhS0rPMEj9r9cFgItBwRZkNTdkL/Tylz5dmDxHIoLqP/SZVZa7zhg/cgYmWhaFWwcVURW10Tg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(1800799024)(23010399003)(82310400026)(36860700016)(11063799006)(5023799004)(56012099006)(261009223027099003)(261021121427099003)(261021123027099003)(261022105027099003)(261022075727099003)(261026140227099003)(261102123227099003)(261026121527099003)(261028144727099003)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: fLyPZh/aj7A16LhAgOqEdPoeFZtPMz9uU/YVGfbt42/8X6Dwhp9/SVWX+Hy+Yq0GPo44XzKkNFURzBXA4NqlwH6oxrhMzTvfzsLvO33uwcPg12lkzKb0J7e+V1UR687XEIF2fSrX2Tv5qL3bcXFioTrBs14wW3RfmFaPyvPqA2d6XhJRwGWZClYH5mLoxot2siaUONa1jh3EZitD7vWjIGlHJstt28S6xofWfXe+0w+MTzT7Xg5d7GRMu3SFkzqk3+MI7qRyRC5Gk8ZouzYiIEwFcnDPGL24BhyCKXkh7KJkgDSPi9Tryf8+Jo6Y0+LETeYER/fcXTgf/dNTyAtfa6FhTRjU16okwBCbgnG8/JIK2zdb7+3qTSPUCTwbBdUR0UxH2E4nbXaWaHxrm9uS+cyUKezZkJ5rc4HijhQ68Y2j2TUFmNOOIY6XAl+OvJrW X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2026 15:48:26.4272 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ffaf6c68-ab19-476d-bbd9-08df3ce68ff9 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BY1PEPF00026968.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4308 In amd_suspend_runtime() POWER_OFF_MODE, amd_sdw_wake_enable() was called before amd_deinit_sdw_manager(), causing the wake IRQ mask to be silently overwritten. amd_deinit_sdw_manager() calls amd_disable_sdw_interrupts() which writes 0x00 to ACP_SW_STATE_CHANGE_STATUS_MASK_8TO11, wiping AMD_SDW_WAKE_INTR_MASK (BIT(16)) set by amd_sdw_wake_enable(). Move amd_sdw_wake_enable() to after amd_deinit_sdw_manager() so the wake mask is armed after the interrupt-disable sequence and cannot be clobbered. Move amd_sdw_host_wake_enable() after amd_deinit_sdw_manager() as well, grouping both wake-arming calls together after the interrupt-disable sequence. Fixes: 86a4371b7697 ("soundwire: amd: fix for handling slave alerts after link is down") Signed-off-by: Vijendar Mukunda --- drivers/soundwire/amd_manager.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c index 28f5dbe131dc..3d60bea82792 100644 --- a/drivers/soundwire/amd_manager.c +++ b/drivers/soundwire/amd_manager.c @@ -1454,18 +1454,18 @@ static int __maybe_unused amd_suspend_runtime(struct device *dev) if (ret) return ret; } else if (amd_manager->power_mode_mask & AMD_SDW_POWER_OFF_MODE) { - amd_sdw_wake_enable(amd_manager, true); - if (amd_manager->acp_rev >= ACP70_PCI_REV_ID) { - ret = amd_sdw_host_wake_enable(amd_manager, true); - if (ret) - return ret; - } ret = amd_sdw_clock_stop(amd_manager); if (ret) return ret; ret = amd_deinit_sdw_manager(amd_manager); if (ret) return ret; + amd_sdw_wake_enable(amd_manager, true); + if (amd_manager->acp_rev >= ACP70_PCI_REV_ID) { + ret = amd_sdw_host_wake_enable(amd_manager, true); + if (ret) + return ret; + } /* * For ACP 7.0/7.1/7.2: disable OE only; keeper and schmen remain * enabled unconditionally so that wake-capable devices can detect -- 2.53.0