From: Thorsten Blum <blum@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Thorsten Blum <blum@kernel.org>,
Dmitry Torokhov <dtor@insightbb.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Input: amijoy - fix memory region leak on registration failure
Date: Sat, 7 Nov 2026 17:01:57 +0100 [thread overview]
Message-ID: <20261107160159.367919-2-blum@kernel.org> (raw)
If input_register_device() fails in amijoy_init(), release the memory
region for port i before cleaning up the previously registered ports.
Fixes: 127278ce2254 ("Input: joysticks - handle errors when registering input devices")
Cc: stable@vger.kernel.org
Signed-off-by: Thorsten Blum <blum@kernel.org>
---
drivers/input/joystick/amijoy.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/joystick/amijoy.c b/drivers/input/joystick/amijoy.c
index cdb2b8f15348..3c2357ba7dc3 100644
--- a/drivers/input/joystick/amijoy.c
+++ b/drivers/input/joystick/amijoy.c
@@ -132,6 +132,7 @@ static int __init amijoy_init(void)
err = input_register_device(amijoy_dev[i]);
if (err) {
input_free_device(amijoy_dev[i]);
+ release_mem_region(CUSTOM_PHYSADDR + 10 + i * 2, 2);
goto fail;
}
}
reply other threads:[~2026-11-07 16:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261107160159.367919-2-blum@kernel.org \
--to=blum@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dtor@insightbb.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®