From: Akshat Rawat <akshatrawat095@gmail.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Akshat Rawat <akshatrawat095@gmail.com>
Subject: [PATCH] rtc: as3722: check return value of platform_get_irq()
Date: Sat, 7 Nov 2026 16:08:39 +0000 [thread overview]
Message-ID: <20261107160839.422-1-akshatrawat095@gmail.com> (raw)
In as3722_rtc_probe(), the return value of platform_get_irq() is
assigned to as3722_rtc->alarm_irq without error checking.
If platform_get_irq() fails (such as returning -EPROBE_DEFER when the
parent interrupt controller is not yet ready), the driver logs an
invalid IRQ number in dev_info() and calls devm_request_threaded_irq()
with a negative value. This causes devm_request_threaded_irq() to fail
with -EINVAL and abort probe permanently, breaking deferred probing.
Check the return value of platform_get_irq() and return immediately on
failure to properly propagate errors.
Fixes: b45062619840 ("drivers/rtc/rtc-as3722: add RTC driver")
Cc: stable@vger.kernel.org
Signed-off-by: Akshat Rawat <akshatrawat095@gmail.com>
---
drivers/rtc/rtc-as3722.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/rtc/rtc-as3722.c b/drivers/rtc/rtc-as3722.c
index 9682d6457b7f..dfa3628ad95b 100644
--- a/drivers/rtc/rtc-as3722.c
+++ b/drivers/rtc/rtc-as3722.c
@@ -198,6 +198,9 @@ static int as3722_rtc_probe(struct platform_device *pdev)
}
as3722_rtc->alarm_irq = platform_get_irq(pdev, 0);
+ if (as3722_rtc->alarm_irq < 0)
+ return as3722_rtc->alarm_irq;
+
dev_info(&pdev->dev, "RTC interrupt %d\n", as3722_rtc->alarm_irq);
ret = devm_request_threaded_irq(&pdev->dev, as3722_rtc->alarm_irq, NULL,
--
2.56.0.windows.4
reply other threads:[~2026-11-07 16:07 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261107160839.422-1-akshatrawat095@gmail.com \
--to=akshatrawat095@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®