From: Jonathan Cameron <jic23@kernel.org>
To: Abdelnasser Hussein <abdelnasserhussein11@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Joshua Crofts" <crofts@kernel.org>,
linux@analog.com, linux-iio@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] staging: iio: addac: adt7316: sort headers alphabetically
Date: Sat, 7 Nov 2026 20:29:04 +0000 [thread overview]
Message-ID: <20261107202904.2b3db8a0@jic23-hlaptop> (raw)
In-Reply-To: <20261104183429.20125-2-abdelnasserhussein11@gmail.com>
On Wed, 4 Nov 2026 20:34:28 +0200
Abdelnasser Hussein <abdelnasserhussein11@gmail.com> wrote:
> Sort included headers alphabetically without altering the list of
> inclusions. Keep the <linux/iio/*> subsystem headers separated from
> the <linux/*> group, and add a blank line before the local "adt7316.h"
> header.
>
> Reviewed-by: Joshua Crofts <crofts@kernel.org>
> Signed-off-by: Abdelnasser Hussein <abdelnasserhussein11@gmail.com>
Needed a small tweak as kstrtox.h was added recently.
> ---
> drivers/staging/iio/addac/adt7316.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index 20f6052cc7fb..515f1fdae46b 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -5,22 +5,23 @@
> * Copyright 2010 Analog Devices Inc.
> */
>
> -#include <linux/interrupt.h>
> +#include <linux/device.h>
> #include <linux/gpio/consumer.h>
> +#include <linux/i2c.h>
> +#include <linux/interrupt.h>
> #include <linux/irq.h>
> -#include <linux/workqueue.h>
> -#include <linux/device.h>
> #include <linux/kernel.h>
> -#include <linux/slab.h>
> -#include <linux/sysfs.h>
> #include <linux/list.h>
> -#include <linux/i2c.h>
> -#include <linux/rtc.h>
> #include <linux/module.h>
> +#include <linux/rtc.h>
> +#include <linux/slab.h>
> +#include <linux/sysfs.h>
> +#include <linux/workqueue.h>
>
> -#include <linux/iio/iio.h>
> #include <linux/iio/events.h>
> +#include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> +
> #include "adt7316.h"
>
> /*
next prev parent reply other threads:[~2026-11-07 20:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 18:34 [PATCH v4 0/2] staging: iio: addac: adt7316: clean up header inclusions Abdelnasser Hussein
2026-11-04 18:34 ` [PATCH v4 1/2] staging: iio: addac: adt7316: sort headers alphabetically Abdelnasser Hussein
2026-11-07 20:29 ` Jonathan Cameron [this message]
2026-11-04 18:34 ` [PATCH v4 2/2] staging: iio: addac: adt7316: replace kernel.h with explicit headers Abdelnasser Hussein
2026-11-07 20:31 ` [PATCH v4 0/2] staging: iio: addac: adt7316: clean up header inclusions Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261107202904.2b3db8a0@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=abdelnasserhussein11@gmail.com \
--cc=andy@kernel.org \
--cc=crofts@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux@analog.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®