From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Arnav Kapoor" <kapoorarnav43@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Gwendal Grignou" <gwendal@chromium.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: proximity: sx9360: use an int array for the sampling frequency range
Date: Sat, 7 Nov 2026 20:40:31 +0000 [thread overview]
Message-ID: <20261107204031.4ea3e36b@jic23-hlaptop> (raw)
In-Reply-To: <auuqD75_H4OVHqva@ashevche-desk.local>
On Wed, 4 Nov 2026 23:56:31 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Wed, Nov 04, 2026 at 11:26:04PM +0530, Arnav Kapoor wrote:
> > sx9360_samp_freq_interval[] is an array of struct { int val; int val2; }
> > that read_avail() hands to the IIO core by casting it to int *. That
> > relies on the struct having no padding. Declare it as an array of
> > int[2], like other IIO drivers do for their available ranges, so the
> > layout is plain and the cast no longer drops const.
> >
> > No functional change.
>
> LGTM,
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
Looks fine but will have to wait for the fix that touched this
code to make it to upstream for non fixes.
prev parent reply other threads:[~2026-11-07 20:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 17:56 Arnav Kapoor
2026-11-04 21:56 ` Andy Shevchenko
2026-11-07 20:40 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261107204031.4ea3e36b@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gwendal@chromium.org \
--cc=kapoorarnav43@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®