From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794087937; b=0c1KdyS1IuEPex/7pmjDTEox5VUI6D3MMEF6mdqQkA0j0ArYJvRjp6yORrXeT1myu/N/ yK7/lS38TKoQ4FdHtzSAZUCDDnEDDJklBRdoscl/GK4l4fbIqIDUD8GY3WF03+CYQg5eC lqE7CQ1UCXJkYGeZw7cLNo3hfPqLGdIBd6J1ZzrCj6N5gb94deTRuAffoRXcqTu1B1DEk tDLZFwuOaoyNAuSy56fati5g8JC0hZejjxRfy3GisyC5M1iH1DURQPSxPRJ/pGv0EEPoS KEf8wEsbcD2jMDqRq0DCby8AdUe5R6hpXGqmr5dvmMGhXiggT27UWp9Evs/58Nig/rA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794087937; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=lmfkuEncO7HrgAvrvHVaRTSKNdQ3l+JsObN4du/E/II=; b=iVAtDICdLRm6NqCUVJL2j4D7po3jK+Cw1mcOT+rPgIBvQRcprnTW1gJE0dQKtW5vrFIT bFjWnhDD/zTiB4voxd57J/IF462Uft/Nnic9CWC9c8C1NrMSHsXqr9AmAByZ/MVc1pUkJ WOby2YZf7pHsIxpZOnAcJE/w5jj2luzYYQiGbBGF8A4KQ6265a5wKwsaEb7Tl6vDgnPcs LiNIkWhrFaGyvQLB+WEoWI/dq3zRNX6ahP3BIISAM5KGnoWWCR1Lzp8QpgrXLX4awkFC+ jpMdW4iDegTxRPgb9Pp67iEyEcNTKakgHcdsPoOk8y1J6nLuXayh1IWkDD21z0dtCKw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=PgDBO7R9; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEECC606D811; Sat, 7 Nov 2026 21:45:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=PgDBO7R9 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5218F1F0089F; Sat, 7 Nov 2026 21:45:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794087936; bh=lmfkuEncO7HrgAvrvHVaRTSKNdQ3l+JsObN4du/E/II=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=PgDBO7R9zy4bT6hGZ8egNmJMKX2P1CUnL3wYteY5+qxFF00Ks68Ez2rAW2khacP3H lNdfFE3FrV7jyM6hhXmy1qSPpagMXcMRRqxGTcJJQSZwcS6sAboYJ5XM9pP0K3FsVZ CVseyA4FmNo2iL9mTd8CBlHC7uqK9O/T4acfySY8rFGLfJZ/qt8kTI89QCAU7ZaE8M b9PIedAzsH4hyfPTMFG1iGFLAQ3ma43Sw2jtD0p9E4VNzF6bjiurw09NPs6M53GXvi 3GMX3h+4IXnqDr4Lmt5klFIL3M7dKRqNty1BMgzV9Eb4HwjbJmbA9yAu2CKVX28k19 RSSuvC3I5ZEVA== From: SJ Park To: Cc: SJ Park , stable@vger.kernel.org, Andrew Morton , damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 6.12.y 5/5] mm/damon/core: remove unreachable damos charge_{target,addr}_from Date: Sat, 7 Nov 2026 13:45:24 -0800 Message-ID: <20261107214525.304638-6-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261107214525.304638-1-sj@kernel.org> References: <20261107214525.304638-1-sj@kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit damos_quota->charge_{target,addr}_from saves the target and region the scheme's quota limit is reached. damos_skip_charged_region() skips the target and regions before the point. The target that was assigned to charge_target_from could be dynamically removed from the context by the runtime parameters update (aka commit) feature. In this case, damos_skip_charged_region() cannot find if the point is passed or not, so the scheme is effectively disabled. Similarly, the user could also remove all the regions of the target using the runtime parameters update feature. It would be uncommon to do that, but it is a supported feature. Because the skip pointer detection logic (damos_skip_charged_region()) works for each region of targets, this result in the logic is entirely skipped and the scheme is effectively disabled again. The user impact is that the DAMOS scheme could suddenly stop working under certain uses of the runtime parameters update feature. It could surprise users. No crash or leak happens though. Users could also simply work around by re-installing the scheme. Catch the corner cases in damos_adjust_quota() and reset the pointers. Link: https://lore.kernel.org/20261020023958.108276-1-sj@kernel.org Fixes: da87878010e5 ("mm/damon/sysfs: support online inputs update") Signed-off-by: SJ Park Signed-off-by: Andrew Morton Closes: https://sashiko.dev/#/bug/linux-cd0c55fc-0cc8-45d8-9637-3334811c49b8 Cc: # 5.19.x (cherry picked from commit 5695abc4e742b947f586bfb6a080a80ad9957e5d) Signed-off-by: SJ Park --- mm/damon/core.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/mm/damon/core.c b/mm/damon/core.c index 046c07b86a6e7..badd0628e5eb2 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -1686,6 +1686,26 @@ static void damos_set_effective_quota(struct damos_quota *quota) quota->esz = esz; } +static void damos_fix_stale_charge_pointers(struct damon_ctx *c, + struct damos *s) +{ + struct damos_quota *quota; + struct damon_target *t; + + quota = &s->quota; + if (!quota->charge_target_from) + return; + damon_for_each_target(t, c) { + if (t == quota->charge_target_from) { + if (damon_nr_regions(t) > 0) + return; + break; + } + } + quota->charge_target_from = NULL; + quota->charge_addr_from = 0; +} + static void damos_adjust_quota(struct damon_ctx *c, struct damos *s) { struct damos_quota *quota = &s->quota; @@ -1714,6 +1734,8 @@ static void damos_adjust_quota(struct damon_ctx *c, struct damos *s) damos_set_effective_quota(quota); } + damos_fix_stale_charge_pointers(c, s); + if (!c->ops.get_scheme_score) return; -- 2.47.3