From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794090132; b=T0CHQaI75gFFKQT1utSQDJmP28N3gvD0xM3LNnMckRsw5tEsRBtCL0oUy/wXfOxavz0b H9TuNM61VCs/HObR0PxLrbf2Koh9EU1EWZ3Y0z3OCybxmUz5XuiRNs++zaBARDjdbN1qf NvqzcQLNtdXB811uZbbAiM4+IYn41WktXMhdnu9D9GB4p24IfAXaOgMbkA46HgjZmLzR6 ZfvPBrZmjlP3NCiru+OMNvsPLKexk8F9U/HID8RE2N24V8WNj4jkYlN2Ndj6AW+VFHGJt bjOuuyGjADGrqC+OY/44QfhYOXFaxD4szLQiQQYSsc54WP11OMJFOhraStM7uZgl8YA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794090132; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding; bh=dECklwOd4xlNmvN3OSaJ4I8wcJsGZw3Lw9lBlak0+Zw=; b=XJHdZ2QigBoSD+H0WVp9LUl+E36RwMD5aNjp/crvOiptt2Y+qAeW71LnjFCGYbHcvdUK MbV8+POCkA9ybbAVXiOm0M15S+UwZDpTswlVxo2kk4yznU8goBZiZYbHlynpg4k1VW7CB JGDXl/RrrTprQApFdk1TebeJPZAx+4aj+MdCKRZqRbMHA6KbDGmm6y71KXbghHR9dlEyB eP8mBl9vh1CIqJbnopfSA/UmVE+6lMBOskooRiB5LLW512nZZVAdOn12fzDcE2YIGHZvk RLaDv/gafq7C1pbsaODq8sY/kvl6I89AEx99j4w4RAA8XwO/rm2Up44XLq94V8EjG7w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=dLayhXvj; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE459606A336; Sat, 7 Nov 2026 22:22:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=dLayhXvj Received: by smtp.kernel.org (Postfix) with ESMTPSA id 988D01F0089F; Sat, 7 Nov 2026 22:22:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794090131; bh=dECklwOd4xlNmvN3OSaJ4I8wcJsGZw3Lw9lBlak0+Zw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=dLayhXvjlMyPbPhj+Cwg4k8CwNhxhZBR+fX479TcrnQ8IrINvaP0MxsFRMp3Ej6c3 /m3nOpiDvY26qgBkfMF8ZvqZzm0Sywrd2TocaoiBZ+ptWHrWDF/jpLQD6IqXrcSnQS jV280FrsdLZlqxUT+H7sveM/obf3IZ0878/1zpBVclT7+RXf6ApF7+ae+sKjG5kIDx xBUxG2voo65F7oy4l5NP56nndP2Mf9Pxe9igP4TcyojKsz5XPtkvxVXYXDsL6mLbHc OxgU775qY9BiOg3DqTWU3n5EAktfKM4DmkeHNOnHooLqvixYbZiPD6EaBvqIwkiWdq XvulXIidcnBgQ== From: SJ Park To: Cc: SJ Park , stable@vger.kernel.org, Andrew Morton , damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 6.6.y 3/3] mm/damon/core: remove unreachable damos charge_{target,addr}_from Date: Sat, 7 Nov 2026 14:22:01 -0800 Message-ID: <20261107222202.331476-4-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261107222202.331476-1-sj@kernel.org> References: <20261107222202.331476-1-sj@kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit damos_quota->charge_{target,addr}_from saves the target and region the scheme's quota limit is reached. damos_skip_charged_region() skips the target and regions before the point. The target that was assigned to charge_target_from could be dynamically removed from the context by the runtime parameters update (aka commit) feature. In this case, damos_skip_charged_region() cannot find if the point is passed or not, so the scheme is effectively disabled. Similarly, the user could also remove all the regions of the target using the runtime parameters update feature. It would be uncommon to do that, but it is a supported feature. Because the skip pointer detection logic (damos_skip_charged_region()) works for each region of targets, this result in the logic is entirely skipped and the scheme is effectively disabled again. The user impact is that the DAMOS scheme could suddenly stop working under certain uses of the runtime parameters update feature. It could surprise users. No crash or leak happens though. Users could also simply work around by re-installing the scheme. Catch the corner cases in damos_adjust_quota() and reset the pointers. Link: https://lore.kernel.org/20261020023958.108276-1-sj@kernel.org Fixes: da87878010e5 ("mm/damon/sysfs: support online inputs update") Signed-off-by: SJ Park Signed-off-by: Andrew Morton Closes: https://sashiko.dev/#/bug/linux-cd0c55fc-0cc8-45d8-9637-3334811c49b8 Cc: # 5.19.x (cherry picked from commit 5695abc4e742b947f586bfb6a080a80ad9957e5d) Signed-off-by: SJ Park --- mm/damon/core.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/mm/damon/core.c b/mm/damon/core.c index 99e934a6d1ce9..61d45d40fc1d3 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -1088,6 +1088,27 @@ static void damos_set_effective_quota(struct damos_quota *quota) quota->esz = esz; } + +static void damos_fix_stale_charge_pointers(struct damon_ctx *c, + struct damos *s) +{ + struct damos_quota *quota; + struct damon_target *t; + + quota = &s->quota; + if (!quota->charge_target_from) + return; + damon_for_each_target(t, c) { + if (t == quota->charge_target_from) { + if (damon_nr_regions(t) > 0) + return; + break; + } + } + quota->charge_target_from = NULL; + quota->charge_addr_from = 0; +} + static void damos_adjust_quota(struct damon_ctx *c, struct damos *s) { struct damos_quota *quota = &s->quota; @@ -1115,6 +1136,8 @@ static void damos_adjust_quota(struct damon_ctx *c, struct damos *s) damos_set_effective_quota(quota); } + damos_fix_stale_charge_pointers(c, s); + if (!c->ops.get_scheme_score) return; -- 2.47.3