mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Xiangwu Lai <laixiangwu@cmss.chinamobile.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	andy@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com
Subject: Re: [PATCH v4 0/2] iio: gyro: mpu3050: Fix runtime PM refcount leak in trigger enable path
Date: Sat, 7 Nov 2026 22:51:35 +0000	[thread overview]
Message-ID: <20261107225135.04a6b1b9@jic23-hlaptop> (raw)
In-Reply-To: <20261104040008.1458-1-laixiangwu@cmss.chinamobile.com>

On Wed,  4 Nov 2026 12:00:05 +0800
Xiangwu Lai <laixiangwu@cmss.chinamobile.com> wrote:

> Hi Jonathan,
> 
> Thanks for the review! This version addresses both comments on the
> trigger helpers: the dispatcher now uses an else, and the error
> return for the IRQ status read in the enable path is propagated.
> The disable path is left as is, as you concluded it was not worth
> the effort to fix.

I agree with your logic in replying to Andy (and think he probably
will as well) so I've applied this. Taking it the slow path so
applied to the testing branch of iio.git which will end up going upstream
next merge window.

Thanks,

Jonathan

      parent reply	other threads:[~2026-11-07 22:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04  4:00 Xiangwu Lai
2026-11-04  4:00 ` [PATCH v4 1/2] iio: gyro: mpu3050: Split data ready trigger enable/disable into helpers Xiangwu Lai
2026-11-05 15:31   ` Joshua Crofts
2026-11-06  2:06     ` Xiangwu Lai
2026-11-04  4:00 ` [PATCH v4 2/2] iio: gyro: mpu3050: Fix runtime PM refcount leak in trigger enable path Xiangwu Lai
2026-11-04 11:58   ` Andy Shevchenko
2026-11-05  8:18     ` Xiangwu Lai
2026-11-07 22:51 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261107225135.04a6b1b9@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=laixiangwu@cmss.chinamobile.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®