Re: [PATCH v3 0/2] iio: test: iio-test-format: char format test and overrun checks

[Jonathan Cameron <jic23@kernel.org>]

On Tue, 03 Nov 2026 21:17:06 +0000
Raffaele Tranfaglia via B4 Relay <devnull+raffaele.tranfaglia.gmail.com@kernel.org> wrote:

> Add a KUnit test for IIO_VAL_CHAR formatting and, as suggested by
> Andy, make IIO_TEST_FORMAT_EXPECT_EQ() check that iio_format_value()
> does not write past the formatted string.
> 
> A NUL character is currently emitted as is, so the attribute reads
> back as "\0\n". The test documents this behaviour; please let me
> know if it should rather be rejected or handled differently.
> 
> These patches were written with the help of an LLM-based coding
> assistant, which I used to draft the code and commit messages. I
> reviewed and tested all changes myself.
> 
> Tested with KUnit on arm64 QEMU.
> 
> Signed-off-by: Raffaele Tranfaglia <raffaele.tranfaglia@gmail.com>
LGTM.  I'll apply this to the testing branch of iio.git.
Still time for more review and potentially tags though as I'll
probably not push that out as togreg (which linux-next picks up
and which is supposed to be more or less non rebasing) until mid
week.

Thanks,

Jonathan

> ---
> Changes in v3:
> - Reformat IIO_TEST_FORMAT_EXPECT_EQ() and use a local variable for
>   the size (Andy)
> - Link to v2: https://patch.msgid.link/20261102-iio-test-format-char-v2-0-926100689e62@gmail.com
> 
> Changes in v2:
> - Drop the Assisted-by tag and describe the tool use here (Andy)
> - New patch 1: poison the buffer and check that nothing is written
>   past the string (Andy)
> - Add special, non-printable, NUL and out-of-range cases (Andy)
> - Link to v1: https://patch.msgid.link/20261025-iio-test-format-char-v1-1-e2c208f90e87@gmail.com
> 
> ---
> Raffaele Tranfaglia (2):
>       iio: test: iio-test-format: check that nothing is written past the string
>       iio: test: iio-test-format: add test case for char format
> 
>  drivers/iio/test/iio-test-format.c | 121 +++++++++++++++++++++++++++++++------
>  1 file changed, 103 insertions(+), 18 deletions(-)
> ---
> base-commit: d1425b382b9cc5bd19223fad8ba4a8af3dbe1305
> change-id: 20261025-iio-test-format-char-8a17fbf9a201
> 
> Best regards,
> --  
> Raffaele Tranfaglia <raffaele.tranfaglia@gmail.com>
> 
>