From: Jonathan Cameron <jic23@kernel.org>
To: Roman Vivchar <rva333@protonmail.com>
Cc: "Roman Vivchar via B4 Relay"
<devnull+rva333.protonmail.com@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: iio: light: stk33xx: add power supply support
Date: Sat, 7 Nov 2026 23:53:42 +0000 [thread overview]
Message-ID: <20261107235342.40f2e45a@jic23-hlaptop> (raw)
In-Reply-To: <geNqZOyrIjYLfmuUys8cQJU8FM53jylicArPsTGNXPnqSvHPCIc1Jad7dBOBy1GdE38RBEMSYQYDqEmaAqq2PDcglQcRBdkR0yZAjRExEUQ=@protonmail.com>
On Sat, 07 Nov 2026 22:45:45 +0000
Roman Vivchar <rva333@protonmail.com> wrote:
> Hi Jonathan,
>
> On Sunday, November 8th, 2026 at 12:36 AM, Jonathan Cameron <jic23@kernel.org> wrote:
>
> > On Sun, 08 Nov 2026 00:15:03 +0200
> > Roman Vivchar via B4 Relay <devnull+rva333.protonmail.com@kernel.org> wrote:
> >
> > > From: Roman Vivchar <rva333@protonmail.com>
> > >
> > > On some boards, the chip shares a power rail with other components. If
> > > that rail is turned off, the chip can't function.
> > Not sure how the sharing is relevant. Even if shared with nothing
> > else we need to turn it on. So just mention that on some boards it
> > isn't always on.
> >
> > The only reason this would be optional in the binding is if there
> > was internal routing in some packaging or similar that meant there
> > was no pin to connect.
> >
> > Upshot, make this required in the binding. Note that doesn't mean
> > the driver must require it - we are simply documenting that the
> > device needs power.
> >
>
> I agree this should be required, but that would break dt_binding_check
> for existing boards. I don't have their schematic nor boards themselves
> to verify the regulator for the power supply.
There aren't any upstream (from a quick grep) and so not your problem
unless you have some in a downstream tree that need fixing.
If you do then there is the option of a fixed regulator to close
the gap. I consider a missing supply a bug that we should fix but maybe
others disagree.
Jonathan
>
> Best regards,
> Roman
next prev parent reply other threads:[~2026-11-07 23:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 22:15 [PATCH 0/4] iio: light: stk3310: stk3337 support + vdd supply Roman Vivchar via B4 Relay
2026-11-07 22:15 ` [PATCH 1/4] dt-bindings: iio: light: stk33xx: add power supply support Roman Vivchar via B4 Relay
2026-11-07 22:36 ` Jonathan Cameron
2026-11-07 22:45 ` Roman Vivchar
2026-11-07 23:53 ` Jonathan Cameron [this message]
2026-11-08 0:06 ` Roman Vivchar
2026-11-07 22:15 ` [PATCH 2/4] dt-bindings: iio: light: stk33xx: add stk3337 Roman Vivchar via B4 Relay
2026-11-07 22:15 ` [PATCH 3/4] iio: light: stk3310: add vdd regulator support Roman Vivchar via B4 Relay
2026-11-07 22:15 ` [PATCH 4/4] iio: light: stk3310: add stk3337 support Roman Vivchar via B4 Relay
2026-11-07 22:39 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261107235342.40f2e45a@jic23-hlaptop \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=devnull+rva333.protonmail.com@kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=rva333@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®