Re: [PATCH v2] USB: visor add vendor/device IDs for PalmSource devices from the PalmUSBD.inf file in Palm Desktop 6.2

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Fri, Nov 06, 2026 at 06:33:02PM -0500, Adam Simonelli wrote:
> PalmUSBD.inf from Palm Desktop 6.2's driver defines two PalmSource
> devices. While PalmSource only developed the PalmOS, and never made
> actualy hardware, as it was Palm Inc. made the Palm hardware, there
> is a bootable ROM containing PalmOS 6.1 that can be booted into RAM
> on the Tungsten T3. When this ROM is running, when plugged in, the
> device will then present the PalmSource vendorid that is defined in
> the INI filem and the deviceid then becomes PALMSOURCE_DEVICES_1_ID
> the PALMSOURCE_DEVICES_2_ID is also defined for completeness.
> 
> Signed-off-by: Adam Simonelli <adamsimonelli@gmail.com>
> ---
>  drivers/usb/serial/visor.c | 6 ++++++
>  drivers/usb/serial/visor.h | 4 ++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/drivers/usb/serial/visor.c b/drivers/usb/serial/visor.c
> index 5706c46c49c2..18c586d552d7 100644
> --- a/drivers/usb/serial/visor.c
> +++ b/drivers/usb/serial/visor.c
> @@ -75,6 +75,10 @@ static const struct usb_device_id id_table[] = {
>  		.driver_info = (kernel_ulong_t)&palm_os_4_probe },
>  	{ USB_DEVICE(PALM_VENDOR_ID, PALM_ZIRE_ID),
>  		.driver_info = (kernel_ulong_t)&palm_os_4_probe },
> +	{ USB_DEVICE(PALMSOURCE_VENDOR_ID, PALMSOURCE_DEVICE_1_ID),
> +		.driver_info = (kernel_ulong_t)&palm_os_4_probe },
> +	{ USB_DEVICE(PALMSOURCE_VENDOR_ID, PALMSOURCE_DEVICE_2_ID),
> +		.driver_info = (kernel_ulong_t)&palm_os_4_probe },
>  	{ USB_DEVICE(SONY_VENDOR_ID, SONY_CLIE_4_0_ID),
>  		.driver_info = (kernel_ulong_t)&palm_os_4_probe },
>  	{ USB_DEVICE(SONY_VENDOR_ID, SONY_CLIE_S360_ID),
> @@ -133,6 +137,8 @@ static const struct usb_device_id id_table_combined[] = {
>  	{ USB_DEVICE(PALM_VENDOR_ID, PALM_TREO_650) },
>  	{ USB_DEVICE(PALM_VENDOR_ID, PALM_TUNGSTEN_Z_ID) },
>  	{ USB_DEVICE(PALM_VENDOR_ID, PALM_ZIRE_ID) },
> +	{ USB_DEVICE(PALMSOURCE_VENDOR_ID, PALMSOURCE_DEVICE_1_ID) },
> +	{ USB_DEVICE(PALMSOURCE_VENDOR_ID, PALMSOURCE_DEVICE_2_ID) },
>  	{ USB_DEVICE(SONY_VENDOR_ID, SONY_CLIE_3_5_ID) },
>  	{ USB_DEVICE(SONY_VENDOR_ID, SONY_CLIE_4_0_ID) },
>  	{ USB_DEVICE(SONY_VENDOR_ID, SONY_CLIE_S360_ID) },
> diff --git a/drivers/usb/serial/visor.h b/drivers/usb/serial/visor.h
> index 622d639ce74e..0f86bd06c4fe 100644
> --- a/drivers/usb/serial/visor.h
> +++ b/drivers/usb/serial/visor.h
> @@ -32,6 +32,10 @@
>  #define PALM_ZIRE_ID			0x0070
>  #define PALM_M100_ID			0x0080
>  
> +#define PALMSOURCE_VENDOR_ID		0x13e8
> +#define PALMSOURCE_DEVICE_1_ID		0x0600
> +#define PALMSOURCE_DEVICE_2_ID		0xff00
> +
>  #define GSPDA_VENDOR_ID		0x115e
>  #define GSPDA_XPLORE_M68_ID		0xf100
>  
> -- 
> 2.55.0
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot