From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.44 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794187395; b=if4FF9/ZXvkivIuTldRUH+0euGscfUKZR7PP0FRRS1IIvOqu156E/rBjvY7CcqOQwg4o VV4sIW+k0Cf7gdq1V1yQTGVE5oHP06xl5t5GrWHRf9AnvlnN3Bk32jV8hPSLiHvG8eOzC m7TNnglbxh+YZOTYhb3b4P6tgCm/ImJ5Glg1m332j6j8m+g69qNiWj+lN9XrEAhqV02QZ lSeKdfguvHMOndx88TJ1O0oPQXIjk6KYZPUgzsgUNS0q51ATmuyH+Z7qFnik+PGtwoXnr zvQaatEhsdiJq6aLQyj866i2oPBeicXVyrn8GJ++O97nNioHkttFvuz7Qlwbd8m4UKw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794187395; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:Date:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer; bh=Yd5+TdsEc/1kR6XeHOmWBxFOLTJkBLfiUyBjyyrqsyk=; b=ndlbSX+Z5u4jIZeQjy8oRObcqVJkgoxwXakxhi6PP/EjQOQL9gzJ0exojM5rpauvhvtS vIYoGB3aq/ns2q+i8tQNROB6bi68uP5MvYgu4l6JHIgEXH3PNuOQBF5fI/FN3wI7HTKZg 0aJovEPteO59QUo3pXtCOkWodCkc9vyeNDtqPNh8mDkb1WCGI7Ffzdw4WWl1hjiE1yfxx 7wIXi57B11ZyG97Gdo+3vGLQf01x3VNcR3WSc8sFt8KR+Qqejm3yybsYcp02xq5DaKMUa TcRGlKyWN5PLUX/tIEL6HjMAsd/XJaBAk/FYjqR+sw+flf1Nbjak2MZ3yBAUzyoKPvw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b="M/YJbBzw"; arc=none smtp.remote-ip=74.125.82.44 Received: from mail-dl1-f44.google.com (mail-dl1-f44.google.com [74.125.82.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAAEA606E983 for ; Mon, 9 Nov 2026 01:23:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org CAAEA606E983 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=M/YJbBzw Received: by mail-dl1-f44.google.com with SMTP id a92af1059eb24-1a3c08d6928so636471c88.0 for ; Sun, 08 Nov 2026 17:23:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794187394; x=1794792194; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Yd5+TdsEc/1kR6XeHOmWBxFOLTJkBLfiUyBjyyrqsyk=; b=M/YJbBzwhR7G824BApq9UpMteqyazdlfLXmqEzjBWffbJOpvrxEn74LfEgTvdoSsFJ gwZjE5z6qzdfmHWGv7QjpYwKK/0SzJq7V9/MBlbN0vkwnfblCVV6pFLW9vMx+hFF3uGC nXQul+AIMV47VTE+XY1Nol0/2GfX3A0JaERyg3e5tx6u43JD0dv73IZnNCu+9+x3nfwp lM746MazS/FYhc6TZGdozxcewIFQVxpsXopAdT8zzrNQjEEsQy92MZayAA2QKJr7VkdF sg4TrVPYUqyaLU2UsCS83+nzJDBo5xZ0lQUA/wjxGwvZiMMnOLfsGiO5CBkaPnJOipTh brtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794187394; x=1794792194; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Yd5+TdsEc/1kR6XeHOmWBxFOLTJkBLfiUyBjyyrqsyk=; b=kwjnMboMGMYSOzp9//hggzd7+XTNK+FxY6e+OrpOjh9DP4IP+h8uqf6p3jECSW4kR9 hyyXOAPBndUPxo64MTMmbzbh7twRJKX/XenwxD82pcZXyqEc2okc/Roaf12HHIDk1yTh kDsTYaaraEWvcUhwaGMqeG/Hjxm5kdPaZ745kONed4k55lZMtI6XVYy4cV3dVqrXJ3eL vBju9eEaoRVa4m5q83umd1Ehdjq7CPDrp14PxvbNvM/xEqxCbNUIBUdyr31kKmJOnAjy M8hd6xRZudKBuToxN8DYoBlGegprURAvtartk7KETXzyOWSMY/OvR4jiuGld54JFAQmL M4fA== X-Forwarded-Encrypted: i=1; AL+hErGdz1/bqzHGkgzixUicHBoMeX6No+KpmqcP124ApWgXUA8v7MIex1SWk2lc/Sp79DHmiWFV1bl5wtvaDUk=@vger.kernel.org X-Gm-Message-State: APuU4Z9l22TpJbuNS0VEqB046lk/Dun7WhTgdK8+shkOzH66A7NbVfRX w64C+P+WgTWnV+JY37e/y2NDCcCC/kto1WhwzCLwRTSj0mBbFy029UW9 X-Gm-Gg: AYBFou2UXy6zh5AFTnqg3/cy5DSG95YBgIQJyrH+o0suJy5dHSlGpGeBOYqjDVpdQ4q Mh7nhivi8Q5OXMFIID3zQjcgYR0xyCXG+MVHGICVd+1RW4bpgYGYm+Qmzc8Uz7KhNiZoc6rcJUs M5Ln5eG/v/BRVgEQxD1i+0bL8AjIL4eyqPau1AzMBnzVkIoeIs2M/C/BSN+k7pSOSLQ9DmO6EOD erkLF0ojxdtCVrCfyUmsfD1Wf4P6Q6bLVRsKz8OPUxnDCGcCvXoGmr9aqbKFf/JSX59RNL3O4pM 9FAMlQKAxrNJWk9q3l4WlsAgHBy7y811zh3OWzWABJkX1oFRnR6lkg9HDxzoq4omtQ9Wrlpoox4 3sYs2/Ox1am8HnZ+AIh4n00PFV3iWE+293MY3uuzPK6U9+dAuxNJAAZw4MztScXO4eDAHqhYMWD EbbT3xI4KJQYObykFrO7MyxeNAsEhVi3a1xezNqzPxqwNFycNDxD3XCK7Hh/D9kli0XjcUeuokN rIum5etP93++T9L8KzUDLF/s4i0Qa/clyBD6hQCfgf+0Qt1hYWkrwUYdF7GKdvLN8czeIpR8mxF K5c6Klb6c5z2P4fLkut/WlHn X-Received: by 2002:a05:701b:420f:10b0:1ab:6b10:461 with SMTP id a92af1059eb24-1b39ff1d2famr4082012c88.45.1794187393835; Sun, 08 Nov 2026 17:23:13 -0800 (PST) Received: from [127.0.1.1] ([23.254.208.9]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1b3771ea85bsm9428226c88.18.2026.11.08.17.23.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Nov 2026 17:23:13 -0800 (PST) From: Qiliang Yuan Date: Sun, 08 Nov 2026 20:22:52 -0500 Subject: [PATCH v4 3/5] selftests/mm: fail KSM helpers on short reads and writes X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261108-bug-mm-ksm-smart-scan-align-skips-v4-3-86be8fe77e7a@gmail.com> References: <20261108-bug-mm-ksm-smart-scan-align-skips-v4-0-86be8fe77e7a@gmail.com> In-Reply-To: <20261108-bug-mm-ksm-smart-scan-align-skips-v4-0-86be8fe77e7a@gmail.com> To: Andrew Morton , David Hildenbrand , Xu Xin , Chengming Zhou , Stefan Roesch , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Shuah Khan , Jonathan Corbet , Shuah Khan , Randy Dunlap Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, Qiliang Yuan X-Mailer: b4 0.13.0 The KSM helpers in vm_util read and write KSM's sysfs and procfs files with a single pread() or write(), and return -errno when the call does not transfer what they asked for. A read of zero bytes or a short write leaves errno at 0, so the helpers then return 0, which their callers take as a value of 0 or as a write that took effect. A short write of run makes ksm_start() wait for scans of a ksmd that never started, a short read of full_scans makes it wait for scans that never seem to complete, and short reads of ksm_merging_pages or ksm_stat and a short write of use_zero_pages make cases fail that should have been skipped. Return -errno only when the call fails, and -EIO when it transfers less than asked, so that callers skip or fail as they do on other errors. Forcing each short read or write with an LD_PRELOAD shim on ksm_functional_tests: short read or write of before after run cases fail, then hangs all skipped full_scans hangs in the first case all skipped ksm_merging_pages 9 of 11 cases fail all skipped ksm_stat zero page case fails zero page case skipped use_zero_pages zero page case fails zero page case skipped Signed-off-by: Qiliang Yuan --- The checks come from 93fb70aa5904 ("selftests/vm: add KSM unmerge tests"), 3d0745e59c84 ("selftest: add a testcase of ksm zero pages") and 42096aa24b82 ("selftest/mm: ksm_functional_tests: test in mmap_and_merge_range() if anything got merged"), and b27f292de6b1 ("selftests/mm: put general ksm operation into vm_util") turned the use_zero_pages check into one of them. There are no Fixes tags, as only short reads and writes forced with the shim hit them, and the helpers are in vm_util only since v6.18. --- tools/testing/selftests/mm/vm_util.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/mm/vm_util.c b/tools/testing/selftests/mm/vm_util.c index 515031b8283da..caea045fa7d46 100644 --- a/tools/testing/selftests/mm/vm_util.c +++ b/tools/testing/selftests/mm/vm_util.c @@ -920,6 +920,8 @@ long ksm_get_self_zero_pages(void) close(proc_self_ksm_stat_fd); if (read_size < 0) return -errno; + if (!read_size) + return -EIO; buf[read_size] = 0; @@ -944,8 +946,10 @@ long ksm_get_self_merging_pages(void) ret = pread(proc_self_ksm_merging_pages_fd, buf, sizeof(buf) - 1, 0); close(proc_self_ksm_merging_pages_fd); - if (ret <= 0) + if (ret < 0) return -errno; + if (!ret) + return -EIO; buf[ret] = 0; return strtol(buf, NULL, 10); @@ -963,8 +967,10 @@ long ksm_get_full_scans(void) ret = pread(ksm_full_scans_fd, buf, sizeof(buf) - 1, 0); close(ksm_full_scans_fd); - if (ret <= 0) + if (ret < 0) return -errno; + if (!ret) + return -EIO; buf[ret] = 0; return strtol(buf, NULL, 10); @@ -981,7 +987,9 @@ int ksm_use_zero_pages(void) ret = write(ksm_use_zero_pages_fd, "1", 1); close(ksm_use_zero_pages_fd); - return ret == 1 ? 0 : -errno; + if (ret < 0) + return -errno; + return ret == 1 ? 0 : -EIO; } int ksm_start(void) @@ -1002,8 +1010,10 @@ int ksm_start(void) } ret = write(ksm_fd, "1", 1); close(ksm_fd); - if (ret != 1) + if (ret < 0) return -errno; + if (ret != 1) + return -EIO; do { end_scans = ksm_get_full_scans(); if (end_scans < 0) @@ -1024,7 +1034,9 @@ int ksm_stop(void) ret = write(ksm_fd, "2", 1); close(ksm_fd); - return ret == 1 ? 0 : -errno; + if (ret < 0) + return -errno; + return ret == 1 ? 0 : -EIO; } int get_hardware_corrupted_size(unsigned long *val) -- 2.43.0