From: Alban Munari via B4 Relay <devnull+alban.kernel.gmail.com@kernel.org>
To: Peter Huewe <peterhuewe@gmx.de>,
Jarkko Sakkinen <jarkko@kernel.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Ard Biesheuvel <ardb@kernel.org>
Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
Alban Munari <alban.kernel@gmail.com>
Subject: [PATCH] tpm: Fix the value of TPM2_SE_TRIAL
Date: Sun, 08 Nov 2026 18:05:39 +0000 [thread overview]
Message-ID: <20261108-tpm-se-trial-v1-1-492218f9de41@gmail.com> (raw)
From: Alban Munari <alban.kernel@gmail.com>
The TPM 2.0 Library specification, Part 2: Structures, defines the
session types (TPM_SE) as TPM_SE_HMAC = 0x00, TPM_SE_POLICY = 0x01 and
TPM_SE_TRIAL = 0x03. TPM2_SE_TRIAL is defined as 0x02, which is not a
session type: TPM2_StartAuthSession with it fails with TPM_RC_VALUE on
the sessionType parameter, as swtpm 0.11.0 shows.
No code in the kernel uses TPM2_SE_TRIAL, so nothing changes at run
time. The TPM 2.0 selftests already define it as 0x03 in
tools/testing/selftests/tpm2/tpm2.py.
This change was found and written with an AI coding assistant (Claude
Opus 5.5, Anthropic), while building trial sessions on an AMD fTPM with
the value 0x03.
Fixes: 699e3efd6c64 ("tpm: Add HMAC session start and end functions")
Signed-off-by: Alban Munari <alban.kernel@gmail.com>
---
include/linux/tpm_command.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/tpm_command.h b/include/linux/tpm_command.h
index fc446a1282e2..076ee8ce816c 100644
--- a/include/linux/tpm_command.h
+++ b/include/linux/tpm_command.h
@@ -171,7 +171,7 @@ struct tpm1_get_random_out {
enum tpm2_session_types {
TPM2_SE_HMAC = 0x00,
TPM2_SE_POLICY = 0x01,
- TPM2_SE_TRIAL = 0x02,
+ TPM2_SE_TRIAL = 0x03,
};
enum tpm2_timeouts {
---
base-commit: 05441d697f7f9a927264f4058cbbc6a03dfcac9d
change-id: 20261108-tpm-se-trial-580bef9b4f17
Best regards,
--
Alban Munari <alban.kernel@gmail.com>
next reply other threads:[~2026-11-08 18:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 18:05 Alban Munari via B4 Relay [this message]
2026-11-08 18:28 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261108-tpm-se-trial-v1-1-492218f9de41@gmail.com \
--to=devnull+alban.kernel.gmail.com@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alban.kernel@gmail.com \
--cc=ardb@kernel.org \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®