mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Arka Mondal <arka@arkamondal.net>
Cc: "Linus Walleij" <linusw@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Peter Meerwald" <pmeerw@pmeerw.net>,
	"Matt Ranostay" <mranostay@gmail.com>,
	"Robert Eshleman" <bobbyeshleman@gmail.com>,
	"Leonard Crestez" <cdleonard@gmail.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] iio: light: max44000: Report the available lists via read_avail()
Date: Sun, 8 Nov 2026 01:12:19 +0000	[thread overview]
Message-ID: <20261108011219.6e69e92b@jic23-hlaptop> (raw)
In-Reply-To: <20261102074700.63075-5-arka@arkamondal.net>

On Mon,  2 Nov 2026 16:46:58 +0900
Arka Mondal <arka@arkamondal.net> wrote:

> The light channel keeps IIO_CHAN_INFO_SCALE and IIO_CHAN_INFO_INT_TIME
> in info_mask_shared_by_type, so userspace sees in_illuminance_scale
> and in_illuminance_integration_time. Two custom attributes list the
> values those accept, but they are named illuminance_scale_available and
> illuminance_integration_time_available, without the in_ prefix the core
> gives the attribute a list belongs to. Both land at the device level,
> paired with nothing, so userspace that asks for either prefixed name
> finds no such file.
> 
> Report both lists through read_avail() and delete the two attributes
> along with the strings they printed.
> 
> Each list uses the format the write path accepts, which
> max44000_write_raw_get_fmt() gives as IIO_VAL_INT_PLUS_MICRO for
> scale and IIO_VAL_INT_PLUS_NANO for integration time. The scale
> is read back as IIO_VAL_FRACTIONAL_LOG2, the same number written
> another way. max44000_write_raw() still rounds a request against
> the ulux table with find_closest() and against the ns table with
> find_closest_descending(), so both tables stay and the lists are
> separate arrays of value pairs.
> 
> No value changes, but the core prints each one to the full precision
> of its format. The scale now reads 0.031250 0.125000 0.500000 4.000000
> where it read 0.03125 0.125 0.5 4, and the integration time reads
> 0.100000000 0.025000000 0.006250000 0.001562500 where it read 0.100
> 0.025 0.00625 0.0015625.
> 
> Fixes: d5d8f49b6345 ("max44000: Expose ambient sensor scaling")
> Signed-off-by: Arka Mondal <arka@arkamondal.net>
Applied this one to the testing branch of iio.git.

Thanks,

Jonathan

  reply	other threads:[~2026-11-08  1:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02  7:46 [PATCH 0/6] iio: Give the *_available attributes the names the core generates Arka Mondal
2026-11-02  7:46 ` [PATCH 1/6] iio: light: isl29125: Report the scale list via read_avail() Arka Mondal
2026-11-02 22:26   ` Jonathan Cameron
2026-11-02  7:46 ` [PATCH 2/6] iio: light: apds9960: Report the available lists " Arka Mondal
2026-11-08  1:10   ` Jonathan Cameron
2026-11-02  7:46 ` [PATCH 3/6] iio: light: max44009: Report the integration time " Arka Mondal
2026-11-08  1:08   ` Jonathan Cameron
2026-11-02  7:46 ` [PATCH 4/6] iio: light: max44000: Report the available lists " Arka Mondal
2026-11-08  1:12   ` Jonathan Cameron [this message]
2026-11-02  7:46 ` [PATCH 5/6] iio: humidity: hdc100x: " Arka Mondal
2026-11-08  1:14   ` Jonathan Cameron
2026-11-02  7:47 ` [PATCH 6/6] iio: gyro: mpu3050: Fix the scale list and report it " Arka Mondal
2026-11-08  1:18   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261108011219.6e69e92b@jic23-hlaptop \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=arka@arkamondal.net \
    --cc=bobbyeshleman@gmail.com \
    --cc=cdleonard@gmail.com \
    --cc=dlechner@baylibre.com \
    --cc=linusw@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mranostay@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®