From: Hans Zhang <18255117159@163.com>
To: bhelgaas@google.com, mani@kernel.org, lpieralisi@kernel.org,
kwilczynski@kernel.org, thierry.reding@kernel.org,
ryder.lee@mediatek.com, jonathanh@nvidia.com
Cc: robh@kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-tegra@vger.kernel.org, Hans Zhang <18255117159@163.com>
Subject: [PATCH v2 3/5] PCI: tegra264: Use pcie_get_link_speed()
Date: Sun, 8 Nov 2026 17:40:32 +0800 [thread overview]
Message-ID: <20261108094034.679945-4-18255117159@163.com> (raw)
In-Reply-To: <20261108094034.679945-1-18255117159@163.com>
Tegra264 was added after pcie_get_link_speed() was introduced and still
indexes pcie_link_speed[] directly. Convert it to the helper so it does
not depend on the array being exported and cannot go out of bounds on
invalid speed values.
Signed-off-by: Hans Zhang <18255117159@163.com>
---
drivers/pci/controller/pcie-tegra264.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/controller/pcie-tegra264.c b/drivers/pci/controller/pcie-tegra264.c
index c97576ab4a31..711b66287681 100644
--- a/drivers/pci/controller/pcie-tegra264.c
+++ b/drivers/pci/controller/pcie-tegra264.c
@@ -126,7 +126,7 @@ static void tegra264_pcie_icc_set(struct tegra264_pcie *pcie)
width = FIELD_GET(PCI_EXP_LNKCAP_MLW, value);
}
- value = Mbps_to_icc(width * PCIE_SPEED2MBS_ENC(pcie_link_speed[speed]));
+ value = Mbps_to_icc(width * PCIE_SPEED2MBS_ENC(pcie_get_link_speed(speed)));
/*
* We don't want to error out here because a boot-critical device
@@ -266,8 +266,8 @@ static bool tegra264_pcie_link_up(struct tegra264_pcie *pcie,
if (value & PCI_EXP_LNKSTA_DLLLA) {
if (speed)
- *speed = pcie_link_speed[FIELD_GET(PCI_EXP_LNKSTA_CLS,
- value)];
+ *speed = pcie_get_link_speed(FIELD_GET(PCI_EXP_LNKSTA_CLS,
+ value));
return true;
}
--
2.43.0
next prev parent reply other threads:[~2026-11-08 9:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 9:40 [PATCH v2 0/5] PCI: Encapsulate pcie_link_speed array access Hans Zhang
2026-11-08 9:40 ` [PATCH v2 1/5] PCI: Use pcie_get_link_speed() in pci.c Hans Zhang
2026-11-09 12:03 ` Ilpo Järvinen
2026-11-08 9:40 ` [PATCH v2 2/5] PCI: Convert remaining core pcie_link_speed[] users Hans Zhang
2026-11-08 9:40 ` Hans Zhang [this message]
2026-11-08 9:40 ` [PATCH v2 4/5] PCI: mediatek: Use pcie_get_link_speed() Hans Zhang
2026-11-08 9:40 ` [PATCH v2 5/5] PCI: Make pcie_link_speed[] private to probe.c Hans Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261108094034.679945-4-18255117159@163.com \
--to=18255117159@163.com \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®