mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wentao Liang <vulab@iscas.ac.cn>
To: Alex Elder <elder@ieee.org>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	elder@kernel.org, kuba@kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, pabeni@redhat.com, vulab@iscas.ac.cn
Subject: Re: [PATCH] net: ipa: Fix runtime PM reference leak in ipa_remove()
Date: Sun, 08 Nov 2026 10:25:00 +0000	[thread overview]
Message-ID: <20261108102500.3182111-1-vulab@iscas.ac.cn> (raw)
In-Reply-To: <7509f005-709d-46d5-8554-b9d2fd0cd218@ieee.org>

Hi Alex,

Sorry for the very late reply, and for the noise.

You are right that this is already fixed, and I should have caught it
before posting.  6b9eaa61ff2df ("net: ipa: balance runtime PM reference on
remove error") makes the same change, and it has been in mainline since
v7.3-rc1.  I rechecked ipa_remove() in the current tree, and that error
path now releases the reference:

			dev_err(dev, "Failed to stop modem (%pe), leaking resources\n",
				ERR_PTR(ret));
			pm_runtime_put_noidle(dev);
			return;

so the usage count is balanced there and there is nothing left to fix.
The patch needs no v2; please disregard it.  The patchwork entry already
shows as not applicable.

You asked how I found the problem.  The candidate came from our static
analysis tooling, which flagged the missing put on that error path.  I
then used DeepSeek and GPT-6.1 Sol to audit the finding and to help write
the change, and I reviewed the result myself before sending it.

What I got wrong is that the diff was prepared from an old snapshot
(v7.1-rc4 based) and I did not check the current tree before posting, so
I missed that the fix had already landed.  That is on me, and I am sorry
for the review time it cost you.

I am going through the outstanding feedback on my patches by hand now,
thread by thread, and will answer each one.

Thanks,
Wentao


  reply	other threads:[~2026-11-08 10:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17 11:51 Wentao Liang
2026-09-17 12:10 ` Alex Elder
2026-11-08 10:25   ` Wentao Liang [this message]
2026-11-08 13:29     ` Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261108102500.3182111-1-vulab@iscas.ac.cn \
    --to=vulab@iscas.ac.cn \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=elder@ieee.org \
    --cc=elder@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®