mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wentao Liang <vulab@iscas.ac.cn>
To: Greg KH <greg@kroah.com>
Cc: Alex Elder <elder@ieee.org>,
	andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
	elder@kernel.org, kuba@kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, pabeni@redhat.com, vulab@iscas.ac.cn
Subject: Re: [PATCH] net: ipa: Fix valid_state leak in ipa_smp2p_init()
Date: Sun, 08 Nov 2026 10:29:00 +0000	[thread overview]
Message-ID: <20261108102900.3182133-1-vulab@iscas.ac.cn> (raw)
In-Reply-To: <2026091702-engraving-bride-3af1@gregkh>

Hi Greg, Alex,

Sorry for the very late reply to both of you, and for the extra work this
caused.

Alex, you are right that 96ca1e658ae45 ("net: ipa: fix SMEM state handle
leaks in SMP2P init") already covers this.  It releases both SMEM state
handles on the init error paths and in ipa_smp2p_exit(), and it has been
in mainline since v7.2-rc2.  My patch duplicates it, was incomplete on
its own, and was generated from an old snapshot (v7.1-rc4 based), which
is why its context does not match v7.2.  There is nothing left to fix, so
please disregard it; the patchwork entry already shows as not applicable.

Greg, I owe you an answer on the Assisted-by tag, and I am sorry for
leaving it hanging.  The candidate came from our static analysis tooling,
and DeepSeek and GPT-6.1 Sol were used to audit the finding and help
write the change; I reviewed the result and I am responsible for what I
sent.  I should have declared that in the changelog itself, and I did
not.  I have re-read Documentation/process/generated-content.rst on this
and will state the tools used in the changelog text from now on.

Since all three changes here are already upstream, there is no v2 to
send.  On the volume: you are right, I sent far more patches than I could
follow up on, and the review time that cost is on me.  This has been an
important lesson.  I am now going through all of the outstanding feedback
on every patch I sent, by hand, thread by thread, and I will answer each
one.  I will not post patches in batches larger than I can personally
review and follow up on.

Thanks,
Wentao


  reply	other threads:[~2026-11-08 10:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17 11:54 Wentao Liang
2026-09-17 12:14 ` Greg KH
2026-11-08 10:29   ` Wentao Liang [this message]
2026-09-17 12:18 ` Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261108102900.3182133-1-vulab@iscas.ac.cn \
    --to=vulab@iscas.ac.cn \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=elder@ieee.org \
    --cc=elder@kernel.org \
    --cc=greg@kroah.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®