From: Wentao Liang <vulab@iscas.ac.cn>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: Mark Brown <broonie@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
patches@opensource.cirrus.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, vulab@iscas.ac.cn
Subject: Re: [PATCH] ASoC: arizona-jack: Fix runtime PM leak in arizona_start_mic()
Date: Sun, 08 Nov 2026 11:46:29 +0000 [thread overview]
Message-ID: <20261108114629.3205150-1-vulab@iscas.ac.cn> (raw)
In-Reply-To: <aq1TUA77ukvvBjso@opensource.cirrus.com>
Hi Charles,
Sorry for the very late reply, and for the time you spent on a patch
that should not have been sent.
You are right, and I am withdrawing it. By that point the function has
already taken the runtime PM reference, enabled MICVDD and pulsed
micbias, so a bare put would drop the reference without the rest of the
teardown; and as you say, a failed MICD enable most likely only means
the headset buttons are dead while the mic still records. Tearing all
of that down properly would need the regulator and DAPM side too, which
I cannot validate without hardware. Please disregard the patch; I will
not send a v2.
I take the general point about these HPDET and MIC sequences, and I will
not touch them again until I can test on hardware. I am also going
through the outstanding review comments by hand, and I will not send
patches in bulk any more.
Thanks,
Wentao
next prev parent reply other threads:[~2026-11-08 11:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 16:46 Wentao Liang
2026-09-18 15:05 ` Charles Keepax
2026-11-08 11:46 ` Wentao Liang [this message]
2026-11-09 11:22 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261108114629.3205150-1-vulab@iscas.ac.cn \
--to=vulab@iscas.ac.cn \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=cw00.choi@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®