mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wentao Liang <vulab@iscas.ac.cn>
To: Rob Herring <robh@kernel.org>, Saravana Kannan <saravanak@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Wentao Liang <vulab@iscas.ac.cn>
Subject: Re: [PATCH] of: unittest: fix node reference leak in of_notify()
Date: Sun, 08 Nov 2026 11:56:44 +0000	[thread overview]
Message-ID: <20261108121500.3133-1-vulab@iscas.ac.cn> (raw)
In-Reply-To: <20261103104236.1373612-1-vulab@iscas.ac.cn>

Hi,

Please disregard this patch, and the September one as well:
  https://lore.kernel.org/all/20260917124457.2151809-1-vulab@iscas.ac.cn/

My analysis was wrong. of_find_node_by_name() calls
of_node_put() on its @from argument, so the four valid actions
already release the reference taken by of_node_get(nd->overlay),
and only the default branch needed the explicit put. Moving it
after the switch would have dropped that reference twice. The
original code is correct and there is nothing to fix here.

Sorry for the noise.

Wentao


      parent reply	other threads:[~2026-11-08 11:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 10:42 Wentao Liang
2026-11-03 11:09 ` Krzysztof Kozlowski
2026-11-08 11:56 ` Wentao Liang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261108121500.3133-1-vulab@iscas.ac.cn \
    --to=vulab@iscas.ac.cn \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=saravanak@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®