Re: [PATCH] net: octeontx2-pf: drop the TC mark reference when adding a flow fails

[Simon Horman <horms@kernel.org>]

On Sat, Nov 07, 2026 at 11:31:48AM +0000, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 1 (1) · Medium: 1 (1) · Low: 0
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
> 
> - [High] The new helper otx2_tc_put_mark_flow() (otx2_tc.c:1240-1245)
>   uses `req->match_id != 0` to decide whether a mark_flows reference was…
> - [Medium] net: octeontx2-pf: otx2_tc_put_mark_flow() leaves TC mark flag
>   enabled

It seems to me that although two issues above are pre-existing, they
should be considered as part of the problem that this patch seeks to
address. So I think they should be addressed by a revised version of
this patch-set.

> 
> Pre-existing issues:
> - [High] This problem wasn't introduced by this patch, but it makes the
>   counter the patch balances meaningless.
> - [Medium] This problem wasn't introduced by this patch, but the error
>   paths of otx2_tc_add_flow() that the patch edits fail to undo other…

...

-- 
pw-bot: changes-requested