mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: netdev-bot+sashiko@kernel.org
Cc: vulab@iscas.ac.cn, marcin.s.wojtas@gmail.com,
	linux@armlinux.org.uk, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] net: mvpp2: free pending TX timestamp skbs when the port is stopped
Date: Sun, 8 Nov 2026 17:28:51 +0000	[thread overview]
Message-ID: <20261108172851.GJ18859@horms.kernel.org> (raw)
In-Reply-To: <179405285872.994134.2557194195988942800@kernel.org>

On Sat, Nov 07, 2026 at 12:00:58PM +0000, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 1 (1) · Medium: 0 · Low: 0 (1)
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
> 
> - [High] The new mvpp2_tx_hwtstamp_flush()
>   (drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:3422-3436) checks,…

I lean towards this being a pre-existing issue that can be handled
separately from this patch. But I do note that taken at face-value
it severely impacts the reliability of the  teardown path and the
usefulness of this patch in practice.

> Pre-existing issues:
> - [High] This problem wasn't introduced by this patch, but it is a
>   serious race on the same data.
> - [Low] Baseline decision: not a valid finding against this patch.

...

      reply	other threads:[~2026-11-08 17:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03 10:05 Wentao Liang
2026-11-03 10:10 ` netdev-bot+sinfo
2026-11-08 17:34   ` Simon Horman
2026-11-03 10:25 ` Krzysztof Kozlowski
2026-11-07 12:00 ` netdev-bot+sashiko
2026-11-08 17:28   ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261108172851.GJ18859@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=marcin.s.wojtas@gmail.com \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=vulab@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®