From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Waiman Long <longman@redhat.com>
Cc: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
"Chen Yu" <yu.c.chen@intel.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Guopeng Zhang" <guopeng.zhang@linux.dev>,
"Tejun Heo" <tj@kernel.org>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Ridong Chen" <ridong.chen@linux.dev>,
"Tim Chen" <tim.c.chen@linux.intel.com>,
"Valentin Schneider" <vschneid@redhat.com>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [BUG] cpuset: empty sched domain with isolcpus=domain, panic at CPU offline
Date: Sun, 8 Nov 2026 13:46:20 -0500 [thread overview]
Message-ID: <20261108184620.1548615-1-mathieu.desnoyers@efficios.com> (raw)
In-Reply-To: <12cb0bee-57aa-4609-bc2e-77806e0b6805@redhat.com>
On 2026-11-08 13:35, Waiman Long wrote:
[...]
> Yes, we are going to add the check to make sure that there will be at
> least one housekeeping CPU left for the top_cpuset sched domain.
>
> See
> https://lore.kernel.org/lkml/20261105130344.664336-1-guopeng.zhang@linux.dev/
Thanks, I had missed that series. Refusing such a partition is a better
fix than giving the top cpuset no sched domain.
> This patch is correct AFAICS. I am not against it but it may not be
> necessary after we make sure that there is at least one HK online CPU in
> the top sched domain.
Then I will drop my patch and rely on Guopeng's series. I can test its
v3 on the setup that hit the panic: 5 vCPUs with isolcpus=domain,0,1.
By my reading, your _cpu_down() patch covers a case that cpuset cannot
fix. With no partition, the last online housekeeping CPU could go
offline. No partition could then give one back.
Thanks,
Mathieu
next prev parent reply other threads:[~2026-11-08 18:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 14:57 Mathieu Desnoyers
2026-11-08 18:35 ` Waiman Long
2026-11-08 18:46 ` Mathieu Desnoyers [this message]
2026-11-08 19:06 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261108184620.1548615-1-mathieu.desnoyers@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=cgroups@vger.kernel.org \
--cc=guopeng.zhang@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mkoutny@suse.com \
--cc=peterz@infradead.org \
--cc=ridong.chen@linux.dev \
--cc=tim.c.chen@linux.intel.com \
--cc=tj@kernel.org \
--cc=vschneid@redhat.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®