mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chad Aldreda <ca@modelmiser.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Nicolas Palix <nicolas.palix@imag.fr>,
	cocci@inria.fr, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coccinelle: api: add a checker for device nodes in devm_ memory
Date: Sun, 08 Nov 2026 20:36:32 +0000	[thread overview]
Message-ID: <20261108203625.2517017-2-ca@modelmiser.com> (raw)
In-Reply-To: <18f23c2b-d76a-8b94-bc4d-f298354c8f8b@inria.fr>

On Sun, 8 Nov 2026, Julia Lawall wrote:
> I get the same result for
>
> spatch --dir drivers/media/pci/intel/ipu6 scripts/coccinelle/api/devm_file_reachable.cocci -D report --very-quiet
> spatch drivers/media/pci/intel/ipu6/ipu6-isys.c scripts/coccinelle/api/devm_file_reachable.cocci -D report --very-quiet
>
> Both report the line 990 issue.
>
> What version of Coccinelle do you have?

It was 1.1.1, the Ubuntu 24.04 package. With it the --dir run reports
nothing. I built 1.3.3 from git (11b93adb6), and with it both of your
commands report line 990, as does the --include-headers --dir command
from my note, so it was the old version.

Over drivers/ with the script's Options line, 1.3.3 reports one site
more than 1.1.1: drivers/misc/pci_endpoint_test.c, whose probe function
1.1.1 fails to parse. I'll redo the measurements, including the -j
variance, with 1.3.3 for v2.

Thanks for the pointer on the parsing nondeterminism.

Chad


      reply	other threads:[~2026-11-08 20:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 19:35 Chad Aldreda
2026-11-06 20:20 ` Julia Lawall
2026-11-06 21:07   ` Chad Aldreda
2026-11-07  9:10   ` [cocci] " Markus Elfring
2026-11-07 10:55 ` Markus Elfring
2026-11-07 13:40 ` Markus Elfring
2026-11-07 14:37 ` Markus Elfring
2026-11-08 20:10 ` Julia Lawall
2026-11-08 20:36   ` Chad Aldreda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261108203625.2517017-2-ca@modelmiser.com \
    --to=ca@modelmiser.com \
    --cc=cocci@inria.fr \
    --cc=julia.lawall@inria.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.palix@imag.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®