From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.200 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794177585; b=1Hup5FYFXvCC3CtHZ1esof7dE+xYtgg2efJylZxRu5JY8sI/bwJt9SX6o80MA30QcRoL Hu1Qw1Ikw0wi2h8vRqKquTev4gGxR+CwlVuOvfHRsdjahLkQTnKwdHzL9q05l7t+lPW4F I320JWmnKvavg5gJJUMS2RiRzAenASV5gw6MQ1PzF+xz9Qi8cfRSo7CpvEVt55WnapbCV SnMgU3EMyZVu6FhqFwH3OqRUZ6dxvtza/UTgn9XSG3yRUd3EpepCtwGWU+3yJC0DqKMkZ SQJt60LmHXY6sOGR78wxDML409HUeQs2DKI8+hgZ6svZp2jLc6wlzXgNzNzXFR9b/ew== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794177585; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=4kX4Ed3A+P912IudIYmkHnIS6SHmJhWXUKLWP4ZNJ5k=; b=5azs+GUj8AZluhQKH3lIRsoxWRgV5nncLIBhFCbcUSijSTFlaL7MRgwuBCyllFh0J2/D QwI+OhyhJpHmSV0T4VG8rUzatl0DTF0guH4hHmAmI3LX0ihYXp+YEJz3E3bcpQ93PLDvh gLpTE6+BlPw6P5Fgd5bnpRlmQ8XUbdQRUcfIG8VUYHBbpFtGaICkhHQaqox+iWBpNXtas OhWZboSJlc1lP/LWKtMG+wpC8bTHA+3sb19mCfixR+Or8Q7I9Pmn2kjXjUFrXWvRVGYdB 3tSO3do7blsqVBuEURaKA58wR0aDTUfG772xNVE/FKJSpJKqX28NO+xQGH5TOnstfPw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=NF6P22Ua; arc=none smtp.remote-ip=74.125.82.200 Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B6EB606D829 for ; Sun, 8 Nov 2026 22:39:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4B6EB606D829 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=NF6P22Ua Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-36d1353fdcdso767927eec.0 for ; Sun, 08 Nov 2026 14:39:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1794177584; x=1794782384; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4kX4Ed3A+P912IudIYmkHnIS6SHmJhWXUKLWP4ZNJ5k=; b=NF6P22UaPGr1HDfea9kIcWbvRKcCIqN8QEnwFDbKz7tk/YbwkvRrkeVgpGhGtL4pd4 hfj9fQFfEsWjRGIU/+FpesE50zkmrNYtB0biAoRbXjgTG8kMFlw/AC5Ttr/5yXHV58NT pvVgwNyRYk/BerQZCNGYBlTcX/bdD89VaZWATi3zdy9xhnS3TijcKHBVOoyTt5heM+Ck cKpvfTO3CnEyaewDLme9eiHmbl56rQt1ycDdA87P+CCgihWAn4/ugTKalEaouLl+FTTk pJH/XwedfFvWkr1XlZ3RGbE9CRxI3L+P1FZ7lzjMyolBo8TwkVZOI96BhudO+UAAzah5 6xKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794177584; x=1794782384; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4kX4Ed3A+P912IudIYmkHnIS6SHmJhWXUKLWP4ZNJ5k=; b=JqfmKY34wZKweDARD78ypIqLnKFUyA99PAjU/H45hcFZ8uF8pbpn+7tkU9UhxHYZsA FAXIDP5qmoMNf18gkUz4sDfMH5kmF3OqWYWg2e4HOkIF0DcIar6p6OAStLi/f+H/yM9d EY3V2M05miA16eVF1FNEIhjdqOC5q5kndggKvfa2tSCBqhukmUnq0+dEMJhbiVJn/g4I nwWf06WawaKIafYEDUBJ1XRPKXZsmgS2x3uNESi7OD8vrRE3ue9xzUUOMWt1vcIG1OO3 iSZ46zgHlMrPaznAGPkH6jZxuXJ60Aq5Db2HaAQqjlSevj+iTBlmFy6HARFXGAjaAM3h 1y0w== X-Forwarded-Encrypted: i=1; AL+hErHhdFgyvwzoBfydOeKwFY1qC3Y41FVHuJbN6g5zJYKIwUlQ7CsESmcPQBkOB7zn3F0DZcXZ3/SFvoe7S4U=@vger.kernel.org X-Gm-Message-State: APuU4Z+5ubcxUTHE5kuirKNG0kfJuixbaOfgf3MRVqBKq1WTAeXq6eDL QmBFyYonxHJ15t2RWFRLbqvIvU559s3Lt6RlmVlJ9wsj1xjtGRpf/p+FZGP6nZ13JIoo+5GLwGi qrVHYjtQPkw== X-Received: from dlad1.prod.google.com ([2002:a05:701b:2201:b0:1b2:6421:f4fb]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:ea8a:b0:163:bee9:b250 with SMTP id a92af1059eb24-1b39fedbec2mr3348910c88.22.1794177583902; Sun, 08 Nov 2026 14:39:43 -0800 (PST) Date: Sun, 8 Nov 2026 14:39:06 -0800 In-Reply-To: <20261108223913.3624571-1-irogers@google.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261108223913.3624571-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.455.g6c5a503b38-goog Message-ID: <20261108223913.3624571-3-irogers@google.com> Subject: [PATCH v3 2/9] powerpc/secvar: Add missing kobject release callback to secvar_ktype From: Ian Rogers To: Danilo Krummrich , Greg Kroah-Hartman , Kees Cook , Miguel Ojeda , "Rafael J . Wysocki" Cc: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nayna Jain , Srish Srinivasan , Mimi Zohar , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Nathan Chancellor , Nick Desaulniers , Viresh Kumar , Zhongqiu Han , Alexander Aring , Felix Kuehling , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , Zhihao Cheng , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers Content-Type: text/plain; charset="UTF-8" In add_var(), a struct kobject is dynamically allocated with kzalloc_obj() and initialized with secvar_ktype. If kobject_add() or sysfs_create_file() fails, kobject_put(kobj) is called to clean up. However, secvar_ktype does not define a .release callback, which results in a memory leak of kobj (and a pr_debug warning in kobject_cleanup() when CONFIG_DEBUG_KOBJECT_RELEASE is enabled). Provide a secvar_release() callback that calls kfree(kobj). Fixes: bd5d9c743d38 ("powerpc: expose secure variables to userspace via sysfs") Signed-off-by: Ian Rogers --- arch/powerpc/kernel/secvar-sysfs.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/powerpc/kernel/secvar-sysfs.c b/arch/powerpc/kernel/secvar-sysfs.c index 395399bbab2c..f3f6ac25ea78 100644 --- a/arch/powerpc/kernel/secvar-sysfs.c +++ b/arch/powerpc/kernel/secvar-sysfs.c @@ -126,7 +126,13 @@ static const struct attribute_group secvar_attr_group = { }; __ATTRIBUTE_GROUPS(secvar_attr); +static void secvar_release(struct kobject *kobj) +{ + kfree(kobj); +} + static const struct kobj_type secvar_ktype = { + .release = secvar_release, .sysfs_ops = &kobj_sysfs_ops, .default_groups = secvar_attr_groups, }; -- 2.56.0.455.g6c5a503b38-goog