From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.70 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794177589; b=SJ+jdzcCPqlXBnuGpl0NE5BpwrlVlpg3sZgcasTWkMXcQO30T3kmWaV09h1Rk2HWFWvx +Uj9k1hBzuLX4BffVSSqMxIcna/pu4J5MADLURqfMUrEpNy9171XMIun50c+IxKeMriEA FgF0UNDshVQuo5Ua/5tD6k5pL2yjrXziRM4D0sjCOlgWAxcP1u24GC/0UJJjQDQPXBQfY UzOK5Gl6TPKB55N7+d3drvHqHJ6RWiBw78qlYyCBttwCprNsVPFefSo63qlO3g4GKifyR Gb/pLBIYARotbj7dcDeNE9b88vPkkrPa+GgJ2/kwa63GZbTfgbfBElo6KPgn1GIu7Uw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794177589; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=JYLCMT9RKWWGiMVjfcLUv6CQmbQfnx4zZhBsCcC3dY4=; b=aJYYCNgaR2HHfhtL2/c5GDvGoPGFXAI+bwKeNRtRxRZcEOzX/8gFXPU25R1IYx5vo2JD Rflw7uB3A/Z12qKYruiv2DXjk9b/G7sxK5tt08Vw6Aka3CSZKvdJxn/hZegTuTBpL7Yxe QY7ZwoAntKNMcbGsY5T/uxe40MCu5eZjbu1jeWFXwkRTEybJ9Zw8Jw4q+7g5DN2Ut+SlR vjPei76ZP/MWYT+x4gDkv80E9H8hyIbXKpwY4WMV1/7+1NFA3IoXbrkAuiP1RtptbEheR G+b+PsRVhC65hkNLfPcEiXmIwyZKTKcxJBil/xGuFWYdF4sN2MtZdtIp9aIFyAOyniA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=ADIDh46D; arc=none smtp.remote-ip=74.125.82.70 Received: from mail-dl1-f70.google.com (mail-dl1-f70.google.com [74.125.82.70]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AF1B606EEA3 for ; Sun, 8 Nov 2026 22:39:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 6AF1B606EEA3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=ADIDh46D Received: by mail-dl1-f70.google.com with SMTP id a92af1059eb24-1b25dc2aa8bso798010c88.1 for ; Sun, 08 Nov 2026 14:39:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1794177589; x=1794782389; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JYLCMT9RKWWGiMVjfcLUv6CQmbQfnx4zZhBsCcC3dY4=; b=ADIDh46DUBqBys/6wqzndaltMvqIc4sQNJs3ehQS3f7jmT62qUG8MJZ02uTVOZsHWH 0ZzeF8E1tPORMQLnd+9Jx4vyOzEM9OOZTbRyYA20/yJ++O3uS3nv78XY9W2BWRFyQ6/+ lfozId7LdGR434W5ZcHkDVq8N8fFQqe3taKoWG1gAlfLHy4oEE6uNOZDeXXg3S1b4SZ4 /+Vw0yXcCUUqTXSmsy0hg+Xai9kd9UpzAayBEEijXSK2n8JHHiLfCxLmVi/zMTb/LDC4 qL4N4+qxmuhNCjliswH8N7XXHSDbqJWNIE2BI41But5E0XgABxSFxr9MsOhUC0+iw64V 01yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794177589; x=1794782389; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JYLCMT9RKWWGiMVjfcLUv6CQmbQfnx4zZhBsCcC3dY4=; b=n9uRgtXM1PX/EoGnIpJu8d8S6kBDAEHwqvFBKn4cLtWkdW5IZwKCZo/zwDsNtJq0aI 4kpH1KqTSHJh1Ex2fWAm9QbvqGowCEfHAHCcVWAhNmTd2tA0f7YdQjsu0v7hOlnkbupp +vhi6mZ9j/wMvQcg/ZOMe/tPs5Z4huBUqLFfHpNz2H+ZKhsvZmX6pdiFk9JohloN0X6Q 8OuUOqYVAdpqQ4GlcHjuji9lhE1fW/YRHeFF6Hul/3oij2QDNC6vZ9UG/lnoHgrlAmeF wnlpreHkGsYaApg5ZLjCoa5q6R8qSzKJMBzE0kk9s72VIBnlkPosW76a/lTtes/EnNJA JCAw== X-Forwarded-Encrypted: i=1; AL+hErHHC7N7IPHNVLWTQVSxTGAWtCYcrmoOILuLwmRUs4iVEpSNOPBesoYGxdhgZejYW3VduS7AmRnX5eXqRIw=@vger.kernel.org X-Gm-Message-State: APuU4Z9go/f62gkFVoWMOwb/PQlOCG0btTcqjEirYXcfjPoMQ4cCdRcc r3XzX8OfPU43nyitZm5hwTTrWxSxvkalyColR/0sb6UHhYs2VWIqSDXMOq9R8ekMEeDZOyiffkr MyE/ZM995jQ== X-Received: from dlec20-n1.prod.google.com ([2002:a05:701b:4294:10b0:1a4:c892:b166]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:ef16:b0:1b3:a26b:8b97 with SMTP id a92af1059eb24-1b3a26b8c4bmr3821391c88.41.1794177588129; Sun, 08 Nov 2026 14:39:48 -0800 (PST) Date: Sun, 8 Nov 2026 14:39:08 -0800 In-Reply-To: <20261108223913.3624571-1-irogers@google.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261108223913.3624571-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.455.g6c5a503b38-goog Message-ID: <20261108223913.3624571-5-irogers@google.com> Subject: [PATCH v3 4/9] cpufreq: governor: Initialize kobj_type release callback statically From: Ian Rogers To: Danilo Krummrich , Greg Kroah-Hartman , Kees Cook , Miguel Ojeda , "Rafael J . Wysocki" Cc: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nayna Jain , Srish Srinivasan , Mimi Zohar , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Nathan Chancellor , Nick Desaulniers , Viresh Kumar , Zhongqiu Han , Alexander Aring , Felix Kuehling , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , Zhihao Cheng , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers Content-Type: text/plain; charset="UTF-8" Export cpufreq_dbs_data_release() and initialize .kobj_type.release statically in the ondemand and conservative governors instead of assigning it at runtime in cpufreq_dbs_governor_init(). This prepares for annotating struct kobj_type::release with __must_init. Reviewed-by: Zhongqiu Han Acked-by: Rafael J. Wysocki (Intel) # cpufreq Acked-by: Viresh Kumar Signed-off-by: Ian Rogers --- drivers/cpufreq/cpufreq_conservative.c | 5 ++++- drivers/cpufreq/cpufreq_governor.c | 4 ++-- drivers/cpufreq/cpufreq_governor.h | 1 + drivers/cpufreq/cpufreq_ondemand.c | 5 ++++- 4 files changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/cpufreq/cpufreq_conservative.c b/drivers/cpufreq/cpufreq_conservative.c index 02bfd46543e9..146a2353b1a2 100644 --- a/drivers/cpufreq/cpufreq_conservative.c +++ b/drivers/cpufreq/cpufreq_conservative.c @@ -318,7 +318,10 @@ static void cs_limits(struct cpufreq_policy *policy) static struct dbs_governor cs_governor = { .gov = CPUFREQ_DBS_GOVERNOR_INITIALIZER("conservative"), - .kobj_type = { .default_groups = cs_groups }, + .kobj_type = { + .release = cpufreq_dbs_data_release, + .default_groups = cs_groups, + }, .gov_dbs_update = cs_dbs_update, .alloc = cs_alloc, .free = cs_free, diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c index f3bd3dbe7c41..f8b5aca09b6b 100644 --- a/drivers/cpufreq/cpufreq_governor.c +++ b/drivers/cpufreq/cpufreq_governor.c @@ -419,7 +419,7 @@ static void free_policy_dbs_info(struct policy_dbs_info *policy_dbs, gov->free(policy_dbs); } -static void cpufreq_dbs_data_release(struct kobject *kobj) +void cpufreq_dbs_data_release(struct kobject *kobj) { struct dbs_data *dbs_data = to_dbs_data(to_gov_attr_set(kobj)); struct dbs_governor *gov = dbs_data->gov; @@ -427,6 +427,7 @@ static void cpufreq_dbs_data_release(struct kobject *kobj) gov->exit(dbs_data); kfree(dbs_data); } +EXPORT_SYMBOL_GPL(cpufreq_dbs_data_release); int cpufreq_dbs_governor_init(struct cpufreq_policy *policy) { @@ -488,7 +489,6 @@ int cpufreq_dbs_governor_init(struct cpufreq_policy *policy) policy->governor_data = policy_dbs; gov->kobj_type.sysfs_ops = &governor_sysfs_ops; - gov->kobj_type.release = cpufreq_dbs_data_release; ret = kobject_init_and_add(&dbs_data->attr_set.kobj, &gov->kobj_type, get_governor_parent_kobj(policy), "%s", gov->gov.name); diff --git a/drivers/cpufreq/cpufreq_governor.h b/drivers/cpufreq/cpufreq_governor.h index 806d8fb4dff1..1026712bb79b 100644 --- a/drivers/cpufreq/cpufreq_governor.h +++ b/drivers/cpufreq/cpufreq_governor.h @@ -150,6 +150,7 @@ static inline struct dbs_governor *dbs_governor_of(struct cpufreq_policy *policy } /* Governor callback routines */ +void cpufreq_dbs_data_release(struct kobject *kobj); int cpufreq_dbs_governor_init(struct cpufreq_policy *policy); void cpufreq_dbs_governor_exit(struct cpufreq_policy *policy); int cpufreq_dbs_governor_start(struct cpufreq_policy *policy); diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c index 9942dbb38dae..7386d043c665 100644 --- a/drivers/cpufreq/cpufreq_ondemand.c +++ b/drivers/cpufreq/cpufreq_ondemand.c @@ -374,7 +374,10 @@ static struct od_ops od_ops = { static struct dbs_governor od_dbs_gov = { .gov = CPUFREQ_DBS_GOVERNOR_INITIALIZER("ondemand"), - .kobj_type = { .default_groups = od_groups }, + .kobj_type = { + .release = cpufreq_dbs_data_release, + .default_groups = od_groups, + }, .gov_dbs_update = od_dbs_update, .alloc = od_alloc, .free = od_free, -- 2.56.0.455.g6c5a503b38-goog