From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=82.195.75.108 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794235437; b=kuxLnuOU5tVqbb42B169NDo/Yqkji0+o5Nrpb0dII5aPaUjHRnqalNn3dnQzgCa6ZPx2 KmqO6v4eFu/k5a0YdeEZvZXwkwMOwY7NyGdE8TzrqgHbeXsq+49g0kvG8VmXGoRHh6Swg Pd8EYj8PCnY9rP9Or0l2EwidVC0vo26uot9vR5xON0uG/s8qimK2n3zAmy2ephiwMJP3i URRlfg+fGWDO9oW6dSL/WLvDFlNdAbPe6AUjw+jvaBZeO4qqd3mjCH+rfnqqq/kVWPdTM 0cxkILDkNqJ4/Q2hV9IP2wu7iYwirw0XzUeY3xR/ZMHsnj/ACVu/aycPnigALu0CmkQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794235437; h=DMARC-Filter:DKIM-Signature:Received:From:Date:Subject:MIME-Version: Content-Type:Content-Transfer-Encoding:Message-Id:X-B4-Tracking: X-Change-ID:To:Cc:X-Mailer:X-Developer-Signature:X-Developer-Key: X-Debian-User; bh=jW1Nt5uF3ROn1NR5XwafSjooEaI358J11WgWbqvS25A=; b=s9gCZssg6q+pWiIpVRY57UIZAfDnmaAsIkYC/poLlqnIpEw1iSrbAL1Z3kIoHtdqizSf ymrdQCLKdKYRzi0KInV0ZyP+Qfq6g04A3G7wb/jdmeksXKaD+qHQBkMK/gCFza3cmywy1 6xlhJIBpXvY5fYvf7BoAIiSnYW1KYQi6VBAXcQ+fxWk63QnAlbu2NqhoogtvZnMEcPNV7 z/glT+hKPyRguuFY3doTn+XH47hFk0mp2T71P/M/1Gt8FP+n9//RIFgFQYIpa6RwWsVer vdWzICL5cpgNknV0YE/D8/HviWxx7wJW2cOIrSp2M/jiyCy9meLr0CyiyNG7p4NgMeg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=debian.org; spf=pass smtp.mailfrom=debian.org; dkim=pass header.d=debian.org header.i=@debian.org header.a=rsa-sha256 header.s=smtpauto.stravinsky header.b=aO3NdL2h; arc=none smtp.remote-ip=82.195.75.108 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ACA9606A321; Mon, 9 Nov 2026 14:43:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 6ACA9606A321 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=debian.org header.i=@debian.org header.a=rsa-sha256 header.s=smtpauto.stravinsky header.b=aO3NdL2h DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From: Reply-To:Content-ID:Content-Description:In-Reply-To:References; bh=jW1Nt5uF3ROn1NR5XwafSjooEaI358J11WgWbqvS25A=; b=aO3NdL2hCYsgw2TrTJPTlfmL+o DXpl/VHMC9L+Vt3y/pzFXXyZnQ+A9O+dzWjhl51PHRGO/zCMmO+ytndiiZIZStaOKVY3i137FCjkZ /oHG9UdyvJXSYpsf2Y/Mu39M+De6p2emscJvg+D5OLVmyoLZK7bdIWJHDJ7i3C69z0woscJFOHR0l 1tqMex+7VX+kmJ32LpB299OrT0OzWa5cAfUkzNQiDXMo94/MbypmB2rpw8YAHwvD+vmNx02Imdfdw n4G2N0xSIjAZb9oRw9BUYfs7lAQLZe027uNCb30uODuyq8nZrGAzNC4KzI73tyKzE7h90tdkdWTA2 0uLZUywQ==; Received: from authenticated-user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1xQQb6-00Bh4L-17; Mon, 09 Nov 2026 14:43:48 +0000 From: Breno Leitao Date: Mon, 09 Nov 2026 06:43:27 -0800 Subject: [PATCH net] idpf: reset mb_wait_count once the mailbox is up X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261109-idpf-mb-wait-count-v1-1-c6584754df78@debian.org> X-B4-Tracking: v=1; b=H4sIAA7c8WoC/x3MTQ5AMBBA4avIrE1iGgRXEYuWKbNQ0tZPIu6us fwW7z0Q2AsH6LIHPJ8SZHMJlGcwLtrNjDIlgypUTVS0ibvF1eClJeK4HS4iNSVbU5KpVAUp3D1 buf9pD44jDO/7AUP3FL1pAAAA X-Change-ID: 20261109-idpf-mb-wait-count-184efb41b525 To: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Madhu Chittim , Emil Tantilov , Joshua Hay , Alan Brady , Sridhar Samudrala , Willem de Bruijn , Shailendra Bhatnagar , Pavan Kumar Linga Cc: Phani Burra , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, Breno Leitao X-Mailer: b4 0.15-dev-47773 X-Developer-Signature: v=1; a=openpgp-sha256; l=2115; i=leitao@debian.org; h=from:subject:message-id; bh=IUwnzebJt01HkE/iBmJlwXOxBT1vqXQ85djowTpnL6I=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBq8dwgyTgueYnU9IIX9CLhMhQ0sEZMxd0lo20vV CuQ+qYDvDCJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCavHcIAAKCRA1o5Of/Hh3 bf+hD/9/Eo1FESVGmVPGH3ztKPwV2xqeW+rVwoN5NfJFa4Ux78O0ymajfttjO1iksZE+VOLXzhg uBjp6FulhPwDmra0llVlSHhmR4q+kqqX0q3Ymk1YBN1d6tdKwwc4puCVCc1oT5dOD5NZXKBW5lE nzdR41o+b1w/F1TY7izmr5kQpfAHXuVmmxcZFCYEb7phgcXVcTvuppXJjevOZ6BQ+/x++B02NLs x64BC44X80zra6sL0yp2YmszO0Snoz88TzNxDPYPDveuUcuCV1x2eolkosmJu8DDSz/2g1XG5u+ HuTLCmCg8Bi4yswnmJH/CtOs7V88Ua5ZQ77xEvp/zl3szlmtNwvRYLmDAQWgtCkFVFSvkvkQdOA HVNAysVrcHMgziMOJP4pM/tBX4/GeSTkA7RH/806abi+cnZcOcWv6MhmhPHcOcQRunX8hRejTPV XQ9qEQUUPjAg6Jo9ARrVYxPrV1mIMmz+SadI5eiqQm9mji3AfKnnFacvhEHePYJ65fRMyS0vCvg gIAKldDqgANu+Se6Tx5EO5u9yIfOWTIkPukMqGWYcVZ/2tYmbRuK/oWZJR3FYDFthHQ97+bJAXz hvykhDvMH1FYScHGBwOU2Ko+YJ1sABlpd+Zov0nzcX+Y0FjPu8q655RWmL9Rvyp2SHECA0ERqGf kdZ+y3Z0COqImDQ== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao idpf_vc_core_init() retries a failed virtchnl version and capabilities handshake up to IDPF_MB_MAX_ERR times before it gives up on the device. Each failure increments adapter->mb_wait_count, but nothing ever clears it, so the limit is shared by every initialization in the lifetime of the adapter, including the one done by each reset. A device that fails the first handshake after a reset, and then recovers on the retry, leaves one count behind per reset. Once 20 have accumulated, the next failure is final, and the device stays down until the driver is reloaded. This is seen in Meta's fleet on hosts with recurring Tx timeouts: [ 2176.496801] idpf 0016:01:00.0 eth1: Detected Tx timeout: Count 21, Queue 11 [ 2176.508763] idpf 0016:01:00.0: Device HW Reset initiated [ 2237.412541] idpf 0016:01:00.0: Transaction timed-out (op:1 cookie:9800 vc_op:1 salt:98 timeout:60000ms) [ 2237.412578] idpf 0016:01:00.0: Failed to establish mailbox communications with hardware Clear mb_wait_count once the handshake succeeds, so the limit applies to consecutive failures only. Fixes: 4930fbf419a7 ("idpf: add core init and interrupt request") Signed-off-by: Breno Leitao --- drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c index 928de868fa624e..7c11c877acd0ba 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c @@ -3118,6 +3118,9 @@ int idpf_vc_core_init(struct idpf_adapter *adapter) msleep(task_delay); } + /* The mailbox is up, give the next reset a fresh retry budget */ + adapter->mb_wait_count = 0; + if (idpf_is_cap_ena(adapter, IDPF_OTHER_CAPS, VIRTCHNL2_CAP_LAN_MEMORY_REGIONS)) { err = idpf_cfg_lan_memory_regions(adapter); if (err) { --- base-commit: 1d5e2c57e9ffc134e14b3f837c8d7c53b508bd22 change-id: 20261109-idpf-mb-wait-count-184efb41b525 Best regards, -- Breno Leitao