mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jens Emil Schulz Østergaard" <jensemil.schulzostergaard@microchip.com>
To: Linus Walleij <linusw@kernel.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Clark Williams <clrkwllms@kernel.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	Horatiu Vultur <horatiu.vultur@microchip.com>,
	Colin Foster <colin.foster@in-advantage.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Lee Jones <lee@kernel.org>,
	Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-rt-devel@lists.linux.dev,
	"Jens Emil Schulz Østergaard"
	<jensemil.schulzostergaard@microchip.com>
Subject: [PATCH 0/2] pinctrl: ocelot: fix the GPIO irqchip context handling
Date: Mon, 9 Nov 2026 14:50:40 +0100	[thread overview]
Message-ID: <20261109-ocelot-pinctrl-irqchip-fixes-v1-0-9d2d8fcd58f5@microchip.com> (raw)

Two fixes for the GPIO irqchip of pinctrl-ocelot, where the irq_chip
callbacks take locks that are not allowed in the calling context.

The first makes the GPIO regmap use a raw spinlock. The callbacks run
with the raw spinlock irq_desc::lock held, where the spinlock_t of the
MMIO regmap is not allowed on PREEMPT_RT and is reported by
CONFIG_PROVE_RAW_LOCK_NESTING.

The second covers the regmap on a bus that can sleep, as for VSC7512
and lan9645x attached over SPI: the gpiochip is marked as sleeping and
the chained irqchip, whose callbacks run in atomic context, is no longer
registered.

The two patches are independent of each other. Both issues were
reproduced and the fixes tested on a lan9668 board (pcb8385), the
second with a lan9645x attached over SPI.

Signed-off-by: Jens Emil Schulz Østergaard <jensemil.schulzostergaard@microchip.com>
---
Jens Emil Schulz Østergaard (2):
      pinctrl: ocelot: use a raw spinlock for the GPIO regmap
      pinctrl: ocelot: do not use the chained irqchip behind a sleeping bus

 drivers/pinctrl/pinctrl-ocelot.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
---
base-commit: ff00e5c03e7efe88f7a50a8673b14e8f0d4b45bb
change-id: 20261109-ocelot-pinctrl-irqchip-fixes-74ef6d92e6f8

Best regards,
-- 
Jens Emil Schulz Østergaard <jensemil.schulzostergaard@microchip.com>


             reply	other threads:[~2026-11-09 13:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 13:50 Jens Emil Schulz Østergaard [this message]
2026-11-09 13:50 ` [PATCH 1/2] pinctrl: ocelot: use a raw spinlock for the GPIO regmap Jens Emil Schulz Østergaard
2026-11-09 13:50 ` [PATCH 2/2] pinctrl: ocelot: do not use the chained irqchip behind a sleeping bus Jens Emil Schulz Østergaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261109-ocelot-pinctrl-irqchip-fixes-v1-0-9d2d8fcd58f5@microchip.com \
    --to=jensemil.schulzostergaard@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=bigeasy@linutronix.de \
    --cc=clrkwllms@kernel.org \
    --cc=colin.foster@in-advantage.com \
    --cc=horatiu.vultur@microchip.com \
    --cc=lee@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=rostedt@goodmis.org \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®