From: Gabor Juhos <j4g8y7@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Md Sadre Alam <md.alam@oss.qualcomm.com>,
Sricharan Ramabadhran <quic_srichara@quicinc.com>,
Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>,
linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, Gabor Juhos <j4g8y7@gmail.com>
Subject: [PATCH 7/7] spi: spi-qpic-snand: use the common 'qcom_nandc_read_stats' structure
Date: Mon, 09 Nov 2026 20:41:08 +0100 [thread overview]
Message-ID: <20261109-qpic-snand-use-common-functions-v1-7-1e8601e2db84@gmail.com> (raw)
In-Reply-To: <20261109-qpic-snand-use-common-functions-v1-0-1e8601e2db84@gmail.com>
The 'qcom_nandc_read_stats' structure defined in the 'nand-qpic-common.h'
header and the locally defined 'snandc_read_status' structure are
identical type wise and both are serving the same purpose.
Drop the local structure and use the global one instead to reduce
duplication.
No functional changes.
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
---
drivers/spi/spi-qpic-snand.c | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/spi/spi-qpic-snand.c b/drivers/spi/spi-qpic-snand.c
index 4105a04afcdb..6c5878f3f8b6 100644
--- a/drivers/spi/spi-qpic-snand.c
+++ b/drivers/spi/spi-qpic-snand.c
@@ -64,12 +64,6 @@
#define BAD_BLOCK_MARKER_SIZE 0x2
#define OOB_BUF_SIZE 128
-struct snandc_read_status {
- __le32 snandc_flash;
- __le32 snandc_buffer;
- __le32 snandc_erased_cw;
-};
-
/*
* ECC state struct
* @corrected: ECC corrected
@@ -610,7 +604,7 @@ static int qcom_spi_read_last_cw(struct qcom_nand_controller *snandc,
static int qcom_spi_check_error(struct qcom_nand_controller *snandc)
{
- struct snandc_read_status *buf;
+ struct qcom_nandc_read_stats *buf;
struct qpic_ecc *ecc_cfg = snandc->qspi->ecc;
int i, num_cw = snandc->qspi->num_cw;
bool flash_op_err = false, erased;
@@ -621,14 +615,14 @@ static int qcom_spi_check_error(struct qcom_nand_controller *snandc)
snandc->qspi->ecc_stats.corrected = 0;
qcom_nandc_dev_to_mem(snandc, true);
- buf = (struct snandc_read_status *)snandc->reg_read_buf;
+ buf = (struct qcom_nandc_read_stats *)snandc->reg_read_buf;
for (i = 0; i < num_cw; i++, buf++) {
u32 flash, buffer, erased_cw;
- flash = le32_to_cpu(buf->snandc_flash);
- buffer = le32_to_cpu(buf->snandc_buffer);
- erased_cw = le32_to_cpu(buf->snandc_erased_cw);
+ flash = le32_to_cpu(buf->flash);
+ buffer = le32_to_cpu(buf->buffer);
+ erased_cw = le32_to_cpu(buf->erased_cw);
if ((flash & FS_OP_ERR) && (buffer & BS_UNCORRECTABLE_BIT)) {
if (ecc_cfg->bch_enabled)
--
2.56.0
next prev parent reply other threads:[~2026-11-09 19:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 19:41 [PATCH 0/7] spi: spi-qpic-snand: use generic code from the 'qpic_common' module Gabor Juhos
2026-11-09 19:41 ` [PATCH 1/7] spi: spi-qpic-snand: use the common qcom_nandc_check_flash_errors() function Gabor Juhos
2026-11-09 19:41 ` [PATCH 2/7] spi: spi-qpic-snand: use the common qcom_nandc_config_page_read() function Gabor Juhos
2026-11-09 19:41 ` [PATCH 3/7] spi: spi-qpic-snand: use the common qcom_nandc_config_page_write() function Gabor Juhos
2026-11-09 19:41 ` [PATCH 4/7] spi: spi-qpic-snand: use the common qcom_nandc_config_cw_write() function Gabor Juhos
2026-11-09 19:41 ` [PATCH 5/7] spi: spi-qpic-snand: use the common qcom_nandc_set_read_loc_first() function Gabor Juhos
2026-11-09 19:41 ` [PATCH 6/7] spi: spi-qpic-snand: use the common qcom_nandc_set_read_loc_last() function Gabor Juhos
2026-11-09 19:41 ` Gabor Juhos [this message]
2026-11-10 18:46 ` [PATCH 0/7] spi: spi-qpic-snand: use generic code from the 'qpic_common' module Mark Brown
2026-11-10 21:18 ` Gabor Juhos
2026-11-10 23:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261109-qpic-snand-use-common-functions-v1-7-1e8601e2db84@gmail.com \
--to=j4g8y7@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=md.alam@oss.qualcomm.com \
--cc=quic_srichara@quicinc.com \
--cc=varadarajan.narayanan@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®