From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.123 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794193045; b=rsbMPvqVvtUu6owqq+ZpdpcjTjVqj3VIHreCdxN9vxQDq+L05dK6QvCmb1PIdnak1q5T Gub4Z2UXDhv6pUHRGsb/iTOG31GbOtFJxKl8X1DGuCp8eWoP7J/iexsisUwCYrGljYwMP iCz2gbz4ux/Zc2Nm5RAclfs5q33Z7FnO6SkfEONLa/0P2SFB01sRVrB6hj67UTddin55t 0hWtedBL1qzBlEDbOjn9tChdA0jK53XrZZAvZzlPzeQ/Zegdi1iatzPRY0Xnc1KtBstVT XOcypcgl2WKTIGDkHn/Z4fynQYuoMBHIruXMz3gRybyoaqFjpKQmAfkOW9oT8XKHrWw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794193045; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:From:To:Cc:Subject:Date:Message-ID: X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=slSez8APteyrjAQFVPi36IPS8gsYJrd9o7OEPdbfuX0=; b=NXeAynjDNZDwoHUlXWHzeahUKiES10XQKxLubR/x1JCRspZsDcDUe5d2grLx1fTWnZdz xsHDdIdvEk6uQmauIsqe6MTAGMSieC1F11GNQ51Bu87r8hMR++I94a4hR0NarmLMG+Sck BpGpaZeQx3sitpvBQnmutVrrLVemHRNglAjiRy0YvImJ5ZcqbN7qAgqpDjFDYNeTH9f4w mIQrcNMhOXb5fL/al7NGqm7tsxCKM23dLxINHmH/5lm6S9cPAs+y8E2a5Q9kN1ZBYuZVV Khp+bt2MaTpzOulw1BCHQ9g4HLmpFxZnjnx9Ti++hbZV4TuPzaaw6OoD4v/tiZIXwFg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=UVo4mFcv; arc=none smtp.remote-ip=91.218.175.123 Received: from mta0.migadu.com (out-123.mta0.migadu.com [91.218.175.123]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84778606A31C for ; Mon, 9 Nov 2026 02:57:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 84778606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=UVo4mFcv X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=3ZW9WdZ2Gaii+5kPjGa0iMjjl+g4WUyJikDdM5XjZ10=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794193042; v=1; x=1794797842; b=UVo4mFcv9Q4H2cIE2qz310LcnD++QCHbOylIue1Vs0G6jgrLPp+xVvhGyNgSeXOl0pvzHqg3 4fg7KzseuvrVEmjug3M7XgifnRXdeQ6dywNlzXN2u4Lvyv6LkO3SrcfLrs+JsCsbOeVx0MpIa2W gfPb8wsrXh3AUd5fkgs3vTKc= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id e7634fc4ade2e7d9; Mon, 09 Nov 2026 02:57:22 +0000 X-Mizu-Trace-ID: e7634fc4ade2e7d9 X-Migadu-Flow: FLOW_OUT From: Jiayuan Chen To: netdev@vger.kernel.org Cc: Jiayuan Chen , David Ahern , Ido Schimmel , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Pablo Neira Ayuso , Florian Westphal , Phil Sutter , Nikolay Aleksandrov , Paul Moore , Matthieu Baerts , Mat Martineau , Geliang Tang , Julian Anastasov , Allison Henderson , Marcelo Ricardo Leitner , Xin Long , "D. Wythe" , Dust Li , Sidraya Jayagond , Mahanta Jambigi , Tony Lu , Wen Gu , linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, bridge@lists.linux.dev, linux-security-module@vger.kernel.org, mptcp@lists.linux.dev, lvs-devel@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-sctp@vger.kernel.org, linux-s390@vger.kernel.org Subject: [PATCH net-next 05/14] calipso: annotate data-races around cache sysctls Date: Mon, 9 Nov 2026 10:52:04 +0800 Message-ID: <20261109025425.328445-6-jiayuan.chen@linux.dev> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261109025425.328445-1-jiayuan.chen@linux.dev> References: <20261109025425.328445-1-jiayuan.chen@linux.dev> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit calipso_cache_enabled and calipso_cache_bucketsize are read without any lock while their sysctl handlers update them with WRITE_ONCE(). Add READ_ONCE() to the readers. Signed-off-by: Jiayuan Chen --- net/ipv6/calipso.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/ipv6/calipso.c b/net/ipv6/calipso.c index e399a42e30839..5e63212b60163 100644 --- a/net/ipv6/calipso.c +++ b/net/ipv6/calipso.c @@ -204,7 +204,7 @@ static int calipso_cache_check(const unsigned char *key, struct calipso_map_cache_entry *prev_entry = NULL; u32 hash; - if (!calipso_cache_enabled) + if (!READ_ONCE(calipso_cache_enabled)) return -ENOENT; hash = calipso_map_cache_hash(key, key_len); @@ -269,7 +269,7 @@ static int calipso_cache_add(const unsigned char *calipso_ptr, struct calipso_map_cache_entry *old_entry = NULL; u32 calipso_ptr_len; - if (!calipso_cache_enabled || calipso_cache_bucketsize <= 0) + if (!READ_ONCE(calipso_cache_enabled) || READ_ONCE(calipso_cache_bucketsize) <= 0) return 0; calipso_ptr_len = calipso_ptr[1]; @@ -289,7 +289,7 @@ static int calipso_cache_add(const unsigned char *calipso_ptr, bkt = entry->hash & (CALIPSO_CACHE_BUCKETS - 1); spin_lock_bh(&calipso_cache[bkt].lock); - if (calipso_cache[bkt].size < calipso_cache_bucketsize) { + if (calipso_cache[bkt].size < READ_ONCE(calipso_cache_bucketsize)) { list_add(&entry->list, &calipso_cache[bkt].list); calipso_cache[bkt].size += 1; } else { -- 2.43.0