mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	Song Qiang <songqiang1304521@gmail.com>,
	Radu Sabau <radu.sabau@analog.com>,
	Maxwell Doose <maxwell@maxwelld.cc>,
	Tomasz Duszynski <tduszyns@gmail.com>,
	Erikas Bitovtas <xerikasxx@gmail.com>,
	Waqar Hameed <waqar.hameed@axis.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-kernel@vger.kernel.org,
	"Jonathan Cameron" <jonathan.cameron@oss.qualcomm.com>
Subject: [RESEND PATCH 10/14] iio: chemical: scd30: poll own trigger from interrupt handler
Date: Mon,  9 Nov 2026 04:28:47 +0000	[thread overview]
Message-ID: <20261109042851.1326940-11-jic23@kernel.org> (raw)
In-Reply-To: <20261109042851.1326940-1-jic23@kernel.org>

From: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>

Keep a pointer to the driver's trigger in struct scd30_state and poll
that from scd30_irq_handler() rather than indio_dev->trig. With the
buffer enabled, the interrupt is only enabled by the trigger's
set_trigger_state() callback, so it is the driver's own trigger that is
in use.

This removes a dependency on the trig field of struct iio_dev, which
is to become private to the IIO core.

Signed-off-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
---
 drivers/iio/chemical/scd30.h      | 2 ++
 drivers/iio/chemical/scd30_core.c | 4 +++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/chemical/scd30.h b/drivers/iio/chemical/scd30.h
index 1ac9f3f79271..bdec5cf62a26 100644
--- a/drivers/iio/chemical/scd30.h
+++ b/drivers/iio/chemical/scd30.h
@@ -9,6 +9,7 @@
 #include <linux/regulator/consumer.h>
 #include <linux/types.h>
 
+struct iio_trigger;
 struct scd30_state;
 
 enum scd30_cmd {
@@ -57,6 +58,7 @@ struct scd30_state {
 	 */
 	void *priv;
 	int irq;
+	struct iio_trigger *trig;
 	/*
 	 * no way to retrieve current ambient pressure compensation value from
 	 * the sensor so keep one around
diff --git a/drivers/iio/chemical/scd30_core.c b/drivers/iio/chemical/scd30_core.c
index 770571c21521..ca824436f60e 100644
--- a/drivers/iio/chemical/scd30_core.c
+++ b/drivers/iio/chemical/scd30_core.c
@@ -573,9 +573,10 @@ static void scd30_disable_regulator(void *data)
 static irqreturn_t scd30_irq_handler(int irq, void *priv)
 {
 	struct iio_dev *indio_dev = priv;
+	struct scd30_state *state = iio_priv(indio_dev);
 
 	if (iio_buffer_enabled(indio_dev)) {
-		iio_trigger_poll(indio_dev->trig);
+		iio_trigger_poll(state->trig);
 
 		return IRQ_HANDLED;
 	}
@@ -666,6 +667,7 @@ static int scd30_setup_trigger(struct iio_dev *indio_dev)
 	if (!trig)
 		return -ENOMEM;
 
+	state->trig = trig;
 	trig->ops = &scd30_trigger_ops;
 	iio_trigger_set_drvdata(trig, indio_dev);
 
-- 
2.56.0


  parent reply	other threads:[~2026-11-09  4:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09  4:28 [RESEND PATCH 00/14] IIO: Ensure iio_trigger_poll() is of the device owned trigger Jonathan Cameron
2026-11-09  4:28 ` [RESEND PATCH 01/14] iio: accel: mma8452: unregister own trigger rather than current one Jonathan Cameron
2026-11-09  4:28 ` [RESEND PATCH 02/14] iio: accel: mma8452: poll own trigger from interrupt handler Jonathan Cameron
2026-11-09  4:28 ` [RESEND PATCH 03/14] iio: adc: max1027: " Jonathan Cameron
2026-11-09  4:28 ` [RESEND PATCH 04/14] iio: adc: ti-ads1119: " Jonathan Cameron
2026-11-09  4:28 ` [RESEND PATCH 05/14] iio: adc: mxs-lradc-adc: " Jonathan Cameron
2026-11-09  4:28 ` [RESEND PATCH 06/14] iio: adc: at91-sama5d2: poll own trigger on data ready interrupt Jonathan Cameron
2026-11-09  4:28 ` [RESEND PATCH 07/14] iio: light: vl6180: poll own trigger from interrupt handler Jonathan Cameron
2026-11-09  4:28 ` [RESEND PATCH 08/14] iio: proximity: vl53l0x-i2c: " Jonathan Cameron
2026-11-09  4:28 ` [RESEND PATCH 09/14] iio: adc: ad4691: " Jonathan Cameron
2026-11-09  4:28 ` Jonathan Cameron [this message]
2026-11-09  4:28 ` [RESEND PATCH 13/14] iio: light: vcnl4000: " Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261109042851.1326940-11-jic23@kernel.org \
    --to=jic23@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andy@kernel.org \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=dlechner@baylibre.com \
    --cc=jonathan.cameron@oss.qualcomm.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxwell@maxwelld.cc \
    --cc=miquel.raynal@bootlin.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=nuno.sa@analog.com \
    --cc=radu.sabau@analog.com \
    --cc=songqiang1304521@gmail.com \
    --cc=tduszyns@gmail.com \
    --cc=waqar.hameed@axis.com \
    --cc=xerikasxx@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®