From: kmahammadraf <kmahammadraf@marvell.com>
To: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Cc: Sunil Goutham <sgoutham@marvell.com>,
Ratheesh Kannoth <rkannoth@marvell.com>,
Geetha sowjanya <gakula@marvell.com>,
"Subbaraya Sundeep" <sbhatta@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Aditya Thapliyal <athapliyal@marvell.com>,
kmahammadraf <kmahammadraf@marvell.com>
Subject: [PATCH net] octeontx2-af: Fix keep PF_FUNC match for AF TX rules in rep mode
Date: Mon, 9 Nov 2026 10:50:43 +0000 [thread overview]
Message-ID: <20261109105043.1986921-1-kmahammadraf@marvell.com> (raw)
From: Aditya Thapliyal <athapliyal@marvell.com>
In representor mode, AF installs TX MCAM rules for representor traffic.
These TX rules must match on PF_FUNC to identify the correct target
function.
Currently, npc_update_tx_entry() clears PF_FUNC mask for AF-requested
rules. In rep_mode, that wildcard can make a TX rule match traffic for
other representors on the same TX interface, which can steer egress
traffic through the wrong rule.
Fix this by not clearing PF_FUNC mask for AF-installed TX rules when
rep_mode is enabled.
Fixes: 683645a2317e ("octeontx2-af: Add packet path between representor and VF")
Signed-off-by: kmahammadraf <kmahammadraf@marvell.com>
Signed-off-by: Aditya Thapliyal <athapliyal@marvell.com>
---
v2: https://lore.kernel.org/netdev/179292714974.3134.12015701378835588497@kernel.org/
-Drop the channel-handling change from this patch.
-Keep this patch focused on PF_FUNC mask handling in representor mode.
-Clarify the representor TX symptom in the commit message.
---
drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
index ec004ea5154c..4afd4a10cd64 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c
@@ -1396,7 +1396,7 @@ static int npc_update_tx_entry(struct rvu *rvu, struct rvu_pfvf *pfvf,
/* If AF is installing then do not care about
* PF_FUNC in Send Descriptor
*/
- if (is_pffunc_af(req->hdr.pcifunc))
+ if (is_pffunc_af(req->hdr.pcifunc) && !rvu->rep_mode)
mask = 0;
npc_update_entry(rvu, NPC_PF_FUNC, mdata, (__force u16)htons(target),
--
2.25.1
next reply other threads:[~2026-11-09 10:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 10:50 kmahammadraf [this message]
2026-11-09 10:55 ` netdev-bot+sinfo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261109105043.1986921-1-kmahammadraf@marvell.com \
--to=kmahammadraf@marvell.com \
--cc=andrew+netdev@lunn.ch \
--cc=athapliyal@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=gakula@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®