mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: "D. Manresa" <dmanresa@gmail.com>,
	Hans de Goede <johannes.goede@oss.qualcomm.com>,
	Daniel Scally <dan.scally@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Fernando Rimoli <fernandorimoli11@gmail.com>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] media: ipu-bridge: don't reference the module image from software nodes
Date: Mon, 9 Nov 2026 14:31:32 +0200	[thread overview]
Message-ID: <20261109123132.GA921524@killaraus.ideasonboard.com> (raw)
In-Reply-To: <avGxxCtAsVYKFxSq@kekkonen.localdomain>

On Mon, Nov 09, 2026 at 01:43:00PM +0200, Sakari Ailus wrote:
> Hi D.,
> 
> On Sat, Oct 10, 2026 at 05:56:25PM +0200, D. Manresa wrote:
> > The software nodes the bridge registers are deliberately never
> > unregistered, so that a later rebind can reuse them. Nothing reachable
> > from them may therefore point into the module image, but two properties
> > still do: the "link-frequencies" values point at cfg->link_freqs in
> > ipu_supported_sensors[], and the "lens-focus" property name is a string
> > literal.
> > 
> > Both dangle once the module is unloaded. Re-probing sensor drivers then
> > read poisoned link frequencies from the surviving nodes and fail:
> > 
> >   ov5693: supported link freq 419200000 not found
> > 
> > Copy both into struct ipu_sensor, where the other property names and
> > values already live.
> > 
> > Assisted-by: LLM
> > Fixes: 803abec64ef9 ("media: ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver")
> > Fixes: 68b9bcc8a534 ("media: ipu3-cio2: Add support for instantiating i2c-clients for VCMs")
> > Signed-off-by: D. Manresa <dmanresa@gmail.com>
> 
> Could we have a real name here, please?

If you think this patch is important, just drop authorship completely.

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2026-11-09 12:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-10 15:56 [PATCH v4 0/2] media: ipu-bridge: survive module unload and reuse the software nodes on rebind D. Manresa
2026-10-10 15:56 ` [PATCH v4 1/2] media: ipu-bridge: don't reference the module image from software nodes D. Manresa
2026-10-25 15:44   ` Fernando Rimoli
2026-11-09 11:43   ` Sakari Ailus
2026-11-09 12:31     ` Laurent Pinchart [this message]
2026-10-10 15:56 ` [PATCH v4 2/2] media: ipu-bridge: reuse the software nodes on rebind D. Manresa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261109123132.GA921524@killaraus.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dan.scally@ideasonboard.com \
    --cc=dmanresa@gmail.com \
    --cc=fernandorimoli11@gmail.com \
    --cc=johannes.goede@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®