mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Joseph Qi <joseph.qi@linux.alibaba.com>
Cc: Heming Zhao <heming.zhao@suse.com>, Mark Fasheh <mark@fasheh.com>,
	Joel Becker <jlbec@evilplan.org>,
	ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 00/31] ocfs2: split dinode validation into shared predicates
Date: Mon, 9 Nov 2026 12:51:43 -0800	[thread overview]
Message-ID: <20261109125143.4e1428ced7368e1255394a5e@linux-foundation.org> (raw)
In-Reply-To: <20261109122121.21473-1-joseph.qi@linux.alibaba.com>

On Mon,  9 Nov 2026 20:20:50 +0800 Joseph Qi <joseph.qi@linux.alibaba.com> wrote:

> ocfs2_validate_inode_block() is a flat sequence of about twenty open-coded
> dinode checks.  The filecheck variant duplicates eight of them but reports
> differently: mlog() plus an OCFS2_FILECHECK_ERR_* code instead of
> ocfs2_error(), which can force the filesystem read-only.  The duplicated
> conditions had drifted apart, and filecheck silently skipped the rest.

Thanks. I'll add all this and feed it into linux-next.

Sashiko is almost happy, one thing which looks hard-to-hit.

	https://sashiko.dev/#/patchset/20261109122121.21473-1-joseph.qi@linux.alibaba.com

I'll hopefully feed all this into my LLM-driven live kernel testing
setup, which is pretty comprehensive.  First I need to address some
reliability issues then make it not take 48 hours for an "overnight"
testing job!


      parent reply	other threads:[~2026-11-09 20:51 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 12:20 Joseph Qi
2026-11-09 12:20 ` [PATCH v3 01/31] ocfs2: exempt orphaned dinodes from the zero nlink check Joseph Qi
2026-11-09 12:20 ` [PATCH v3 02/31] ocfs2: abstract the zero nlink or mode dinode check Joseph Qi
2026-11-09 12:20 ` [PATCH v3 03/31] ocfs2: abstract the dinode i_blkno mismatch check Joseph Qi
2026-11-09 12:20 ` [PATCH v3 04/31] ocfs2: abstract the dinode OCFS2_VALID_FL check Joseph Qi
2026-11-09 12:20 ` [PATCH v3 05/31] ocfs2: abstract the dinode fs_generation mismatch check Joseph Qi
2026-11-09 12:20 ` [PATCH v3 06/31] ocfs2: abstract the dinode suballoc slot checks Joseph Qi
2026-11-09 12:20 ` [PATCH v3 07/31] ocfs2: abstract the dinode suballoc bit check Joseph Qi
2026-11-09 12:20 ` [PATCH v3 08/31] ocfs2: abstract the dinode orphaned slot check Joseph Qi
2026-11-09 12:20 ` [PATCH v3 09/31] ocfs2: abstract the dinode DIO " Joseph Qi
2026-11-09 12:21 ` [PATCH v3 10/31] ocfs2: abstract the inline data dinode guard and cluster check Joseph Qi
2026-11-09 12:21 ` [PATCH v3 11/31] ocfs2: abstract the inline data id_count bound check Joseph Qi
2026-11-09 12:21 ` [PATCH v3 12/31] ocfs2: abstract the inline data i_size " Joseph Qi
2026-11-09 12:21 ` [PATCH v3 13/31] ocfs2: abstract the fast symlink dinode guard and size check Joseph Qi
2026-11-09 12:21 ` [PATCH v3 14/31] ocfs2: abstract the fast symlink NUL-termination check Joseph Qi
2026-11-09 12:21 ` [PATCH v3 15/31] ocfs2: abstract the chain list dinode guard and count check Joseph Qi
2026-11-09 12:21 ` [PATCH v3 16/31] ocfs2: abstract the chain list next free record check Joseph Qi
2026-11-09 12:21 ` [PATCH v3 17/31] ocfs2: abstract the chain list bits per cluster check Joseph Qi
2026-11-09 12:21 ` [PATCH v3 18/31] ocfs2: abstract the dinode refcount location check Joseph Qi
2026-11-09 12:21 ` [PATCH v3 19/31] ocfs2: abstract the zero extent list count check Joseph Qi
2026-11-09 12:21 ` [PATCH v3 20/31] ocfs2: abstract the oversized " Joseph Qi
2026-11-09 12:21 ` [PATCH v3 21/31] ocfs2: abstract the extent list next free record check Joseph Qi
2026-11-09 12:21 ` [PATCH v3 22/31] ocfs2: report unrepairable corruption from online filecheck fix Joseph Qi
2026-11-09 12:21 ` [PATCH v3 23/31] ocfs2: check dinode nlink and mode in online filecheck Joseph Qi
2026-11-09 12:21 ` [PATCH v3 24/31] ocfs2: check dinode suballoc slot " Joseph Qi
2026-11-09 12:21 ` [PATCH v3 25/31] ocfs2: check dinode suballoc bit " Joseph Qi
2026-11-09 12:21 ` [PATCH v3 26/31] ocfs2: check dinode orphaned slots " Joseph Qi
2026-11-09 12:21 ` [PATCH v3 27/31] ocfs2: check inline data dinodes " Joseph Qi
2026-11-09 12:21 ` [PATCH v3 28/31] ocfs2: check fast symlink " Joseph Qi
2026-11-09 12:21 ` [PATCH v3 29/31] ocfs2: check chain list " Joseph Qi
2026-11-09 12:21 ` [PATCH v3 30/31] ocfs2: check dinode refcount location " Joseph Qi
2026-11-09 12:21 ` [PATCH v3 31/31] ocfs2: check extent list dinodes " Joseph Qi
2026-11-09 20:51 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261109125143.4e1428ced7368e1255394a5e@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=heming.zhao@suse.com \
    --cc=jlbec@evilplan.org \
    --cc=joseph.qi@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark@fasheh.com \
    --cc=ocfs2-devel@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®