From: Sergey Lebedev <lsa.uz@pm.me>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Benjamin Mugnier <benjamin.mugnier@foss.st.com>,
Sylvain Petinot <sylvain.petinot@foss.st.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Dan Scally <dan.scally@ideasonboard.com>,
Hans de Goede <hansg@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Peter Marshall <pm@petermarshall.ca>,
George Neacsu <geocausa@gmail.com>, Hao Yao <hao.yao@intel.com>,
Fernando Rimoli <fernandorimoli11@gmail.com>,
"D. Manresa" <dmanresa@gmail.com>, Jizhou Tong <fqwqf@fqwqf.xyz>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] media: i2c: Add ST VD55G0 global shutter sensor driver
Date: Mon, 09 Nov 2026 13:27:53 +0000 [thread overview]
Message-ID: <20261109132746.22125-1-lsa.uz@pm.me> (raw)
In-Reply-To: <avHDwGAe99WYaty9@kekkonen.localdomain>
Hi Sakari,
On Mon, Nov 09, 2026 at 02:59:44PM +0200, Sakari Ailus wrote:
>> >> +static const s64 vd55g0_ev_bias_menu[] = {
>> >> + -3000, -2500, -2000, -1500, -1000, -500,
>> >> + 0,
>> >> + 500, 1000, 1500, 2000, 2500, 3000,
>> >
>> > Is this
>>
>> The sentence seems to have been cut off here. What did you mean? The
>> table is vd55g1's, in the control's 0.001 EV units.
>
> Uh, yes. I meant to ask if this is a firmware limitation. I guess so?
No, it is the driver's. The firmware has both a target and a
compensation register (UM2829, 14.7.3, Table 39 [1]):
AE_COMPENSATION VALUE 15:0 SFP 8.8 Compensation in EV
AE_TARGET_PERCENTAGE VALUE 15:0 UI Percentage relative to saturation
where "100 means saturated image". The driver writes the target from
this table, 27 * 2^EV, as vd55g1 does:
static const unsigned int index2exposure_target[] = {
3, 5, 7, 10, 14, 19, 27, 38, 54, 76, 108, 153, 216,
};
So +2.5 and +3 EV ask for 153 and 216, above saturation; I have not
tested what the AE does there.
v4 keeps vd55g1's table, unless you or Benjamin prefer the compensation
register.
[1] https://www.st.com/resource/en/user_manual/um2829-how-to-integrate-and-configure-the-vd55g0-device-from-a-hardware-and-software-perspective-stmicroelectronics.pdf
Sergey
next prev parent reply other threads:[~2026-11-09 13:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 9:34 [PATCH v3 0/4] media: Add the ST VD55G0 global shutter sensor Sergey Lebedev
2026-11-09 9:34 ` [PATCH v3 1/4] dt-bindings: media: i2c: st,vd55g1: Add ST VD55G0 Sergey Lebedev
2026-11-09 10:28 ` Benjamin Mugnier
2026-11-09 10:36 ` Sergey Lebedev
2026-11-10 11:34 ` Krzysztof Kozlowski
2026-11-10 11:33 ` Krzysztof Kozlowski
2026-11-09 9:34 ` [PATCH v3 2/4] media: i2c: Add ST VD55G0 global shutter sensor driver Sergey Lebedev
2026-11-09 11:36 ` Sakari Ailus
2026-11-09 12:46 ` Sergey Lebedev
2026-11-09 12:59 ` Sakari Ailus
2026-11-09 13:27 ` Sergey Lebedev [this message]
2026-11-10 9:46 ` Benjamin Mugnier
2026-11-09 9:34 ` [PATCH v3 3/4] media: ipu-bridge: Add ST VD55G0 Sergey Lebedev
2026-11-09 9:34 ` [PATCH v3 4/4] media: ipu-bridge: Add the Surface Pro 9 and 11 infrared illuminator Sergey Lebedev
2026-11-09 11:39 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261109132746.22125-1-lsa.uz@pm.me \
--to=lsa.uz@pm.me \
--cc=benjamin.mugnier@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=dmanresa@gmail.com \
--cc=fernandorimoli11@gmail.com \
--cc=fqwqf@fqwqf.xyz \
--cc=geocausa@gmail.com \
--cc=hansg@kernel.org \
--cc=hao.yao@intel.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=pm@petermarshall.ca \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sylvain.petinot@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®