From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794261705; b=H0n0gv8mCcWLslxrDqdKOfoTTVZjEg+fcmE3fWs65Tg5nRUsAPjYvhooDER2Cy/nu5sk pIuJcMZHRbH28q0s/k2gjfvMLu4bPewov7H6ovlVDPD+akhoAHdgKg6znlkA5M7B7TtA9 QvMCYF5pSoF53J/hPzU0z6kStbwOi/FoGdP5ntSKVe0YiouEPT0sFusAS9xfo1coHqCOY Xgq6cF9CV1iHkkYaSEGVFAjR2FjY6EUnqm+nwNbUZxj162vJ0/TkScgBGtSLJMqjQvnX+ 6WK7IpEoHvftW44RSMBD9l1WFsvvwQ6EjIhuHfMpRJ/kSInwh2K4XWPTyczawuEtAqw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794261705; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Gm-Message-State:X-Gm-Gg: X-Received:X-Received:Received:Date:From:To:Cc:Subject:Message-ID: In-Reply-To:References:Organization:X-Mailer:MIME-Version: Content-Type:Content-Transfer-Encoding:X-Proofpoint-Spam-Info: X-Proofpoint-GUID:X-Proofpoint-ORIG-GUID: X-Proofpoint-Spam-Details-Enc:X-Authority-Analysis: X-Proofpoint-Virus-Version:X-Proofpoint-Spam-Details; bh=f/U5uro6b/Mumfr/eDH65lCVfbkZfC9WhsiSfQqom5U=; b=fseW3NiLXZvWLqUyz1ueLSLNKrn2fGtQ6Ba2dlPRLVlgZM8ZEaRyPrkE5QBSgZerq0R5 3WsZtyk1ag83HQfkS6qkxBMPw3GRLkKIocaQwJBijCdNzrFtQRClogLlJMprNlo/KDYMJ eUv0Dd+wK/NoY14NAqUET8ay0RME5R4dsJPpRdqQs/E4B6TbiyYI+AXyFWC0A26vr9a6I qBJ4B7C1ii0h7WX/bjNhNeRJ7BPTD8go79Z5LUKbDEpNWkcQoGrT2E7iR5VnWZ0mlrwRD T03GJNHCkkyQZRznuxCTzOL5OB38jRRsJYRHjHBOmAY3dj9ruNM3uHVaDftBw2w2dEg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=e7I9DGRY; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b="h8rrC24/"; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CD79606A31C for ; Mon, 9 Nov 2026 22:01:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 5CD79606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=e7I9DGRY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=h8rrC24/ Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6A9LAJbE1062289 for ; Mon, 9 Nov 2026 22:01:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= f/U5uro6b/Mumfr/eDH65lCVfbkZfC9WhsiSfQqom5U=; b=e7I9DGRYOGMiGoH/ 9ZoE29LUbkorsFvZdOvL+TFcpTgfHORVobuEWk8PJboxsm+F8FvRZETRWPJ4cbVK GUVRv75INA5Iaq/X7r1Xzf6dJRWOo9+iBHur3dSZZas9h9UER+SReUXSWZ8Hr78q KtOSrqyXX4pK8SeVyCc81nDoW1zf29dGDIVRLQuGotPphEf3EEPxLOyA5S+3HUyn M12UZx7KDkpAErIIRLsrsH2ntnuxiEAE9bKaiy0HqEeM+ncFOy7/UQhSmviQJCeO PysqGDgM7FymmEUVNObbm2pGUmVg5WrmxiYG/aMpAQGJec6AE8vg+3c+e0Gwq3P8 ZjaCig== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hucydjbnh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Nov 2026 22:01:43 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-341eff9e381so3227824eec.1 for ; Mon, 09 Nov 2026 14:01:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1794261702; x=1794866502; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=f/U5uro6b/Mumfr/eDH65lCVfbkZfC9WhsiSfQqom5U=; b=h8rrC24/Jk3XFZ9fnclCxBB80fVCabImtkDuqauSxM1hUhaAA9eHf41EPZaZLieNYv ew25GWNCuyynoO/JurLVxPESl+zOyx+1S+UoyYGcx4pbY6yHLhHVNRM3YyJvEQR8X5E3 bDZRebq0OGsL8np4uJ+XuFifrCgPflSd06X6ok5yGCv8FJ0r60w2jLy9l0r4ujiye6si w6YstoZ9WH5u9WVd0aaNm1SprrLgFhdLkTj+xLIWc+zYmdPgP4UIbXqlvc+nhJLo58si bSmeyAN97qFxdWb+e7DzS7an+DADr6FG2Yn6r0IvntaMPIFwTSId8/6thCFzwGeWBn0r caGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794261702; x=1794866502; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=f/U5uro6b/Mumfr/eDH65lCVfbkZfC9WhsiSfQqom5U=; b=uBh5B1PorjmdCyrqnvamITZhMk/tF/O/5Vsmxw/W1LV8Zr5SqTxAWKVTsG78C3w8lm D/xqK+5tIA8MlVKKC433iBi4Q8otaJl2f7WfzpHQIBSKb8pgtFWM2FP3XGp/+6gPanFF FEQx5hA4kKzt8mRnACVAkvy9zMdz5amsKN1I1wcrp53++F7sPjUbupNFbkOxUYRyt/R8 gQ/t0AEQxhe5pEq3K1cJ3YJWZDrs7Y/3Qp0Fph6ekv0F/dvqT7Bi5kwdaGKBPnq1Ydru slBwvp0YKpu7Zk3mmb+CsQ68zvcQg9RKx4ImO4ydOnailG8KNuORp/MDD4TPCjxM49yW CU+Q== X-Gm-Message-State: APuU4Z9RtOKe6kLd9VpZdxoOgox0+M0KoOoiGjNysBQuTTB2CJVseMQE V7PcEQxkVRDFT0XxP+5dAcsIG7EO9R6hoGHKB1S1gsfIFtAOSNhQxQ3x81Kgvnms7fZ+cRnDwsq QGru3a2m4G5B1Zrtcy4FgPR4RTWW4W3IW71J2cxcIc4RAaw5AWeyMJt5MBgikEy6WphY= X-Gm-Gg: AYBFou0VJ5QdfXVjlcOglojxwMmGA4JPslAwG2imPJ6jIzCugRxHNWAoS4E+SMqTvTf qSoS9eaObivUobMdCfr/Pl44SeKR+PgloVwbx0wR6Xi9hQUcj1Y0403Y4kXxaDY6+lhdnixRYfA 0+dlfOUS2GAEIge7e2dDr73kanW7Z+8qcw5MtYtGsbek0HrDShscO0SfmJeZjybu60nuuVh7BZx osdLIfH4KlkkExjH06SPRwJhFWL4AhvNxnhfrHg5OL+QML2S+kqUgwmnwo9jW0V0cXGBUbZ2WCN PumJuAoFaPvdGo/041jJjlM4Mk1ZB9PGPuNcTuR15Z1WCmdu1/DKXuwpIDbTkIVhhOUjdkoK78v LO+nXylY4Qr+MUUzA/zeaa6aUbcSy27Umupb+dddpe+OAW41EObBSomaS58ra1xJU7TEPlISYCU t5Ngld2J6NtSnjxQooNJyc9H0iuA== X-Received: by 2002:a05:693c:6007:b0:36a:1008:5815 with SMTP id 5a478bee46e88-3751c82f248mr762511eec.5.1794261701759; Mon, 09 Nov 2026 14:01:41 -0800 (PST) X-Received: by 2002:a05:693c:6007:b0:36a:1008:5815 with SMTP id 5a478bee46e88-3751c82f248mr762424eec.5.1794261700734; Mon, 09 Nov 2026 14:01:40 -0800 (PST) Received: from localhost (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3751dae6377sm1118577eec.3.2026.11.09.14.01.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2026 14:01:40 -0800 (PST) Date: Mon, 9 Nov 2026 14:01:29 -0800 From: Jonathan Cameron To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, linux-doc@vger.kernel.org, sudeep.holla@kernel.org, james.quinlan@broadcom.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, etienne.carriere@st.com, peng.fan@oss.nxp.com, michal.simek@amd.com, d-gole@ti.com, elif.topuz@arm.com, lukasz.luba@arm.com, philip.radford@arm.com, david@kernel.org, souvik.chakravarty@arm.com, leitao@kernel.org, kas@kernel.org, puranjay@kernel.org, usama.arif@linux.dev, kernel-team@meta.com Subject: Re: [PATCH v15 03/35] firmware: arm_scmi: Introduce a dedicated SCMI Errors header Message-ID: <20261109140129.00004b4f@oss.qualcomm.com> In-Reply-To: <20261109091221.2532706-4-cristian.marussi@arm.com> References: <20261109091221.2532706-1-cristian.marussi@arm.com> <20261109091221.2532706-4-cristian.marussi@arm.com> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYxMTA5MDA4NyBTYWx0ZWRfX74UvwtyA0FOm /LKJykZDwg89W8O+b+Ynq2gyLenb/HWbOohejxeaePD9hzxMyf1LIVHM/e8qZcxC4nd5k/V7Z5A EG0sMLJ65zmjBmdto9T/3//CmXvmJqg= X-Proofpoint-GUID: QJ3UrHhVyI7UwvQ975YRuCEukHTneCw0 X-Proofpoint-ORIG-GUID: QJ3UrHhVyI7UwvQ975YRuCEukHTneCw0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTA5MDA4NyBTYWx0ZWRfX89HmJtvVI06l V6C8ZWEvpWWfBsmF3BIyoDbTh78yhAwG37tj9J2yQOAbCSXPJY6tMaihiTMVl/Z+nXYKAVLL28T Q2SbG2tCZ8dSkcRH8p35OvM6CW3hmAcDqusybYJGkC3MW3kw9h03Ul8N0nnZe7jbXEZeqjAL3Fu gvcycBENfGpovlPrjp78We0frEU9ohPpgHdA0ibfnnCTtNJx3neqtFgr+idwp4OnVgf98d3yJG2 wXu6eUqlTaQ6hfoLWP1cVw3kpriPoUBKvFPa3GnOEtOfekEwS83M8AtzxCplQ5YhmpZlDjRgBhv 2Et2B612ytkpT1wOYndjKtLf0VWy/h7ZurNB0ZeucvJyFz01jFSrhMk3f1CihWVXzU2b8BSHQU3 lTwGlQwpPmS+vLG7+LCRSRYj++6Qu6XAeqA9trFMrMjhX6dCTpepYQ3ztjTx0QCEY33IHjy3Uqe C2iim49+Ujw/q42HTgA== X-Authority-Analysis: v=2.4 cv=XuRvqlF9 c=1 sm=1 tr=0 ts=6af242c7 cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=kj9zAlcOel0A:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=7CQSdrXTAAAA:8 a=EUspDBNiAAAA:8 a=1uBkIsMKrF2EJPe0UmoA:9 a=CjuIK1q_8ugA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-09_07,2026-11-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 adultscore=0 suspectscore=0 impostorscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611090087 On Mon, 9 Nov 2026 09:11:49 +0000 Cristian Marussi wrote: > Add a new dedicated header and move all of the errors definitions and > mapping helpers into it and out of common.h so that SCMI errors definitions > alone can be easily included in protocol files without all of the unrelated > additional stuff contained in common.h In ideal world I'd move first and add the new codes later. (so swap this and previous patch). Trivial thing but reduce the patch size a tiny bit! Other than that, seems like there are enough of these for a separate header to perhaps make sense. Reviewed-by: Jonathan Cameron > > Signed-off-by: Cristian Marussi > --- > drivers/firmware/arm_scmi/common.h | 43 +---------------------- > drivers/firmware/arm_scmi/errors.h | 56 ++++++++++++++++++++++++++++++ > 2 files changed, 57 insertions(+), 42 deletions(-) > create mode 100644 drivers/firmware/arm_scmi/errors.h > > diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h > index e3390686fc58..cdd6f887fae7 100644 > --- a/drivers/firmware/arm_scmi/common.h > +++ b/drivers/firmware/arm_scmi/common.h > @@ -26,6 +26,7 @@ > > #include > > +#include "errors.h" > #include "protocols.h" > #include "notify.h" > > @@ -37,48 +38,6 @@ > > #define SCMI_TRANSPORT_DEVNAME_PREFIX "__scmi_transport_device" > > -enum scmi_error_codes { > - SCMI_SUCCESS = 0, /* Success */ > - SCMI_ERR_SUPPORT = -1, /* Not supported */ > - SCMI_ERR_PARAMS = -2, /* Invalid Parameters */ > - SCMI_ERR_ACCESS = -3, /* Invalid access/permission denied */ > - SCMI_ERR_ENTRY = -4, /* Not found */ > - SCMI_ERR_RANGE = -5, /* Value out of range */ > - SCMI_ERR_BUSY = -6, /* Device busy */ > - SCMI_ERR_COMMS = -7, /* Communication Error */ > - SCMI_ERR_GENERIC = -8, /* Generic Error */ > - SCMI_ERR_HARDWARE = -9, /* Hardware Error */ > - SCMI_ERR_PROTOCOL = -10,/* Protocol Error */ > - SCMI_ERR_IN_USE = -11, /* In Use Error */ > - SCMI_ERR_PARTIAL = -12, /* Partial Error */ > -}; > - > -static const int scmi_linux_errmap[] = { > - /* better than switch case as long as return value is continuous */ > - 0, /* SCMI_SUCCESS */ > - -EOPNOTSUPP, /* SCMI_ERR_SUPPORT */ > - -EINVAL, /* SCMI_ERR_PARAM */ > - -EACCES, /* SCMI_ERR_ACCESS */ > - -ENOENT, /* SCMI_ERR_ENTRY */ > - -ERANGE, /* SCMI_ERR_RANGE */ > - -EBUSY, /* SCMI_ERR_BUSY */ > - -ECOMM, /* SCMI_ERR_COMMS */ > - -EIO, /* SCMI_ERR_GENERIC */ > - -EREMOTEIO, /* SCMI_ERR_HARDWARE */ > - -EPROTO, /* SCMI_ERR_PROTOCOL */ > - -EBUSY, /* SCMI_ERR_IN_USE */ > - -EBADMSG, /* SCMI_ERR_PARTIAL */ > -}; > - > -static inline int scmi_to_linux_errno(int errno) > -{ > - int err_idx = -errno; > - > - if (err_idx >= SCMI_SUCCESS && err_idx < ARRAY_SIZE(scmi_linux_errmap)) > - return scmi_linux_errmap[err_idx]; > - return -EIO; > -} > - > #define MSG_ID_MASK GENMASK(7, 0) > #define MSG_XTRACT_ID(hdr) FIELD_GET(MSG_ID_MASK, (hdr)) > #define MSG_TYPE_MASK GENMASK(9, 8) > diff --git a/drivers/firmware/arm_scmi/errors.h b/drivers/firmware/arm_scmi/errors.h > new file mode 100644 > index 000000000000..707761cd8d34 > --- /dev/null > +++ b/drivers/firmware/arm_scmi/errors.h > @@ -0,0 +1,56 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * System Control and Management Interface (SCMI) Message Protocol > + * header containing SCMI errors definitions and Linux mapping. > + * > + * Copyright (C) 2018-2026 ARM Ltd. > + */ > +#ifndef _SCMI_ERRORS_H > +#define _SCMI_ERRORS_H > + > +#include > +#include > + > +enum scmi_error_codes { > + SCMI_SUCCESS = 0, /* Success */ > + SCMI_ERR_SUPPORT = -1, /* Not supported */ > + SCMI_ERR_PARAMS = -2, /* Invalid Parameters */ > + SCMI_ERR_ACCESS = -3, /* Invalid access/permission denied */ > + SCMI_ERR_ENTRY = -4, /* Not found */ > + SCMI_ERR_RANGE = -5, /* Value out of range */ > + SCMI_ERR_BUSY = -6, /* Device busy */ > + SCMI_ERR_COMMS = -7, /* Communication Error */ > + SCMI_ERR_GENERIC = -8, /* Generic Error */ > + SCMI_ERR_HARDWARE = -9, /* Hardware Error */ > + SCMI_ERR_PROTOCOL = -10,/* Protocol Error */ > + SCMI_ERR_IN_USE = -11, /* In Use Error */ > + SCMI_ERR_PARTIAL = -12, /* Partial Error */ > +}; > + > +static const int scmi_linux_errmap[] = { > + /* better than switch case as long as return value is continuous */ > + 0, /* SCMI_SUCCESS */ > + -EOPNOTSUPP, /* SCMI_ERR_SUPPORT */ > + -EINVAL, /* SCMI_ERR_PARAM */ > + -EACCES, /* SCMI_ERR_ACCESS */ > + -ENOENT, /* SCMI_ERR_ENTRY */ > + -ERANGE, /* SCMI_ERR_RANGE */ > + -EBUSY, /* SCMI_ERR_BUSY */ > + -ECOMM, /* SCMI_ERR_COMMS */ > + -EIO, /* SCMI_ERR_GENERIC */ > + -EREMOTEIO, /* SCMI_ERR_HARDWARE */ > + -EPROTO, /* SCMI_ERR_PROTOCOL */ > + -EBUSY, /* SCMI_ERR_IN_USE */ > + -EBADMSG, /* SCMI_ERR_PARTIAL */ > +}; > + > +static inline int scmi_to_linux_errno(int errno) > +{ > + int err_idx = -errno; > + > + if (err_idx >= SCMI_SUCCESS && err_idx < ARRAY_SIZE(scmi_linux_errmap)) > + return scmi_linux_errmap[err_idx]; > + return -EIO; > +} > + > +#endif /* _SCMI_ERRORS_H */