mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicolae-Daniel Deaconescu <Nicolae-daniel.Deaconescu@analog.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Uwe Kleine-König" <ukleinek@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Michael Hennerich" <michael.hennerich@analog.com>,
	"Trevor Gamblin" <tgamblin@baylibre.com>,
	"Joshua Crofts" <crofts@kernel.org>,
	"Sergiu Cuciurean" <sergiu.cuciurean@analog.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-pwm@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/7] iio: adc: ad7625: use standard unit names
Date: Mon, 9 Nov 2026 16:07:15 +0200	[thread overview]
Message-ID: <20261109140715.36796-1-Nicolae-daniel.Deaconescu@analog.com> (raw)
In-Reply-To: <20261107015531.32328dbb@jic23-hlaptop>

Hi Jonathan,

On Sat, 7 Nov 2026 01:55:31 +0000, Jonathan Cameron wrote:
>
> > Use standard unit spelling and macros in existing code:
> > - Rename vref_mv to vref_mV and ref_mv to ref_mV, spelling the voltage unit
> >   as mV.
>
> What about poor Heinrich Hertz?  If we are doing this let's acknowledge
> his contribution as well and use _Hz as the postfix for those.
>
> Also Volta isn't doing well in some of this.
>
> I'm generally in favour of this stuff but it is churn heavy to
> tidy up in existing code.  So my preference is keep these improvements
> for places where you are modifying the naming anyway or making lots
> of new use of an existing variable.

Fair. I'll drop this patch in v4 and leave the existing names alone. Hertz
keeps clk_rate_Hz in the new PWM struct.

>
> > @@ -517,7 +517,7 @@ static int devm_ad7625_regulator_setup(struct device *dev,
> >  				       struct ad7625_state *st)
> >  {
> >  
> > -	if (ref_mv == 5000 && !st->can_ref_5v)
> > +	if (ref_mV == 5000 && !st->can_ref_5v)
>
> Why is it 5v rather than 5V?

can_ref_5v (and can_ref_4v096) are from the original driver.

Thanks,
Daniel

  reply	other threads:[~2026-11-09 14:07 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06 16:05 [PATCH v3 0/7] iio: adc: ad7625: add LTC2387 and ADAQ2387x support Nicolae-Daniel Deaconescu
2026-11-06 16:05 ` [PATCH v3 1/7] pwm: core: add pwm_get_waveform_step_might_sleep() Nicolae-Daniel Deaconescu
2026-11-06 16:05 ` [PATCH v3 2/7] pwm: axi-pwmgen: report the waveform step Nicolae-Daniel Deaconescu
2026-11-07  1:47   ` Jonathan Cameron
2026-11-09 14:06     ` Nicolae-Daniel Deaconescu
2026-11-14 22:36       ` Jonathan Cameron
2026-11-06 16:05 ` [PATCH v3 3/7] iio: adc: ad7625: fix sampling frequency handling Nicolae-Daniel Deaconescu
2026-11-07  1:50   ` Jonathan Cameron
2026-11-09 14:06     ` Nicolae-Daniel Deaconescu
2026-11-06 16:05 ` [PATCH v3 4/7] iio: adc: ad7625: use standard unit names Nicolae-Daniel Deaconescu
2026-11-07  1:55   ` Jonathan Cameron
2026-11-09 14:07     ` Nicolae-Daniel Deaconescu [this message]
2026-11-06 16:05 ` [PATCH v3 5/7] iio: adc: ad7625: move initial mode setup Nicolae-Daniel Deaconescu
2026-11-07  1:59   ` Jonathan Cameron
2026-11-09 14:07     ` Nicolae-Daniel Deaconescu
2026-11-06 16:05 ` [PATCH v3 6/7] dt-bindings: iio: adc: add adi,ltc2387 Nicolae-Daniel Deaconescu
2026-11-06 17:04   ` Conor Dooley
2026-11-06 16:05 ` [PATCH v3 7/7] iio: adc: ad7625: add LTC2387 and ADAQ2387x support Nicolae-Daniel Deaconescu
2026-11-07  2:20   ` Jonathan Cameron
2026-11-09 14:07     ` Nicolae-Daniel Deaconescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261109140715.36796-1-Nicolae-daniel.Deaconescu@analog.com \
    --to=nicolae-daniel.deaconescu@analog.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=crofts@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=sergiu.cuciurean@analog.com \
    --cc=tgamblin@baylibre.com \
    --cc=ukleinek@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®