From: Arnav Kapoor <kapoorarnav43@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Gwendal Grignou" <gwendal@chromium.org>,
"Stephen Boyd" <swboyd@chromium.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Arnav Kapoor" <kapoorarnav43@gmail.com>
Subject: [PATCH v2 0/2] iio: proximity: sx9310/sx9360: reject out-of-range hardware gain values
Date: Mon, 9 Nov 2026 22:21:51 +0530 [thread overview]
Message-ID: <20261109165200.305266-1-kapoorarnav43@gmail.com> (raw)
sx9310_write_gain() and sx9360_write_gain() squeeze ilog2() of any
integer into the register field. Values that don't fit wrap around,
and 0 and negative values turn into the maximum code, while the write
reports success. Reject those. One patch per driver, as the Fixes tags
differ.
Changes in v2:
- Keep rounding values between the supported gains down, instead of
rejecting them, so the ABI doesn't change (Jonathan)
- Only reject values <= 0 and values that don't fit: FIELD_FIT() for
sx9310 (Jonathan); sx9360 checks against the gain of 8 code, as its
3-bit field also holds codes 4 to 7, which the driver doesn't support
v1: https://lore.kernel.org/all/20261107111710.442318-1-kapoorarnav43@gmail.com/
Compile-tested only (W=1); I don't have SX9310 or SX9360 hardware.
Arnav Kapoor (2):
iio: proximity: sx9310: reject out-of-range hardware gain values
iio: proximity: sx9360: reject out-of-range hardware gain values
drivers/iio/proximity/sx9310.c | 7 +++++++
drivers/iio/proximity/sx9360.c | 7 +++++++
2 files changed, 14 insertions(+)
base-commit: 340d44bdf9db0f095f99845b5ad8628781d79b6f
--
2.53.0
next reply other threads:[~2026-11-09 16:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 16:51 Arnav Kapoor [this message]
2026-11-09 16:51 ` [PATCH v2 1/2] iio: proximity: sx9310: " Arnav Kapoor
2026-11-09 16:51 ` [PATCH v2 2/2] iio: proximity: sx9360: " Arnav Kapoor
2026-11-09 18:49 ` [PATCH v2 0/2] iio: proximity: sx9310/sx9360: " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261109165200.305266-1-kapoorarnav43@gmail.com \
--to=kapoorarnav43@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®