Re: [PATCH v3 1/2] PCI: tegra194: Use FIELD_*() for register fields

[Bjorn Helgaas <helgaas@kernel.org>]

On Mon, Nov 02, 2026 at 02:52:37PM +0530, Manikanta Maddireddy wrote:
> Several Tegra194 APPL and DesignWare register fields are programmed
> with open-coded shifts, which makes the register programming more
> verbose than necessary.
> 
> Use FIELD_PREP(), FIELD_MODIFY() and FIELD_GET() at the Tegra call
> sites where values are shifted into fields. The LTSSM state constants
> are converted from pre-shifted register values to unshifted field
> values for FIELD_GET().
> 
> Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
> Link: https://lore.kernel.org/r/20260515070753.3852840-2-mmaddireddy@nvidia.com

Thanks for this patch; it's great to get rid of the redundant *_SHIFT
definitions.

But I'm confused about why this Link: is here.  It points to "[PATCH
v3 1/2] PCI: tegra194: Use aspm-l1-entry-delay-ns DT property for L1
entrance latency", which looks like a functional change.

This patch should be zero functional changes; it should be purely
mechanical changes from explicit shifts to using FIELD_MODIFY() etc.

This patch doesn't mention aspm-l1-entry-delay-ns, so it doesn't
*look* like this includes the [PATCH v3 1/2] content.