From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.168.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794276479; b=nDV0G8ySQotEP2ykJgvJES1t7mgImmLyqqtLtqG1KfAwZWwdAMsoYmBItDx4f+eKbVd7 +m5qal8iO06lCzt1INOQp76anVT5mMPxnkjO4j1Pf5s2qi4H9lwunvU/ub8w35KeBSH4T cLIMQMtkNqA93xL+sprGcFSW6nJgCoN+vqzlQZucXM2mp4kL5UaASMX7B0iwGZjUexGYG WAibAtFtNqDbGYNSV7S4WKhOhkxRYcOX2798wlqdI9kE7FrI5MhomGWAUiU7UC12JL2UB kbDWXcj6c8s/TAiZtbf6BFig3z+ITl4IWSEVrEGiy09r2XqiUF16jJb6Fj5JPPuJNpg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794276479; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Gm-Message-State:X-Gm-Gg: X-Received:X-Received:Received:Date:From:To:Cc:Subject:Message-ID: In-Reply-To:References:Organization:X-Mailer:MIME-Version: Content-Type:Content-Transfer-Encoding:X-Proofpoint-Spam-Details-Enc: X-Proofpoint-GUID:X-Proofpoint-ORIG-GUID:X-Proofpoint-Spam-Info: X-Authority-Analysis:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=Gzh0jbXLioqQjgqKAH32s/RDc3mnON1vZDCgrDAnmOU=; b=RSXgMjFMc5zaivLKv1necqgf5TTYR2FmQa05/Dv0wqgfirjrFg41yvlkbJ5jHu+Icyhq FwSv3z4FYn2h9Y83aJXSe6VCYjgzHe4wutaZGVElbwPHl2cQQQE4SdBJ/ZPtBkjdDkP1J 39v9254mrHN13uMm/6HczETi0fv78XwUjLPDkSLSDZ2iAAuQv5wdYcYP3tOQrCBGUKltI 8or0lYYJdDSear4JHxfTN1sob1vAOXkJG/LjNUvANkQGvF3ty6tWrWnJm8E+pPoyPfUfq Xpj78H2bomY9jFkM114OqmFOd4l7qxSoImxD2Q8I3zhRrhP/+DbCRnShsx4gnLV6x5g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=Mm9NkHN6; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=eLPLNYtj; arc=none smtp.remote-ip=205.220.168.131 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D74C7606A336 for ; Tue, 10 Nov 2026 02:07:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D74C7606A336 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=Mm9NkHN6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=eLPLNYtj Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6AA0jTC6237293 for ; Tue, 10 Nov 2026 02:07:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Gzh0jbXLioqQjgqKAH32s/RDc3mnON1vZDCgrDAnmOU=; b=Mm9NkHN6Zj756Mhy mSX1hHZcKC+vcG5YLjqGOa5t+mJxEXGCK2zfLfPBDmsxiQ/MehoccxiCria080oN bkYpObyiygb/TnV68u+OOYaB7iUT8Pw4YhuRBzmKlsr/f77wsfV1xLGoyuofOE1Q cvPjEyxsUZIk0sN75d/r/oeeFh6MjrQjf9VXbTId3lTOa7lnOdjJW1X4Szua5bfI fmI6n6BYE4hnUWF4ev35kGreXzpT0OOnI8Q7ei5nAdXJmd+h9Bzdl8Mq2QCnilyS zIOJL297SWPq0u7MMzRQCwqfnj+AmPyWPLa/f+nlKeJv1mGyhDIejbJtB2R/ahBZ NpRV3w== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hubt8u9ju-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Nov 2026 02:07:57 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-370230d93efso729506eec.1 for ; Mon, 09 Nov 2026 18:07:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1794276477; x=1794881277; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to:content-type; bh=Gzh0jbXLioqQjgqKAH32s/RDc3mnON1vZDCgrDAnmOU=; b=eLPLNYtjfhShMTjdtQSuobm+92iNjNjsMgpwcCQiWSavcphETKxVUYkLrUMVGHcCFT FhlZBH7wm8YaE/zrgBzRweWDXogYcRbLPHceaVDFR5yrBgo6wG8Rz4Xllyp4uNfk2Hqw 0gpGtcUjDkWyg+FJ9Y0WvHKoQXqwzvQYsH/U/JLCAFG11m8htLTAD2NvswRs6qoRJW32 z/JL2ZTTmsGA6T9s1lsJHLFuvxUh9GFIm6TWwmzSrbRW6MaJqmvLOPXn5Zaqcl1PpNf8 wj+PX/VCs0GZicIp2nSCeEc8Fajo/KH7yjYUbczOJXR9O9hkNITlU0pukwt2FF8WxXrf dF8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794276477; x=1794881277; h=content-transfer-encoding:content-type:mime-version:organization :references:in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Gzh0jbXLioqQjgqKAH32s/RDc3mnON1vZDCgrDAnmOU=; b=pQY3lOTqvgmmL6la1Yj6iSoUAMpPknLoGWAxE3+MlFeLDrCbjIpunPa2COET2NNX2P N2ZVEASCmriWaq6D1UYKGrEoasWt/i1bsJac4yAfW9s3uYHOdxeoJRc53zdx+0JL6HmF M3q/7ei62E6kljvn5d6V3qFfoC4PdDbvHrbGml1/dvuCDPElmEHN9TwoBFm5oLncaI4q Pmy2N8Q1O+6uLIq7zHQlQuIRmP5Y5Rkvz+8p52Loxt2+wRitWpQlqsQEBL8vwlS3z+R8 vxrM3D567+q6K6z5lONajVObiHOR/+znBqyAZ+26U4yV2a7yAafJsO/n0lyhWacDZq+Q h7Zw== X-Gm-Message-State: APuU4Z+2d/W15u7thcbscGgpqSVBRh9m1iBnyb6OMQEsIwKgWgLbq6rg F+Q7BcuGf21VKvBx0LmpI1+kvZ8ivDSJ6D5Xp9LklsnIb9wg4B5DfY3zczWFXAn+rihnkGXX/UN cnGeAi/QGCn5hsOWLf5jZxe7BrR8l0gpj6DNS1iUiNPPPRXY2sKNyKqNln1XEw+tYPi0Ohsb8FO k= X-Gm-Gg: AYBFou0VMfIHwokRymtw/0CUih5Nkma4p236eeMEg80hPYq/CRAc9tFCOBnrdParG6M JShdiFj7qLpkEYKvofGra6oYA1MQUtoFqnF79CrC7ttgBkXjHp4IcJpyeJKgehpHzvfE8DmR5lc ikSJsG2rZXBEnl+ui2RHHO60TSoGthLb3tCW2eXKTOOtx7zejn4YvSM8mGMJ0A+IaIYLUPXLqNQ 9yXIowkH0iZHoizHxAQXeuFD6MtnB1hgV5Ng3fchHegGzg4WxJuTdBFHW1ZIacZR5DGjpO02t6q RIk4xcPxW5FYtCHj8R1K9NQfGtZoSsqHQoWQYhXmwwuMqTBZypzTJgzjaq2V33RNy5cwUgPMfyZ +/Q6NluxiSXiRdjOuH7U5BsVgiJc4wMPChp8Gjcds0v8HmilTzabdSfJErtC5Q+7uGS4AtUUGUc 2vMyYrI5YgmAm6wpEpVu1mUps3VQ== X-Received: by 2002:a05:701a:844d:20b0:18c:e014:6f1d with SMTP id a92af1059eb24-1b3b5fa29b1mr1724896c88.1.1794276477150; Mon, 09 Nov 2026 18:07:57 -0800 (PST) X-Received: by 2002:a05:701a:844d:20b0:18c:e014:6f1d with SMTP id a92af1059eb24-1b3b5fa29b1mr1724846c88.1.1794276476426; Mon, 09 Nov 2026 18:07:56 -0800 (PST) Received: from localhost (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1b3b5b11435sm3158465c88.4.2026.11.09.18.07.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2026 18:07:56 -0800 (PST) Date: Mon, 9 Nov 2026 18:07:50 -0800 From: Jonathan Cameron To: Cristian Marussi Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, linux-doc@vger.kernel.org, sudeep.holla@kernel.org, james.quinlan@broadcom.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, etienne.carriere@st.com, peng.fan@oss.nxp.com, michal.simek@amd.com, d-gole@ti.com, elif.topuz@arm.com, lukasz.luba@arm.com, philip.radford@arm.com, david@kernel.org, souvik.chakravarty@arm.com, leitao@kernel.org, kas@kernel.org, puranjay@kernel.org, usama.arif@linux.dev, kernel-team@meta.com Subject: Re: [PATCH v15 12/35] firmware: arm_scmi: Add Telemetry update intervals enumeration Message-ID: <20261109180750.0000150a@oss.qualcomm.com> In-Reply-To: <20261109091221.2532706-13-cristian.marussi@arm.com> References: <20261109091221.2532706-1-cristian.marussi@arm.com> <20261109091221.2532706-13-cristian.marussi@arm.com> Organization: Qualcomm X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTEwMDAwOCBTYWx0ZWRfX6BtzEKCkv+kP amOb+hLEEhDuGwqsot3wM+gbFnQPWwqjD6/Uk1cvaPD6uTiGKA2fruO8DSIUZ8+TcTJeMgVUB4k baXo8rQQWVB3ZTqkzd2GwI3Kn0yJPn4rEsZzhVRvVamt0aG3RkVfrwlXOiQlK4wtTGhH3PJDMSr w9Mb1929Iy276xvU4mBmXiwi5/UM4hLibs3j0atYecTXQgXhANOMmPl6u71h5I/XeEw3qsxURp0 HZUU9feL/R5+uP+MFjRGCVaFNA6aM9a5aoZCheDAr5P671UsQQsNcUuM2luaRK4WiatviV0LH+e 0si2Qoy6FGxLGxqjYe16BWGUCDVJIou15LZCnpU31im50PnJD3f0c1saLcQeE/Qnb+Ooa4zjgrj i4odNZJNrpnQCwJhODMKyw7TX91skqGz2IJd/VnEr/XSP/UoFc2zorw9GRg9/VsPqXFhKEiP25u 0zmaWi/ssNc7s9eRB4w== X-Proofpoint-GUID: FIxfcDVPVgf8cQAlYY9a-8rERt6wYKKr X-Proofpoint-ORIG-GUID: FIxfcDVPVgf8cQAlYY9a-8rERt6wYKKr X-Proofpoint-Spam-Info: AW1haW4tMjYxMTEwMDAwOCBTYWx0ZWRfXzxgGNgkRM/Sx NyEyI3bfYe139nu11t1F0PBC25RNYZ0CAB3/Ts7+eGHlWb1vXFY1BDXIj16Km/MGSG3MS6EvrTl UefuvHOZrSNxypQtgzbe52+0b7PIZc4= X-Authority-Analysis: v=2.4 cv=Yr+a1IYX c=1 sm=1 tr=0 ts=6af27c7d cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=kj9zAlcOel0A:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=7CQSdrXTAAAA:8 a=M8WuIlgHp6E56V_sPrAA:9 a=CjuIK1q_8ugA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 a=a-qgeE7W1pNrGK8U0ZQC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-10_01,2026-11-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611100008 On Mon, 9 Nov 2026 09:11:58 +0000 Cristian Marussi wrote: > Add support to enumerate available Telemetry update intervals. > > Signed-off-by: Cristian Marussi > --- > v14 --> v15 > - removed unused dev reference in interval parsing > - added missing initialization of intrvs->grp_id > v13 --> v14 > - splitted out of the old Basic Telemetry patch, contains the > update_intervals enumeration routines > --- > drivers/firmware/arm_scmi/telemetry.c | 198 ++++++++++++++++++++++++++ > include/linux/scmi_protocol.h | 21 +++ > 2 files changed, 219 insertions(+) > > diff --git a/drivers/firmware/arm_scmi/telemetry.c b/drivers/firmware/arm_scmi/telemetry.c > index 9944506652f5..e57534c93b26 100644 > --- a/drivers/firmware/arm_scmi/telemetry.c > +++ b/drivers/firmware/arm_scmi/telemetry.c > @@ -92,6 +92,21 @@ struct scmi_msg_resp_telemetry_de_description { > struct scmi_de_desc desc[]; > }; > > +struct scmi_msg_telemetry_update_intervals { > + __le32 index; > + __le32 group_identifier; > +#define ALL_DES_NO_GROUP 0x0 > +#define SPECIFIC_GROUP_DES 0x1 > +#define ALL_DES_ANY_GROUP 0x2 For previous defines like this they have followed the value they are in. So I think these belong after flags. (That fits with common practice for this sort of thing which is why I looked). > + __le32 flags; > +}; > + > +struct scmi_msg_resp_telemetry_update_intervals { > + __le32 flags; > +#define INTERVALS_DISCRETE(x) (le32_get_bits((x), BIT(12)) == 0) > + __le32 intervals[]; > +}; > + > #define IS_TDE_TSTAMP_TYPE(__t, __ttype) ((__t)->ts_type == (__ttype)) > #define IS_TDE_TS_NONE(_t) (IS_TDE_TSTAMP_TYPE((_t), TSTAMP_NONE)) > #define IS_TDE_TS_LINE(_t) (IS_TDE_TSTAMP_TYPE((_t), TSTAMP_LINE)) > @@ -693,6 +708,176 @@ static int scmi_telemetry_de_descriptors_get(struct telemetry_info *ti) > return scmi_telemetry_de_groups_init(ti); > } > > +struct scmi_tlm_ivl_priv { > + struct scmi_telemetry_intervals **intrvs; > + unsigned int grp_id; > + unsigned int flags; Given these are fixed size, maybe u32 for each of them just to make sure that matches up. > +}; > + > +static void iter_intervals_prepare_message(void *message, > + unsigned int desc_index, > + const void *priv) > +{ > + struct scmi_msg_telemetry_update_intervals *msg = message; > + const struct scmi_tlm_ivl_priv *p = priv; > + > + msg->index = cpu_to_le32(desc_index); > + msg->group_identifier = cpu_to_le32(p->grp_id); > + msg->flags = cpu_to_le32(FIELD_PREP(GENMASK(3, 0), p->flags)); Need the mask? It's valid but I'd expect the protection on sanity to be at the point of p->flags being written rather than here. > +} > + > +static int iter_intervals_update_state(struct scmi_iterator_state *st, > + const void *response, void *priv) > +{ > + const struct scmi_msg_resp_telemetry_update_intervals *r = response; > + > + st->num_returned = le32_get_bits(r->flags, GENMASK(11, 0)); > + st->num_remaining = le32_get_bits(r->flags, GENMASK(31, 16)); > + > + if (st->rx_len < (sizeof(*r) + sizeof(r->intervals[0]) * st->num_returned)) > + return -EINVAL; > + > + /* > + * total intervals is not declared previously anywhere so we > + * assume it's returned+remaining on first call. > + */ > + if (!st->max_resources) { > + struct scmi_tlm_ivl_priv *p = priv; > + struct scmi_telemetry_intervals *intrvs; > + bool discrete; > + int inum; > + > + discrete = INTERVALS_DISCRETE(r->flags); > + /* Check consistency on first call */ > + if (!discrete && (st->num_returned != 3 || st->num_remaining != 0)) > + return -EINVAL; > + > + inum = st->num_returned + st->num_remaining; > + intrvs = kzalloc_flex(*intrvs, update_intervals, inum); > + if (!intrvs) > + return -ENOMEM; > + > + intrvs->num_intervals = inum; > + intrvs->discrete = discrete; > + intrvs->grp_id = p->grp_id; > + st->max_resources = intrvs->num_intervals; > + > + *p->intrvs = intrvs; > + } > + > + return 0; > +} > + > +static int > +iter_intervals_process_response(const struct scmi_protocol_handle *ph, > + const void *response, > + struct scmi_iterator_state *st, void *priv) > +{ > + const struct scmi_msg_resp_telemetry_update_intervals *r = response; > + struct scmi_tlm_ivl_priv *p = priv; > + struct scmi_telemetry_intervals *intrvs = *p->intrvs; > + unsigned int idx = st->loop_idx; > + > + intrvs->update_intervals[st->desc_index + idx] = > + le32_to_cpu(r->intervals[idx]); I'd go a bit long and put that on one line. > + > + return 0; > +} > +static int > +scmi_telemetry_enumerate_common_intervals(struct telemetry_info *ti) > +{ > + unsigned int flags; > + int ret; > + > + flags = !ti->info.per_group_config_support ? > + ALL_DES_ANY_GROUP : ALL_DES_NO_GROUP; Why not flip the condition and reverse the values? This thing is weird enough I'd add a comment or rename them to be more helpful. ALL_DES_THAT_HAVE_NO_GROUP for example. > + > + ret = scmi_tlm_enumerate_update_intervals(ti, &ti->info.intervals, > + SCMI_TLM_GRP_INVALID, flags); > + if (ret) > + return ret; > + > + /* A copy for UAPI access... */ > + ti->info.base.num_intervals = ti->info.intervals->num_intervals; > + > + /* Delegate freeing of allocated intervals to unbind time */ > + return devm_add_action_or_reset(ti->ph->dev, > + scmi_telemetry_intervals_free, > + ti->info.intervals); > +} > /**