From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.208.71 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794248759; b=hZbxAdfgb8q7uYtMa1ZYQi4GgSUfVQvFqBji89cAKXUChvPovpEXVmFFgVD4GfjDmAmV FDtkNx9TlFj7+5EtOXgOPnqeECaUpUngRaxd2H79X/riqUpukrrugrJscvWKLLBj0+N84 JOHihT+gcOpnolQ6TAmAyh+eI71nM9tN7CUxTOFrqrgQ4LHGL4zHHXAp1GJiFxSVo6bnH 9VVGMAp62AYbqBoEyBbRy8vdJPR3x66NIim0Lc0GhJzxuuDlfq6rWZiw6t6S3Cr0Q8bKO 1friwOp+rI5oGdnn4tOs3/E6qtDEV+q14yMUVYqa9WwKX6IoAwRCBNdSZVINZkoDK9w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794248759; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=+CkU7K8AN4V+yWUdhaz7RzC7M7eZI1Az06smW8kAgic=; b=fX9OqdLuYYuRK91vxKXlDzHPnPDIyRfZ0M5j1QpO3ype6d6Z2ixI3rhUGu5eLFBt2xRH T0IKnpMBlsPuHOeTdehusmvWbn70iUfxIvpiLpR7DeP2/2NkflxIYBP9kPSROIu3cC0jP W3smq80SV9/XVA6pcMP/dqwTJUCNq9KLnDFpWk88TNKqe1WWau1mNfsP2Y5frOuQz2I2O vZN1dyVMdBA8IGbtOHkfpgpKhcFlbOOhSWu+KRgdGPraZgDOEiifXTee2EPidTehLOjUB DFaaVlqlnl3JLZDQcCjcVZEjD2zt2htuBozPnyGASY7omicu6+GwZqks9SsMbgOwX2Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--lrizzo.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=R6OAKMoz; arc=none smtp.remote-ip=209.85.208.71 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 816E4606F38A for ; Mon, 9 Nov 2026 18:25:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 816E4606F38A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--lrizzo.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=R6OAKMoz Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-6b57668479aso1342013a12.0 for ; Mon, 09 Nov 2026 10:25:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1794248758; x=1794853558; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+CkU7K8AN4V+yWUdhaz7RzC7M7eZI1Az06smW8kAgic=; b=R6OAKMozRhsfHxc8EcFZ+huhXHTUifLuDNzp7irGIsSVjqGoEY8d3mnCj8nZacKwCK tQjHTykFoNlf0UYBL86bFR60Ft9ii0rZNy4AnXfoDNBGCqinPb8lYiDputfVY37esCod Stwu2HR69qRmwMRHsFxx8NkupoLJfp0s88yuwKkYT6rme4ICe+iHCiInAXkwoeeA1+w9 cyYPFkxgZipGbELGJqF72MWVZUUT2EMNcvjMhAApgAV39wIcFHgte86waciFObzQGRye PybV+ZHUA42kHm/FA1V+PTrZ3xqif6+W415XsAU3kHv7W3f/6IF+E3bwaxK/V6n9F11+ RtNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794248758; x=1794853558; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+CkU7K8AN4V+yWUdhaz7RzC7M7eZI1Az06smW8kAgic=; b=mDp83ePW3sVgRT6SJtcJ0M1T9nDsi1lvOp6BuDjYUBn+5htJaghY7RKLm/ghnNGWdu oIzUX2q5h9KacYC+sqc0FH9axK/Y3z3IydxP+lvbtMsQoVNpcG7FpyyBndRynEfc3DBv pZJimHlR9BrIalSrAuKTiH8FJsAshU2+6EMWo+rtdS7bs1k3TxiBRvFQrUzAfVL/g07h wR5KenmcDsirqzoqdhY8XrLGLgpkeank80IHsQJQqJXhRMkSYu338WwiTDl2V2ZZTGGn B2uCxoe/iMM4AVn3eQsXJSD3RfVSFEM6hI08efszI3k7q4YBZQoV77XnGwf/A2zQLeWW 2M4w== X-Forwarded-Encrypted: i=1; AL+hErGvvrRR6c5SCvVkQji0yLewCsUYSQzMR9GLIVzQSh9J9n0E+vvYtFSps5guBLoBGRhAz4rPP7rX8q/RuVY=@vger.kernel.org X-Gm-Message-State: APuU4Z+jRRHWY+tToN9TLushpwq0mDKNrE3A/K0vkpYJg9w98+HTIUnf Yi9bkRx6708CUfbz53ttubQE+ZEJ2S/H7SR52Turp7jGuYEabLLs9QGNFyFi05n0PMowZGMgY1I BfqUKDg== X-Received: from edqs3.prod.google.com ([2002:aa7:d783:0:b0:6b6:fa4d:3bb9]) (user=lrizzo job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6402:1f05:b0:6b5:7872:3905 with SMTP id 4fb4d7f45d1cf-6b756afbbd0mr357136a12.31.1794248757581; Mon, 09 Nov 2026 10:25:57 -0800 (PST) Date: Mon, 9 Nov 2026 18:25:28 +0000 In-Reply-To: <20261003212241.3432303-1-lrizzo@google.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261003212241.3432303-1-lrizzo@google.com> X-Mailer: git-send-email 2.56.0.542.g3ef89b7020-goog Message-ID: <20261109182533.3594984-21-lrizzo@google.com> Subject: [RFC PATCH v2 20/25] net/libeth: Use GFP_KERNEL when pre-filling RX rings From: Luigi Rizzo To: Luigi Rizzo , Joerg Roedel , Will Deacon , Robin Murphy , Christoph Hellwig , Marek Szyprowski , Andrew Morton , Vlastimil Babka , David Hildenbrand , Jens Axboe , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Greg Kroah-Hartman , "Rafael J . Wysocki" , Danilo Krummrich , Jonathan Corbet , Matthew Wilcox , Lorenzo Stoakes , Jesper Dangaard Brouer , Ilias Apalodimas , Willem de Bruijn , Kuniyuki Iwashima , Joshua Washington , Harshitha Ramamurthy , Alexander Lobakin , iommu@lists.linux.dev, netdev@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, driver-core@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Luigi Rizzo Content-Type: text/plain; charset="UTF-8" libeth_rx_alloc() is called both when pre-filling RX fill queues in process context (for indices 0 .. fq->count - 2, when buf->truesize is still 0) and when refilling RX buffers from NAPI softirq. Use GFP_KERNEL during the initial process-context ring fill so page_pool and PISA page allocations (including set_memory_decrypted() under CoCo) are not forced into GFP_ATOMIC context. Signed-off-by: Luigi Rizzo --- include/net/libeth/rx.h | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/include/net/libeth/rx.h b/include/net/libeth/rx.h index 0e736846c5e8a..de1e5fe44aa40 100644 --- a/include/net/libeth/rx.h +++ b/include/net/libeth/rx.h @@ -106,10 +106,17 @@ void libeth_rx_fq_destroy(struct libeth_fq *fq); static inline dma_addr_t libeth_rx_alloc(const struct libeth_fq_fp *fq, u32 i) { struct libeth_fqe *buf = &fq->fqes[i]; + /* fq->fqes is zero-allocated and pre-filled in process context for + * indices [0 .. fq->count - 2]; slot fq->count - 1 is first allocated + * in NAPI. Use GFP_KERNEL for initial pre-fill and GFP_ATOMIC after. + */ + gfp_t gfp = (buf->truesize || i == fq->count - 1) ? + GFP_ATOMIC : GFP_KERNEL; buf->truesize = fq->truesize; - buf->netmem = page_pool_dev_alloc_netmem(fq->pp, &buf->offset, - &buf->truesize); + buf->netmem = page_pool_alloc_netmem(fq->pp, &buf->offset, + &buf->truesize, + gfp | __GFP_NOWARN); if (unlikely(!buf->netmem)) return DMA_MAPPING_ERROR; -- 2.56.0.542.g3ef89b7020-goog