mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Igor Velkov <iav@iav.lv>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Shawn Lin" <shawn.lin@rock-chips.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Rob Herring" <robh@kernel.org>,
	linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, "Igor Velkov" <iav@iav.lv>
Subject: Re: [PATCH] PCI: rockchip-host: Enable async probe by default
Date: Mon, 09 Nov 2026 22:47:39 +0200	[thread overview]
Message-ID: <20261109204122.async-probe-reply@iav.lv> (raw)
In-Reply-To: <20261109202202.GA265423@bhelgaas>

On Mon, Nov 09, 2026 at 02:22:02PM -0600, Bjorn Helgaas wrote:
> I don't know what the SD card has to do with PCIe.  Seems like there's
> some SD issue, and making PCIe async happens to avoid it?  Sounds
> fragile to me.
>
> Other changes like c0e1eb441b1d justify it by allowing other drivers
> to load in parallel to reduce boot time, which is a good reason.  But
> apparently here it makes a functional difference as well, which feels
> sketchy.  E.g., what other drivers need to use async probe to avoid
> similar issues?

You're right that the real problem is ordering: nothing makes dw_mmc wait
for the RK3399 io-domain driver, which sets the 1.8 V level of the SD
pins. [1] tried to add that dependency and was not merged. Async probe
only stops this driver from holding the deferred-probe worker for ~0.7 s;
any other slow probe in that window breaks UHS the same way.

Is there a way to express this dependency that you would accept?

[1] https://lore.kernel.org/all/20230904115816.1237684-1-s.hauer@pengutronix.de/

--
Igor Velkov

  reply	other threads:[~2026-11-09 20:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-03  6:07 Igor Velkov via B4 Relay
2026-11-07 17:06 ` Manivannan Sadhasivam
2026-11-09 20:22 ` Bjorn Helgaas
2026-11-09 20:47   ` Igor Velkov [this message]
2026-11-09 20:59     ` Bjorn Helgaas
2026-11-09 21:07       ` Igor Velkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261109204122.async-probe-reply@iav.lv \
    --to=iav@iav.lv \
    --cc=bhelgaas@google.com \
    --cc=heiko@sntech.de \
    --cc=helgaas@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=robh@kernel.org \
    --cc=shawn.lin@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®