mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Priyank Rathod <rathodpriyank@google.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: bhelgaas@google.com, lukas@wunner.de,
	 sathyanarayanan.kuppuswamy@linux.intel.com,
	ilpo.jarvinen@linux.intel.com,  dave.jiang@intel.com,
	prarit@redhat.com, ying.huang@linux.alibaba.com,
	 terry.bowman@amd.com, corbet@lwn.net, jic23@kernel.org,
	 danielmaraboo@gmail.com, linux-doc@vger.kernel.org,
	linux-pci@vger.kernel.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI/AER: Make aer_mask_override effective for injected errors
Date: Mon,  9 Nov 2026 21:57:04 +0000	[thread overview]
Message-ID: <20261109215704.1852183-1-rathodpriyank@google.com> (raw)
In-Reply-To: <20261028173038.292999-1-rathodpriyank@google.com>

On Wed, Oct 28, 2026 at 05:30:38PM +0000, Priyank Rathod wrote:
> Good point, thank you.  Would a shorter commit log like the following
> look better to you?
>
>   aer_mask_override=1 is supposed to allow injecting masked errors, but
>   aer_inject() corrupts the hardware Mask registers with "&= !" and
>   restores them before irq_inject_interrupt(), so aer_isr() still drops
>   the error as masked.  Emulate aer_mask_override in config space reads
>   and writes instead of modifying the hardware Mask registers, and
>   document the parameter with MODULE_PARM_DESC().
>
> I am happy to send a v2 with this updated commit message, unless you
> prefer to adjust it directly when applying.

Hi Bjorn,

Gentle ping on this series now that v7.4-rc1 is out (both patches still
apply cleanly to v7.4-rc1 and pci/next).

Please let me know if the shorter commit description above looks good to
fold in when applying, or if you would prefer that I post a v2.

Thanks,
Priyank

  reply	other threads:[~2026-11-09 21:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-12 20:53 [PATCH 0/2] PCI/AER: Fix and document aer_inject's aer_mask_override Priyank Rathod
2026-10-12 20:53 ` [PATCH 1/2] PCI/AER: Make aer_mask_override effective for injected errors Priyank Rathod
2026-10-27 23:08   ` Bjorn Helgaas
2026-10-28 17:30     ` Priyank Rathod
2026-11-09 21:57       ` Priyank Rathod [this message]
2026-10-12 20:53 ` [PATCH 2/2] Documentation: PCI: Document aer_inject's aer_mask_override parameter Priyank Rathod
2026-10-25 14:19   ` Daniel Pereira
2026-10-26 17:57     ` Priyank Rathod
2026-10-27 14:34       ` Daniel Pereira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261109215704.1852183-1-rathodpriyank@google.com \
    --to=rathodpriyank@google.com \
    --cc=bhelgaas@google.com \
    --cc=corbet@lwn.net \
    --cc=danielmaraboo@gmail.com \
    --cc=dave.jiang@intel.com \
    --cc=helgaas@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jic23@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=prarit@redhat.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=terry.bowman@amd.com \
    --cc=ying.huang@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®