From: Goran Sustek <gsustek@gmail.com>
To: Jeff Johnson <jjohnson@kernel.org>
Cc: Kalle Valo <kvalo@kernel.org>,
Baochen Qiang <baochen.qiang@oss.qualcomm.com>,
linux-wireless@vger.kernel.org, ath12k@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH ath-next v2 0/2] wifi: ath12k: PPDU stats user count fixes
Date: Mon, 9 Nov 2026 23:53:53 +0100 [thread overview]
Message-ID: <20261109225355.23161-1-gsustek@gmail.com> (raw)
ath12k_htt_pull_ppdu_stats() rejects PPDU stats messages whose common
TLV reports num_users == HTT_PPDU_STATS_MAX_USERS, although that value
is in bounds for the loop the check protects. QCN9274 firmware
WLAN.WBE.1.6-01243 sends it in BE MU BSRP trigger messages addressed to
two Wi-Fi 7 clients, which makes the warning fire on every such trigger
and fill the log on a two-client AP.
Patch 1 corrects the bound and keeps the warning for larger values.
Patch 2 fixes a related off-by-one: the per-user slot finder and the
per-user statistics update skip the last user_stats[] slot.
What the data shows (diagnostic build on an AP MLD, 5 and 6 GHz, two
Wi-Fi 7 clients, 2026-11-02 to 2026-11-09):
- Every message with num_users 7 or 8 was frame type 25
(HTT_STATS_FTYPE_SGEN_BE_MU_BSRP) and carried user TLVs for exactly
two stations, with up to four user records per station. num_users
equals the number of user records, not the number of stations.
- The same firmware advertises max_user_per_ppdu_ofdma of 8 in
WMI_SERVICE_READY_EXT2, so 8 is the largest value it produces.
- Rejecting a message has no functional effect beyond the warning: the
user TLVs are already stored when the check runs, and the per-peer
statistics are applied when the entry leaves the list.
Changes in v2:
- Keep ath12k_warn() (Jeff Johnson); only the bound and the text change.
- Add patch 2 for the slot finder and update loop.
- Base on current ath-next.
v1: https://lore.kernel.org/r/20261101203718.60679-1-gsustek@gmail.com
Goran Sustek (2):
wifi: ath12k: accept num_users equal to HTT_PPDU_STATS_MAX_USERS
wifi: ath12k: use all HTT_PPDU_STATS_MAX_USERS slots for PPDU users
drivers/net/wireless/ath/ath12k/dp_htt.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
base-commit: d0fbb39d65dc9dcb4175fa6b23e473dec3670f4d
--
2.56.0
next reply other threads:[~2026-11-09 22:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 22:53 Goran Sustek [this message]
2026-11-09 22:53 ` [PATCH ath-next v2 1/2] wifi: ath12k: accept num_users equal to HTT_PPDU_STATS_MAX_USERS Goran Sustek
2026-11-09 22:53 ` [PATCH ath-next v2 2/2] wifi: ath12k: use all HTT_PPDU_STATS_MAX_USERS slots for PPDU users Goran Sustek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261109225355.23161-1-gsustek@gmail.com \
--to=gsustek@gmail.com \
--cc=ath12k@lists.infradead.org \
--cc=baochen.qiang@oss.qualcomm.com \
--cc=jjohnson@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®